[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.05-1-36-g68f549f

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  68f549fbb6e4be28c7b73f6b79fa87a1034c2e3a (commit)
       via  1de703b509589981be563fd81beab816195782dc (commit)
      from  371723e94e39ad9750831007bf5fe47305e2da65 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 68f549fbb6e4be28c7b73f6b79fa87a1034c2e3a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jul 1 14:13:15 2019 -0300

    Bug 23246: (follow-up) Hardcoding tab position is not enough
    
    There are many conditions that determine the tab number for 'media'.
    Translated into variables that hold the tabs count on each condition, it
    is clear that '3' was not good enough:
                [%- holdings      = (SeparateHoldings)   ? 2 : 1
                    notes         = (MARCNOTES || notes) ? 1 : 0
                    acq           = (Koha.Preference('AcquisitionDetails')) ? 1 : 0
                    frbr          = (FRBRizeEditions  && XISBNS) ? 1 : 0
                    local_covers  = (LocalCoverImages && (localimages || CAN_user_tools_upload_local_cover_images)) ? 1 : 0
                    media_tab     = holdings + notes + acq + frbr + local_covers
                -%]
    
    This patch gets rid of the hardcoded value, adds an id to the 'media'
    tab (i.e. 'media_tab') and uses JS to get the right index.
    
    To test:
    - Play with the different options governing those variables
    => FAIL: 3 is not always the 'media' tab
    - Apply this patch
    - Repeat your tests
    => SUCCESS: It always picks the 'media' tab
    - Sign off :-D
    
    Sponsored-by: American Numismatics Society
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 0e21de15d61999183ea17624465ab0bc1a6c867e)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 1de703b509589981be563fd81beab816195782dc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jul 1 13:16:42 2019 -0300

    Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled is set
    
    This patch makes jumping into the third tab happen only if
    HTML5MediaEnabled is set to 'both' or 'staff'.
    
    To test:
    - Have HTML5MediaEnabled set to 'opac' or 'not at all'
    - Open the detail page of a record with no holdings
    => FAIL: The 'images' tab is selected
    - Apply this patch
    - Reload
    => SUCCESS: The 'holdings' tab is selected as it should be.
    - Sign off :-D
    
    Sponsored-by: America Numismatic Society
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 7a9d8937f753685471dfde7a62c5871062d41a11)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository