[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.01-27-g03e6ecd

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  03e6ecd31cf11de283cc78a89d713d0714c5a294 (commit)
       via  274271b59d5491dc44ebe7bbfb12da13e96d2ceb (commit)
       via  fee85191b0be2690cbfada45f4eba54ef0e75c35 (commit)
       via  ae409c2fb347f7605e20afb34c6e7fe6a04092bb (commit)
       via  7a9c838b637c0203d3d229c9f8ac2e5e073a1b71 (commit)
       via  9f88e1aa1e372f0c9eb95ed542d3a1b8483ce55c (commit)
      from  965d86ecf804f4e761282ece8994e492e8084f0a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 03e6ecd31cf11de283cc78a89d713d0714c5a294
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Jan 8 14:01:45 2019 +0000

    Bug 22030: DBRev 18.11.01.001
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 70abd7698f02a7da791490607f43df9f781390d2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 274271b59d5491dc44ebe7bbfb12da13e96d2ceb
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Dec 19 17:53:08 2018 +0000

    Bug 22030: Use preference to determine username sent to overdrive
    
    Overdrive configuration generally defaults to cardnumber, however, they
    have confirmed that some libraries use usernames. We need to allow for
    both scenarios.
    
    To test:
    1 - Have an OverDrive account setup with SIP authentication
        Note: You can apply for a testing account at developer.overdrive.com
        and setup an environment
    2 - Fill in all your OverDrive system preferences
    3 - Test with a patron whose username is their cardnumber
    4 - Confirm their overdrive account tab on opac loads
    5 - Change the username to be another value like "borked_wont_work"
    6 - Note the overdrive account tab won't load
    7 - Apply patch, update database, not new system preference
    OverDriveUsername (default to 'cardnumber)
    8 - Note the OD account loads successfully
    9 - Change the system preference to 'user name' - the account load fails
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 96adab7af8999da7f351169e1265d4be5e59742f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fee85191b0be2690cbfada45f4eba54ef0e75c35
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Dec 13 14:59:38 2018 +0100

    Bug 21605: (follow-up) Simple ternary boolean to number conversion
    
    Imo it is much easier to do just "$a ? 1 : 0" than testing defined($a) etc.
    in the additional loop.
    Less code, more readable?
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 482b323da1e18324941963359b9a1bd96f297c44)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ae409c2fb347f7605e20afb34c6e7fe6a04092bb
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Oct 26 10:42:13 2018 +0100

    Bug 21605: Ensure EDI acct fields set to boolean val
    
    Validate the input to the fields indicating account
    functionality. The only valid values are 1 and 0
    non-integer (or integers other than 0/1) are invalid
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c9c3fc4368ee9d37a45c48167d25d5cee511898b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7a9c838b637c0203d3d229c9f8ac2e5e073a1b71
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Jan 2 09:56:52 2019 -0300

    Bug 22059: Fix exception params in Koha::Patron->set_password
    
    This simple patch fixes a wrong call to ->throw. Parameters shouldn't be
    enclosed in curly brackets.
    
    To test:
    - Apply the tests patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Patrons.t
    => FAIL: Tests fail because the throw call is wrong
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Koha/Patrons.t
    => SUCCESS: Tests pass!
    -Sign off :-D
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4d671103f420f1c0b80bcbf13be613b69e2aa4f9)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9f88e1aa1e372f0c9eb95ed542d3a1b8483ce55c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Jan 2 09:56:21 2019 -0300

    Bug 22059: regression tests
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3ef3ecfe99e219fda854ca57c652e3c52a7f47d7)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                                      |    2 +-
 Koha/Patron.pm                                               |    2 +-
 admin/edi_accounts.pl                                        |   10 +++++-----
 installer/data/mysql/sysprefs.sql                            |    1 +
 installer/data/mysql/updatedatabase.pl                       |   10 ++++++++++
 .../prog/en/modules/admin/preferences/enhanced_content.pref  |    6 ++++++
 opac/svc/overdrive                                           |    8 +++++++-
 t/db_dependent/Koha/Patrons.t                                |    6 +++++-
 8 files changed, 36 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository