[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.01-37-gf8bd298

Thu Jan 10 15:39:14 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  f8bd298a0817bf6811c88fe7b441626c059b4f6f (commit)
       via  a6dc145ce966338ec0ae96f7e32968149647c02f (commit)
       via  84ddb45e884394d08ba4dc836d3209e11e351048 (commit)
       via  d830a2f0973fa6ffd634a9665f93a53c325c2d7a (commit)
       via  aee127e6397db9594c97d06b684cdeabf6f50e0d (commit)
       via  a02a19ffea86e64b65164e7578b5d9b8f611a064 (commit)
       via  61e3b2d869edb6da836655ab9e27de4483a4f047 (commit)
       via  a6326b80c64e3dae593f1a1bc520adfb62c9758e (commit)
       via  8102f6dc70623786c3247e008a0601cfd234d1e6 (commit)
       via  2bc4f25855819990f5d5fbcd244a0ef6dd3d89e6 (commit)
      from  03e6ecd31cf11de283cc78a89d713d0714c5a294 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f8bd298a0817bf6811c88fe7b441626c059b4f6f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jan 7 07:38:29 2019 -0300

    Bug 22071: (follow-up) Add POD for validate_query_parameters

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 551626ce1e82286414c4a77c83febdcfbc99741a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a6dc145ce966338ec0ae96f7e32968149647c02f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jan 7 07:31:43 2019 -0300

    Bug 22071: (follow-up) Simplify code

    In order to add features to this method, the current code would force us
    to do it for each authentication method.

    There's duplicated code that could be simplified. This patch makes the
    authentication code just set $user on each block (oauth and cookie
    authentication) and moves the final permissions check to the end of the
    authenticate_api_request method.

    Overall, the behaviour remains unchanged.

    To test:
    - Run:
      $ kshell
     k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \
              t/db_dependent/api/v1/oauth.t
    => SUCCESS: Tests pass! Nothing changed!
    - Sign off :-D

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0d5058b7b29d90cc7c8e533ee56388fbb5a96d52)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 84ddb45e884394d08ba4dc836d3209e11e351048
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jan 4 12:46:37 2019 -0300

    Bug 22071: Make authenticate_api_request stash koha.user in OAuth use case

    This patch makes the OAuth code stash the requestion Koha::Patron.

    To test:
    - Apply the tests patch:
    - Run:
      $ kshell
     k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
    => FAIL: Tests fail :-(
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
    => SUCCESS: Tests pass :-D
    - Sign off =D

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 613a0034e08af84af1e2198156bbfc6900ba6551)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d830a2f0973fa6ffd634a9665f93a53c325c2d7a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jan 4 12:37:27 2019 -0300

    Bug 22071: Regression tests

    The authenticate_api_request() behaviour needs more tests. This patch
    adds tests for the stashed Koha::Patron object. It highlights the bug in
    the OAuth authentication case.

    To test:
    - Apply this patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
    => FAIL: Tests fail in the OAuth case, pass in the cookie-based auth
    case.

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 2067b8e3f8cb363370897ff179bcdbf5c97cbbbb)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit aee127e6397db9594c97d06b684cdeabf6f50e0d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Oct 31 12:50:27 2018 +0000

    Bug 22073: Add to diacritics mappings for Ž and ž

    To test:
    1 - Find or add a record by author Slavoj Žižek
    2 - Search for 'Zizek'
    3 - No results
    4 - Apply patch
    5 - Reindex
    6 - Search again
    7 - Success!

    https://bugs.koha-community.org/show_bug.cgi?id=22073

    Signed-off-by: Eric Phetteplace <ephetteplace at cca.edu>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5c313bc554a857da29f124957d58459c0ed4c03b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a02a19ffea86e64b65164e7578b5d9b8f611a064
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 19 16:00:52 2018 -0300

    Bug 22020: (bug 21777 follow-up) Fix columns visibility for circulation.pl

    The table is used by circulation.pl and moremember.pl
    When it is modified we need to take care of the two view.

    Test plan:
    Use the columns settings to hide/show the "check in" and other columns
    Confirm the this patch fixes the display for moremember.pl

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 17a8eb187959625ef67eea9999588fe502443691)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 61e3b2d869edb6da836655ab9e27de4483a4f047
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Jan 10 13:54:42 2019 +0000

    Bug 21813: Compiled CSS

    RMaint Note: 18.11.x version of a03eed982bdd28a49f688c742d9e28a780ef12a6
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a6326b80c64e3dae593f1a1bc520adfb62c9758e
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Nov 12 17:35:25 2018 +0000

    Bug 21813: In-page JavaScript causes error on patron entry page

    This patch removes a block of JavaScript from memberentrygen.tt which
    was being included in the page before jQuery is loaded. This causes a
    JavaScript error.

    To test, apply the patch, regenerate CSS, and clear your browser cache
    if necessary.

     - In Administration -> Patron categories, confirm that you have two
        patron categories with different default messaging preferences
        defined.
     - Go to Patrons -> New patron
       - Create a new patron using one of the categories with messaging
         preferences.
       - Confirm that when you switch the category selection to the other
         patron category, the patron messaging preference checkboxes are
         changed to the default for that category.
         - A "Loading" indicator should appear above the checkboxes to show
          that an operation is in process. It should disappear when new
          default prefs are loaded.
       - Manually change one or more patron messaging preference checkboxes.
       - Switch the patron category again and confirm that you are prompted
         to confirm resetting the preferences to the default for that
         category.
     - Perform the same set of tests when editing a patron.
       - Defaults should not be loaded during the edit process.
     - Confirm that there are no other JavaScript errors in the console.
     - Test again with EnhancedMessagingPreferences disabled.

    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3607fdfe7966b4db8cb69331f097278d09363fd2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8102f6dc70623786c3247e008a0601cfd234d1e6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Dec 28 18:48:25 2018 +0000

    Bug 22052: Refactor DeleteExpiredOpacReigstrations

    This patch changes the sub to use Koha::Objects and updates the tests.
    Previously the sub would die on borrowers with checkouts and would
    delete borrowers if they had fines

    To test:
     1 - prove -v t/db_dependent/
     2 - Set your selfreg preferences:
        PatronSelfRegistration: Allow
        PatronSelfRegistrationDefaultCategory: SELFREG (or of your choice)
        PatronSelfRegistrationExpireTemporaryAccountsDelay: 30
     3 - Register a patron into SELFREG or how you set above
     4 - Set their date enrolled to two months ago
     5 - Checkout an item to the patron
     6 - Issue a fine to that patron
     7 - perl misc/cronjobs/cleanup_database.pl --del-exp-selfreg -v
     8 - The job should die with an error
     9 - Check in the item
    10 - run the corn again - patron is deleted, oops
    11 - Apply patch
    12 - Create another patron in the same way
    13 - Checkout and fine the patron
    14 - run the cron
    15 - they are not deleted, and no error
    16 - checkin the item
    17 - run the cron
    18 - they are not deleted and no error
    19 - clear the fine
    20 - run the cron
    21 - patron is deleted, huzzah

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b32756a5d7819e13290c2a145f3f0009280785c4)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2bc4f25855819990f5d5fbcd244a0ef6dd3d89e6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Dec 28 18:48:15 2018 +0000

    Bug 22052: Unit tests

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f44e37b201d0a8b95b1eee0ac0766bed9c386fc2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                                      |   40 +++---
 Koha/REST/V1/Auth.pm                               |  110 ++++++++-------
 admin/columns_settings.yml                         |    5 +
 etc/zebradb/etc/word-phrase-utf.chr                |    2 +
 .../intranet-tmpl/prog/css/src/staff-global.scss   |    9 ++
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |    2 +-
 .../prog/en/modules/members/memberentrygen.tt      |   50 +------
 .../prog/js/messaging-preference-form.js           |   48 +++++++
 t/db_dependent/Members.t                           |   35 ++++-
 .../api/v1/auth_authenticate_api_request.t         |  145 ++++++++++++++++++++
 10 files changed, 320 insertions(+), 126 deletions(-)
 create mode 100755 t/db_dependent/api/v1/auth_authenticate_api_request.t

hooks/post-receive
-- 
main Koha release repository