[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.01-43-g5e1efa8

Thu Jan 10 17:42:23 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  5e1efa83f7deb365682e0405b84963c36a40e5da (commit)
       via  204801e172143ff6fe00b1d52a440fcf14b1f3b7 (commit)
       via  7a73983a9995e06c2ac27a484d5104a735dfb3aa (commit)
       via  86342bf68127192e0bc14767ef0f546ebdea4d97 (commit)
       via  9765cab77792f50195454581adaa597eb86b5688 (commit)
       via  2cd12cf6bca9035705774a29d990603383345b8c (commit)
      from  f8bd298a0817bf6811c88fe7b441626c059b4f6f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5e1efa83f7deb365682e0405b84963c36a40e5da
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jan 4 02:51:03 2019 +0000

    Bug 21915: DBRev 18.11.01.002

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 10f78fcb2efec81b3c2024c97dbb55b21a3c14a8)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 204801e172143ff6fe00b1d52a440fcf14b1f3b7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 30 10:28:48 2018 -0300

    Bug 21915: Add a cli script to reconcile balances

    This patch adds a CLI script, reconcile_balances.pl that takes care
    of calling the reconcile operation for all patrons that have outstanding
    credits.

    A weird situation has been spotted in the wild, in which a debit ends up
    actually being a credit, because amount outstanding is tweaked in
    dropbox-mode returns. Until we figure what to do about that (probably a
    new account type, etc), we catch any exceptions and warn about the
    situation.

    To test:
    - Have patrons with outstanding credits and debits
    - Run the script:
      $ kshell
     k$ perl misc/cronjobs/reconcile_balances.pl --verbose
    => SUCCESS: Notice patrons got their balances reconciled, and useful
                information is output.
    - Add new outstanding credits and debits to patrons you con easily
    identify
    - Run:
     k$ perl misc/cronjobs/reconcile_balances.pl
    => SUCCESS: Notice balances are reconciled, but no output
    - Run:
     k$ perl misc/cronjobs/reconcile_balances.pl --help
    => SUCCESS: Usage information is printed.
    - Sign off :-D

    Sponsored-by: ByWater Solutions
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 38530140176ddcb2f9d2ded7dea5382f4816e12f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7a73983a9995e06c2ac27a484d5104a735dfb3aa
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 30 09:54:56 2018 -0300

    Bug 21915: Call reconcile_balance on manual credit creation

    This patch makes the manual credit creation step call
    Koha::Account::reconcile_balance when the AccountAutoReconcile syspref
    is set.

    To test:
    - Apply the patch
    - Have some outstanding debits
    - Create a manual credit
    => SUCCESS: Same behaviour as always
    - Set AccountAutoReconcile
    - Create a manual credit
    => SUCCESS: Reconcillation happened
    - Sign off :-D

    Sponsored-by: ByWater Solutions
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0693052bfcd0b4259eb620233550f81eab49eabd)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 86342bf68127192e0bc14767ef0f546ebdea4d97
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 30 09:45:19 2018 -0300

    Bug 21915: Call reconcile_balance on manual invoice creation

    This patch makes the manual invoice creation step call
    Koha::Account::reconcile_balance when the AccountAutoReconcile syspref
    is set.

    To test:
    - Apply the patch
    - Have some outstanding credit
    - Create a manual invoice
    => SUCCESS: Same behaviour as always
    - Set AccountAutoReconcile
    - Create a manual invoice
    => SUCCESS: Reconcillation happened
    - Sign off :-D

    Sponsored-by: ByWater Solutions
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0c43fa326afa23ef9c98ae2e7b464f6a0e55d880)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9765cab77792f50195454581adaa597eb86b5688
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Nov 29 16:46:36 2018 -0300

    Bug 21915: Reconcile balance on _FixAccountForLostAndReturned call

    This patch makes _FixAccountForLostAndReturned reconcile the patron's
    account balance, when the AccountAutoReconcile syspref is set.

    To test:
    - Apply this patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Circulation.t
    => SUCCESS: Tests pass, peace \o/
    - Sign off :-D

    Sponsored-by: ByWater Solutions
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 49c9e93292b2f694857edc66e913b9f65d081e8b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2cd12cf6bca9035705774a29d990603383345b8c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Nov 29 14:55:53 2018 -0300

    Bug 21915: Add AccountAutoReconcile syspref

    This syspref will be used to call the reconcile_balance routing as
    needed.

    Sponsored-by: ByWater Solutions
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 6d42f6e72c20bad116454b81ee512024179b7387)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    4 +
 Koha.pm                                            |    2 +-
 installer/data/mysql/sysprefs.sql                  |    1 +
 installer/data/mysql/updatedatabase.pl             |   10 ++
 .../en/modules/admin/preferences/circulation.pref  |    8 ++
 members/mancredit.pl                               |    4 +
 members/maninvoice.pl                              |    5 +
 misc/cronjobs/reconcile_balances.pl                |  122 ++++++++++++++++++++
 t/db_dependent/Circulation.t                       |   80 ++++++++++++-
 9 files changed, 234 insertions(+), 2 deletions(-)
 create mode 100755 misc/cronjobs/reconcile_balances.pl

hooks/post-receive
-- 
main Koha release repository