[koha-commits] main Koha release repository branch master updated. v19.05.00-280-g0f83de1

Thu Jul 4 15:18:18 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  0f83de166938e01ad596257f0a88389d80a47bab (commit)
       via  9bdd6a0990e337eed6b05dd660e589adf4baab5d (commit)
       via  a71fd8357c9e2de751ee845a2a234229ce40a785 (commit)
       via  31e0ec34bae4b7f8598ffce4908e2ccb3b8627e1 (commit)
       via  79917ad0bf269148ec470591a9a44bc015efb74a (commit)
       via  d766b6926bc104bd10050f1f49d4414dc9555475 (commit)
       via  9638caf87234524e447fe5ab028ac4946726e823 (commit)
       via  de1ad9e651ae7cb1c64829ef14ace3b5a6ca4641 (commit)
      from  6a6866afa343e3b53ad77a36552e19404ac7afab (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0f83de166938e01ad596257f0a88389d80a47bab
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 9 11:58:10 2018 -0300

    Bug 21801: (follow-up) Use ->account

    This patch is a minor refactoring, that reuses the $account object we
    already get from $patron, instead of creating new ones all over the
    place. Code gets simpler to read too.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9bdd6a0990e337eed6b05dd660e589adf4baab5d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 9 11:33:59 2018 -0300

    Bug 21801: Make paycollect.pl pass library_id when calling ->pay

    This patch makes paycollect store the branchcode of the current library
    when payments are done.

    - Try all the possible options, specially selecting things to pay for (not
    using the individual buttons).
    - Check on the DB, that the  accountlines for the patron you're playin
    with have the branchcode stored correctly in all cases:
      $ sudo koha-mysql kohadev
      > SELECT * FROM accountlines WHERE borrowernumber=<the_bn>;
    => SUCCESS: Things are as expected
    - SIgn off :-D

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a71fd8357c9e2de751ee845a2a234229ce40a785
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Jul 3 08:18:35 2019 -0400

    Bug 22709: (follow-up) Move new test file into a Plugins subdirectory

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 31e0ec34bae4b7f8598ffce4908e2ccb3b8627e1
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Jul 2 10:07:27 2019 -0300

    Bug 22709: (follow-up) Mock enable_plugins config entry

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 79917ad0bf269148ec470591a9a44bc015efb74a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jun 21 17:10:23 2019 -0300

    Bug 22709: Add after biblio/item action hooks

    This patch introduces after-action hooks for
    - C4::Biblio::{Add|Mod|Del}Biblio
    - C4::Items::{Add|Mod|Del}Biblio

    After the action has taken place, a call to a helper method is done,
    which loops through all plugins implementing the hooks, and calls the
    plugin method. The related object is passed, along with an 'action'
    string specifying the action that took place, and the object id (which
    is specially important for the 'Del' case).

    To test:
    - Apply this patchset
    - Run:
      $ kshell
     k$ prove t/db_dependent/Biblio_and_Items_plugin_hooks.t
    => SUCCESS: Tests pass!
    - Sign off :-D

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d766b6926bc104bd10050f1f49d4414dc9555475
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jun 21 17:09:56 2019 -0300

    Bug 22709: Unit tests

    This patch introduces tests for new plugin hooks added to
    C4::Biblio::{Add|Mod|Del}Biblio and C4::Items::{Add|Mod|Del}Item.

    They are tested together as for creating an item you need to first create
    a biblio and tests looks basically the same.

    The testing strategy is
    - Make sure the plugin is passed the right params
    - Throw an exception at plugin-level, to be trapped by the C4::Biblio
    and C4::Items lib, and converted into a warning. So we test for the
    warning.
    - Also, the fact that C4::Biblio and C4::Items warns, means the
    exception was cought, and then Koha won't break on faulty plugins or
    fatal errors from plugins.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9638caf87234524e447fe5ab028ac4946726e823
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Jul 2 12:29:08 2019 +0000

    Bug 22999: (follow-up) Indentation updates

    The markup changes require indentation updates. This patch contains
    indentation changes only.

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit de1ad9e651ae7cb1c64829ef14ace3b5a6ca4641
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Jun 28 16:27:16 2019 +0000

    Bug 22999: Switch two-column templates to Bootstrap grid: Circulation

    This patch modifies the circulation page template to use the Bootstrap
    grid instead of YUI.

    To test, apply the patch and view the checkout page, confirming that
    it looks correct at various browser widths:

     - Check out (no patron)
     - Check out -> Patron search
       - Results
       - No results
     - Check out -> Patron selected
       - Can check out
         - Checkout blocked (renewal confirmation, item on hold, etc)
       - Can't check out (expired, restricted)

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |   43 +
 C4/Items.pm                                        |   40 +
 .../prog/en/modules/circ/circulation.tt            |  990 ++++++++++----------
 members/paycollect.pl                              |   19 +-
 .../Plugins/Biblio_and_Items_plugin_hooks.t        |   84 ++
 t/lib/Koha/Plugin/Test.pm                          |   30 +
 6 files changed, 697 insertions(+), 509 deletions(-)
 create mode 100755 t/db_dependent/Plugins/Biblio_and_Items_plugin_hooks.t

hooks/post-receive
-- 
main Koha release repository