[koha-commits] main Koha release repository branch master updated. v19.05.00-292-g611b60e

Fri Jul 5 10:06:04 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  611b60ea9657efbe5f6c1da53d4b6a6d2d5f6a01 (commit)
       via  e53bed5375638c8d7baaefb04cd77843dbe8e8a3 (commit)
       via  fa390ca232a0979c6786a0e00eca8d458f644f3e (commit)
       via  9796f5adb39b3cb56bf82837cd57d14e513e8cae (commit)
       via  cc60770c4eed3ab8144acd2382e2894f7b63fb37 (commit)
       via  51bfa2ce28fc2eed7b5d0361fe4585afd96e3e20 (commit)
       via  4f7f55e5fcb8c9b0a608a79228e303de05ff0328 (commit)
       via  ab417c290a06640153f725e361b56bf6c598c386 (commit)
       via  7e559e59635e387ce53a894a67e4323e4984a15f (commit)
       via  c3f0732eb72dfb3c4c6000a8602424772bd46b61 (commit)
       via  e4ee3636304d06a0492fee6a1fcd9e4c65a17be6 (commit)
       via  44469cf4c3e9fa690b2247324b1922fdde207f9f (commit)
      from  0f83de166938e01ad596257f0a88389d80a47bab (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 611b60ea9657efbe5f6c1da53d4b6a6d2d5f6a01
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Tue Jul 2 05:05:20 2019 +0000

    Bug 23199: (follow-up) Fix tab/space issues

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e53bed5375638c8d7baaefb04cd77843dbe8e8a3
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Tue Jul 2 05:01:55 2019 +0000

    Bug 23199: Added tests for Koha::Patron

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fa390ca232a0979c6786a0e00eca8d458f644f3e
Author: Arthur Suzuki <arthur.suzuki at biblibre.com>
Date:   Tue Jun 25 11:17:24 2019 +0200

    Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref

    Test plan:
    1/ set uppercasesurname to 'Do'
    2/ register a new patron using the REST API with lowercase surname
    3/ verify the surname is not saved in uppercase
    4/ apply patch
    5/ repeat 2
    6/ verify the surname now is saved to uppercase

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9796f5adb39b3cb56bf82837cd57d14e513e8cae
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Jul 2 10:58:53 2019 +0000

    Bug 23077: Fix import of cardnumber 0

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit cc60770c4eed3ab8144acd2382e2894f7b63fb37
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jun 7 12:19:28 2019 +0000

    Bug 23077: Don't fill cardnumber with empty string

    To test:
    1 - Apply unit test patch only
    2 - prove the tests, they fail
    3 - Attempt to import the attached sample file
    4 - First patron may be imported, second will give error (or both will error)
    5 - If only one error, import agian, now both have error
    6 - Apply this patch
    7 - Prove tests, they pass!
    8 - Import the sample file
    9 - It succeeds!

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 51bfa2ce28fc2eed7b5d0361fe4585afd96e3e20
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jun 7 12:18:55 2019 +0000

    Bug 23077: Unit tests

    prove -v t/db_dependent/Koha/Patrons/Import.t

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4f7f55e5fcb8c9b0a608a79228e303de05ff0328
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 24 01:22:06 2019 +0000

    Bug 21181: Make cancel_expired_reserves.pl Cancel all holds not waiting if ExpireReservesMaxPickupDelay not set

    To test:
    0 - Make sure ExpireReservesMaxPickupDelay is set to 'Don't allow'
    1 - Place a hold for a patron
    2 - Check in at another library to set it in transit
    3 - Update expirationdate of hold to be in the past
        UPDATE reserves SET expirationdate='1999-12-31'
    4 - Run cancel_expired_holds.pl
    5 - Hold is not canceled
    6 - Apply patch
    7 - Run again
    8 - Hold is cancelled

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ab417c290a06640153f725e361b56bf6c598c386
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 24 01:21:56 2019 +0000

    Bug 21181: Unit tests

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7e559e59635e387ce53a894a67e4323e4984a15f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jul 5 06:07:25 2019 +0000

    Bug 23248: (QA follow-up) Consolidate 404s

    Merging two conditions: biblionumber is empty or biblionumber cannot be
    found. This make the strange int($biblionumber) unneeded.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c3f0732eb72dfb3c4c6000a8602424772bd46b61
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jul 1 15:52:02 2019 -0300

    Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber

    This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it
    should) in the event of a bad biblionumber passed.

    To test:
    - Open your browser on a known record detail page (OPAC)
    - Switch to the ISBD view
    => SUCCESS: It shows
    - Alter the biblionumber on the URL into an obviously non-existent
    biblionumber (e.g. very high value)
    => FAIL: Internal errors are shown
    - Apply this patch
    - Reload the bad biblionumber ISBD view
    => SUCCESS: Browser is redirected to the 404 page as it should
    - Sign off :-=> FAIL: Internal errors are shown
    - Apply this patch
    - Reload the bad biblionumber ISBD view
    => SUCCESS: Browser is redirected to the 404 page as it should
    - Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e4ee3636304d06a0492fee6a1fcd9e4c65a17be6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 19 20:08:04 2019 -0500

    Bug 23083: Fix course reserve item editing if one of the value is set to UNCHANGED

    Test plan:
    0: Do not apply the patches
    1: Create an item with itype, ccode, location, and holding branch set
    2: Create a course
    3: Add item to course, changing the values for itype, ccode, and location
    4: Click Edit for that item on course-details.pl
    5: Assign new values for itype, ccode, and location but leave the holding library dropdown set to LEAVE UNCHANGED
    6: Hit Save
    7: Back on course-details.pl, observe that the item is still showing the values set in step 3
    8: Apply this patch
    9: Repeat 4 to 6
    10: Back on course-details.pl, observe that the item is now showing the correct values
    11: Edit the course reserve again, setting new values for itype, ccode, and location and setting the holding library dropdown to whatever the holding library for the item is currently
    12: hit save
    13: On course-details.pl, see that the change actually happened, the item is now showing the values set in step 9

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 44469cf4c3e9fa690b2247324b1922fdde207f9f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 19 20:12:14 2019 -0500

    Bug 23083: Add tests

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/CourseReserves.pm                            |   11 ++---
 C4/Reserves.pm                                  |    2 +-
 Koha/Patron.pm                                  |    4 ++
 Koha/Patrons/Import.pm                          |    2 +
 members/memberentry.pl                          |    4 --
 opac/opac-ISBDdetail.pl                         |    7 ++-
 t/db_dependent/CourseReserves/CourseItems.t     |   14 +++++-
 t/db_dependent/Koha/Patrons.t                   |   13 +++++-
 t/db_dependent/Koha/Patrons/Import.t            |   55 ++++++++++++++++++++++-
 t/db_dependent/Reserves/CancelExpiredReserves.t |   40 ++++++++++++++++-
 10 files changed, 133 insertions(+), 19 deletions(-)

hooks/post-receive
-- 
main Koha release repository