[koha-commits] main Koha release repository branch master updated. v19.05.00-1255-gff3d7b9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  ff3d7b9f8e27a1c8547012f062daccc33b12dc27 (commit)
      from  aab956af68d0bc72c6268866cc8b5083dc6dee43 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ff3d7b9f8e27a1c8547012f062daccc33b12dc27
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Oct 22 12:42:09 2019 +0200

    Bug 23813: (bug 18925 follow-up) Remove invalid circ rules to avoid FK constraints to fail
    
    There is not FK constraints on the itemtype, categorycode and branchcode
    columns of the issuingrules table, because of the '*' value we use for
    default.
    We created the new table circulation_rules with those constraints, and
    when we moved the rules for maxissueqty, the INSERT failed.
    
    To avoid the FK constraints to fail we are going to delete the invalid
    rows before.
    
    It could lead to data lost, but this situation certainly comes from a
    bad data manipulation at some point of the history of the installation.
    
    Test plan:
    git reset --hard 1e4f442442844cfaf17f5b06f122f6259d5fee92 # before 18.12.00.020
    reset_all
    
    insert into branches(branchcode, branchname) values('rmme', 'rmme');
    insert into categories (categorycode, description) values ('rmme', 'rmme');
    insert into itemtypes (itemtype, description) values('rmme', 'rmme');
    
    Go to http://pro.kohadev.org/cgi-bin/koha/admin/smart-rules.pl
    Create a new rule for the patron category
    Create a new rule for the item type
    Copy all the default rule to the new library
    Create other rules for "Default checkout, hold policy by patron category" and "Default holds policy by item type" using this patron's category and itemtype.
    Same for patrons' categories and itemtypes you will not delete.
    
    delete from branches where branchcode="rmme";
    delete from categories where categorycode="rmme";
    delete from itemtypes where itemtype="rmme";
    
    git checkout master
    and execute the DB process.
    
    => With this patch applied you will not get the error and the rules will
    be moved correctly.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 installer/data/mysql/updatedatabase.pl |   11 +++++++++++
 1 file changed, 11 insertions(+)


hooks/post-receive
-- 
main Koha release repository