[koha-commits] main Koha release repository branch master updated. v19.05.00-1271-gd51aeb7
Git repo owner
gitmaster at git.koha-community.org
Thu Nov 7 14:50:43 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d51aeb7f9b498ba80470655161e654cc385c1062 (commit)
via 119347c76e5acc262380cc22b13684cca5a19e8d (commit)
via b4a6d79e4dbd6de90d453140f696cf8ba75a2159 (commit)
via 6b2d1093155c07e43522b0f926742698598d09ea (commit)
via cd3ef03e76e1441675c90135c42d033bf99f73cd (commit)
via fc04f6535be59350c3b01491bded356ba30470fb (commit)
via 341b8266d70dd887adc646b6d931e251f4d33242 (commit)
via 5f555d865d1cd683c7aec48e6bd51c542a0a4a68 (commit)
via d9cd7ff1fd4fdb65d04a3489a78fddd5f1cc88f7 (commit)
via 8044ac7344c8281837cc35f2dadf07d83d53e641 (commit)
via 0b6fbc138f2ac93cf42ee9c6346bdc67f7268489 (commit)
via ccf9eaf62fc05abe318fe4652025ac3979c50c19 (commit)
via 551097f85049c96119038879dfe368611ca87f30 (commit)
via 9af572c7969f5372853d238ee35f530e4e9fc9f6 (commit)
via 342baeecbb37bc39245c5df5dccfb983f7f84e0f (commit)
via 050f43f73c4857b26996e15e3d8b8ad536b32763 (commit)
from ff3d7b9f8e27a1c8547012f062daccc33b12dc27 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d51aeb7f9b498ba80470655161e654cc385c1062
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Oct 11 09:07:14 2019 -0700
Bug 23806: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button
Test Plan:
1) Enable reciept popups for payments and writeoffs
2) Test the "Write off" button, no popup
3) Apply this patch
4) Restart all the things!
5) Test again, you should get the popup!
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 119347c76e5acc262380cc22b13684cca5a19e8d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Nov 7 13:34:31 2019 +0100
Bug 23427: Simplify sort logic
This is the usual syntax.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b4a6d79e4dbd6de90d453140f696cf8ba75a2159
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Aug 5 15:25:02 2019 +0200
Bug 23427: Better sorting of previous checkouts
In patron circulation or details page, previous checkouts are displayed sorted by due date.
Many checkouts may have same due date so it would be better to sort on timestamp as second sort criteria, like todays's checkouts.
Test plan :
1) Create for a patron two issues with same due date and a few seconds between them
2) Create another issue with a different due date
3) Come back a day later
4) Set preference previousIssuesDefaultSortOrder = "latest to earliest"
5) Go to patron circulation page and check sort order is OK : sorted by "Due date" then "Cheked out on"
6) Go to patron details page and check sort order is OK : sorted by "Due date" then "Cheked out on"
7) Set preference previousIssuesDefaultSortOrder = "earliest to latest"
8) Go to patron circulation page and check sort order is OK : sorted by "Due date" then "Cheked out on"
9) Go to patron details page and check sort order is OK : sorted by "Due date" then "Cheked out on"
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6b2d1093155c07e43522b0f926742698598d09ea
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Aug 5 15:11:49 2019 +0200
Bug 23427: Fix previous checkouts sort order
In patron circulation or details page, previous checkouts are displayed sorted by due date.
Actual sort order is not honoring system preference "previousIssuesDefaultSortOrder". Todays's checkouts is correct thanks to Bug 13908.
Patch adds comments that refer to the text of system preferences "previousIssuesDefaultSortOrder" and "TodayIssuesDefaultSortOrder" :
latest to earliest = asc
earliest to latest = desc
Test plan :
1) Create for a patron two old issues with a few days between them
2) Set preference previousIssuesDefaultSortOrder = "latest to earliest"
3) Go to patron circulation page and check sort order is OK
4) Go to patron details page and check sort order is OK
5) Set preference previousIssuesDefaultSortOrder = "earliest to latest"
6) Go to patron circulation page and check sort order is OK
7) Go to patron details page and check sort order is OK
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cd3ef03e76e1441675c90135c42d033bf99f73cd
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Nov 2 06:54:31 2019 +0000
Bug 21939: Fix permissions for holds history tab
The tab will show when the staff user has edit_borrowers
permission, but the page itself will not be accessible.
This patch fixes the page permissions to allow access
with the edit_borrowers permission as suggested by the
comments on the original bug report.
To test:
- Create a staff user with only "edit_borrowers" permission
from the borrowers module
- Try to access the holds history tab from any patron account
- Verify you are blocked
- Apply patch
- Try again and verify the page is accessible now
- Repeat with superlibrarian and full borrowers permission.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fc04f6535be59350c3b01491bded356ba30470fb
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Nov 7 13:20:08 2019 +0000
Bug 23293: DBRev 19.06.00.050
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 341b8266d70dd887adc646b6d931e251f4d33242
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Nov 6 15:40:57 2019 -0300
Bug 23293: (QA follow-up) Minor fix for tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5f555d865d1cd683c7aec48e6bd51c542a0a4a68
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Sep 25 10:59:03 2019 +0100
Bug 23293: (follow-up) Add tests for C4::Circulation change
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d9cd7ff1fd4fdb65d04a3489a78fddd5f1cc88f7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jul 10 14:50:06 2019 +0100
Bug 23293: Apply OPACFineNoRenewalsIncludeCredit preference
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8044ac7344c8281837cc35f2dadf07d83d53e641
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jul 10 14:34:47 2019 +0100
Bug 23293: Add system preference
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0b6fbc138f2ac93cf42ee9c6346bdc67f7268489
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Nov 2 12:30:58 2019 +0100
Bug 23751: Make staffaccess permission description more precise
The permission description was missing 'username' from the description.
To test:
- Look at the permissions of a patron
- Verify the staffaccess permission is labelled:
Allow staff members to modify permissions and passwords for other staff members
- Apply patch
- Check description again:
Allow staff members to modify permissions, usernames, and passwords for other staff members
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ccf9eaf62fc05abe318fe4652025ac3979c50c19
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Nov 2 01:58:00 2019 +0000
Bug 23952: Fix body tag on OPAC course details page
The id was not changed, when the page was added and
remained opac-main. The patch changes it to
opac-course-details so the page has its own unique id.
To test:
- Add a course reserve to your installation
- Go to the course reserves page in the OPAC
- Click on the course to see its details
- Look at the source code, the <body> tag should show:
Without patch: opac-main
with patch applied: opac-course-details
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 551097f85049c96119038879dfe368611ca87f30
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sun Nov 3 21:41:04 2019 +0000
Bug 23954: Format notes in suggestion management
This patch makes minor CSS and markup changes in order to deliniate
suggestion notes from the other data in the suggestions list view.
To test you should have at least one suggestion with a note. Apply the
patch and go to Acquisitions -> Suggestions.
In the table of suggestions, check that the notes display clearly.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9af572c7969f5372853d238ee35f530e4e9fc9f6
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Oct 8 17:11:17 2019 +0000
Bug 13749: On loading holds in patron account 'processing' is not translatable
This patch updates the DataTables configuration for two tables: The
checkouts and holds lists shown on the checkout and patron details
screen.
The tables lacked the standard application of a custom set of
defaults defined in js/datatables.js. It is in this file that custom
language strings are defined for DataTable interface elements, pulling
in the translated values from datatables.inc.
Without our custom defaults applied, DataTables used its own defaults,
which are not translated.
To test, apply the patch and check out to a patron who has both
checkouts and holds. The more the better to give you more time to
observer the loading state of the tables.
- Checkouts: This table doesn't exhibit any visible problems because
page-specific text is defined for the table's "Loading" message.
However, it still makes sense to apply the defaults to the table for
consistency's sake. There should be no visible changes to the table.
- Holds: From the checkout or patron details page click the "Holds"
tab. While the table loads there should be a "Processing" message. If
you switch to another translation the message should appear in that
language.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 342baeecbb37bc39245c5df5dccfb983f7f84e0f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Nov 7 11:48:59 2019 +0100
Bug 23768: Adjust the test for invalid ISBN
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 050f43f73c4857b26996e15e3d8b8ad536b32763
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Oct 7 17:46:30 2019 +0000
Bug 23768: Return invalid ISBN when searching with variations
To test:
1 - Enable SearchWithISBNVariations and IntranetCatalogSearchPulldown
2 - Refresh page and click on 'Search the catalog' tab
3 - Search for 'ISBN' 0385299209
4 - Note no results
5 - Note the search says if searched 'kw,wrdl: (nb=)'
6 - Apply patch, restart all the things
7 - Repeat search
8 - Search looks correctly formed
9 - Add the isbn above to a record, confirm it is returned by search
10 - Confirm searches for valid ISBNs still work as expected
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 5 +++-
C4/Koha.pm | 2 +-
Koha.pm | 2 +-
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 11 +++++++++
.../intranet-tmpl/prog/en/includes/permissions.inc | 4 ++--
.../prog/en/modules/admin/preferences/opac.pref | 6 +++++
.../prog/en/modules/suggestion/suggestion.tt | 4 ++--
koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 4 ++--
koha-tmpl/intranet-tmpl/prog/js/holds.js | 4 ++--
.../bootstrap/en/modules/opac-course-details.tt | 2 +-
members/holdshistory.pl | 2 +-
members/pay.pl | 2 +-
opac/opac-user.pl | 8 +++++--
svc/checkouts | 10 ++++----
t/Koha.t | 2 +-
t/db_dependent/Circulation.t | 25 ++++++++++++++++++--
17 files changed, 71 insertions(+), 23 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list