[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.04-45-gec5eace
Git repo owner
gitmaster at git.koha-community.org
Fri Nov 8 16:45:01 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.05.x has been updated
via ec5eace6395afbcf19f6fbe97f04b054c76b8d3e (commit)
via 9ba0ec181553b088bb38dd83c1f860b76be05968 (commit)
via 212da97a0b13350372af83349683c4727cf63bba (commit)
via ed4555f5951e0a7e4c7029244ec4b49e7b31dc4c (commit)
via 7a72052b88f25121d53e60ea103a628861469038 (commit)
via f9c41c5a1fd1698713d26551459f7d4dfe28fba4 (commit)
via ae3cc1f417503df130c7195c14d316889b8f99c7 (commit)
via ec8ea0d2c87f1498577bed9e6073a3099d8328f2 (commit)
via 4a2699af59b89dd316ad70b87956b2c78765baaf (commit)
via b3d6acc3de8a90cbb72e7aec5a5cc9c098ce0e0b (commit)
via b117a39f6936da0b67ac258a6677baf90549b20f (commit)
via aa8e233751118de21c9cbdef578b669545a09375 (commit)
via 1008c22224591b654842b3a7ab1f35fdf12ba285 (commit)
from 2f4d2d7e3b78a19cab4a7b8360f1c62e8deff63c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ec5eace6395afbcf19f6fbe97f04b054c76b8d3e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Oct 25 13:12:38 2019 +0100
Bug 23579: (RM follow-up) Fix failing tests
Removing the default on changed_fields leads to the requirement for
tests to specify data to add to said field when mocking data.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 14e5d38773027cd424d7bb3385804d06740097ad)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 9ba0ec181553b088bb38dd83c1f860b76be05968
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 25 10:15:42 2019 +0200
Bug 23579: Remove default value for MEDIUMTEXT borrower_modifications.changed_fields
Installation under Ubuntu 18.04 is blocked:
install.pl: DBD::mysql::st execute failed: BLOB, TEXT, GEOMETRY or JSON
column 'changed_fields' can't have a default value at
/usr/local/share/perl5/DBIx/RunSQL.pm line 273.
https://dev.mysql.com/doc/refman/5.7/en/data-type-defaults.html
"""
The BLOB, TEXT, GEOMETRY, and JSON data types cannot be assigned a
default value.
"""
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 1d64b1b63df406508bdcde6164b179833f712aeb)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 212da97a0b13350372af83349683c4727cf63bba
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Oct 4 14:06:27 2019 +0100
Bug 23551: Fix AddRenewal call in circ/renew.pl
Without the patch, renewing from the renewal tab/page
led to wrong renewal/due dates.
To test:
- Check an item out to your patron account
- Renew it from the patron account
- Note the due date
- Return the item
- Check the item out again
- Renew it using the renewal tab
- Verify a different due date was calculated
- Apply patch
- Repeat test - due dates now should be the same
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit a24c17a2aa2053da1317c29e47a3946af2962afb)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit ed4555f5951e0a7e4c7029244ec4b49e7b31dc4c
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Oct 24 13:50:35 2019 +0100
Bug 23863: Add signoff line for recognition
Signed-off-by: Sarah Cornell <sbcornell at cityofportsmouth.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit e428c5a4b0aea4779f743abbf8a61abe90b20dbc)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 7a72052b88f25121d53e60ea103a628861469038
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Oct 21 22:08:45 2019 +0000
Bug 23863: (QA follow-up) Add missing html filter
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 346f8b163a45a15b522c05ab6da532f922588559)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit f9c41c5a1fd1698713d26551459f7d4dfe28fba4
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Oct 22 14:07:46 2019 -0400
Bug 23863: Editing a basket clears create_items value
Test Plan:
1) Create a basket with a non-default value for aqbasket.create_items
2) Click Edit from basket.pl
3) Click Save without changing anything
4) Note that aqbasket.create_items is no longer set
5) Apply this patch
6) Restart all the things!
7) Repeat steps 1-3
8) Note create_items is unchanged!
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 2f315139e213ca9241d385dfea0aa747999c8464)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit ae3cc1f417503df130c7195c14d316889b8f99c7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 21 17:55:17 2019 +0200
Bug 23855: Fix "Mark selected suggestion as" status
On the suggestions management page (suggestion/suggestion.pl) you can
select suggestions and change their status.
But it only works for "ACCEPTED" or "REJECTED".
Maybe caused by bug 22905.
Test plan:
Select at least one suggestion on the screen and select the "Pending"
status.
=> The status of the selected suggestions must have been updated
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 030eb694a87029e3220e8f930f509556c9e816ea)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit ec8ea0d2c87f1498577bed9e6073a3099d8328f2
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Oct 16 16:21:46 2019 +0100
Bug 23826: Correction for missing "F" -> "OVERDUE" change
When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed
the cases inside the maninvoice template. This patch should correct
that mistake.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 9d33b82fe8ada8aee4e62bed5e147fe15f72e2e0)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 4a2699af59b89dd316ad70b87956b2c78765baaf
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Oct 14 09:56:18 2019 +0100
Bug 23809: Correction to selectall_arrayref call.
This patch adds the missing `{ Slice => {} }` attribute to the database
call introduced in bug 23265 to fix the use of Koha::Objects introduced
originally in bug 12063.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit ea1f6986692d3658bcd7ea72f3c27ee2cdde1727)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit b3d6acc3de8a90cbb72e7aec5a5cc9c098ce0e0b
Author: Nick <nick at bywatersolutions.com>
Date: Mon Oct 7 20:09:04 2019 +0000
Bug 23771: Don't look for patrons if we don't have a userid
While the code requires external auth to test, the change is simple enough I
think a good read would suffice
To test:
1 - You either need Shib or CAS enabled and setup
2 - Add two users with blank.null cardnumbers
3 - Lock those user accounts
Set failedloginattempts to 1
Try a bad login with the userid
Or set via the DB
4 - Try a good login via the external auth
5 - Note it fails
6 - Apply patch
7 - Login now succeeds
Signed-off-by: Mike Somers - Bridgewater State University <msomers at bridgew.edu>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit c9c6dd10167bc4c60cb384651f4dc802944c4228)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit b117a39f6936da0b67ac258a6677baf90549b20f
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Aug 9 13:51:46 2019 +0200
Bug 22997: Unit test
Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit ce8896f17d99cbbc663b8cc59110ce01d8e70afd)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit aa8e233751118de21c9cbdef578b669545a09375
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue May 28 15:48:54 2019 +0200
Bug 22997: Searching gives no results in auth_finder.pl
During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
Search main heading ($a only)
Search main heading
Default operator beeing 'contains'.
Actually with Elasticsearch those search give no results.
Example with heading :
200
$a Casaubon
$b Isaac
$f 1559-1614
Call to Elasticsearch :
"query" : {
"bool" : {
"must" : [
{
"query_string" : {
"query" : "Casaubon*",
"default_field" : "heading-main",
}
},
{
"query_string" : {
"query" : "(Isaac*) AND (1559-1614*)",
"default_field" : "heading"
}
}
]
}
},
"sort" : [
{
"heading__sort.phrase" : "asc"
}
]
}
Patch adds to "query_string" :
analyze_wildcard : true.
Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit a94e863c3ed17c177c9ce5d284616791fd5cd380)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 1008c22224591b654842b3a7ab1f35fdf12ba285
Author: Dobrica Pavlinusic <dpavlin at rot13.org>
Date: Thu Oct 3 09:34:17 2019 +0200
Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack
When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending
headers and html after pdf output to browser.
Using exit inside eval block doesn't stop plack from generating
headers and html page after exit since CGI::Compile will catch
exit but doesn't stop emiting output. Example is:
eval {
warn "in eval";
exit;
};
warn "after eval";
Under CGI, this would print just "in eval", but under plack we get both lines
and thus generate additional header and html after we already sent pdf data.
Signed-off-by: Theodoros Theodoropoulos <theod at lib.auth.gr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 43d999cc7c7edc54e3df7482b3ab3607755e4b6d)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 7 +++++--
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 6 +++++-
acqui/basketheader.pl | 1 +
circ/renew.pl | 6 +++++-
installer/data/mysql/kohastructure.sql | 2 +-
installer/data/mysql/updatedatabase.pl | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketheader.tt | 4 +++-
koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt | 2 +-
members/discharge.pl | 4 +++-
opac/opac-discharge.pl | 4 +++-
suggestion/suggestion.pl | 4 +---
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 3 ++-
t/db_dependent/Letters/TemplateToolkit.t | 2 +-
t/db_dependent/Members.t | 2 +-
14 files changed, 33 insertions(+), 16 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list