[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.04-59-g1ad984a
Git repo owner
gitmaster at git.koha-community.org
Fri Nov 8 17:29:35 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.05.x has been updated
via 1ad984a90ab1bd4d5b7b12714af1539326c667de (commit)
via 5d9b0109c3ca813c3497ee6baa01a9e469121649 (commit)
via 4077a6faa98a8fe269c384eac8c7de31eedfc5ea (commit)
via 79f4870bd9d087316c4859e9f20e3f68f592649e (commit)
via 6e414e69bde6329a17a407605c510ed6c2d171d4 (commit)
via 17e13e525abb393168ff06e9186597a347d0d3c5 (commit)
via 66f1e396ea57c267468bef305682996c4b6b6b66 (commit)
via b5d96249fa0244b82594b2035c2cce4c958b9626 (commit)
via 9bf384ba96beced2721cd15a0a639074ab2c2749 (commit)
via e25e850bf51e840f0e32cf4cd7beed6d298fb16c (commit)
via 95417e25fe36ed1d96b1f4d39bcf5fd66a522368 (commit)
via 8166424b07602d5e32f4a30adf859d3a54e00525 (commit)
via 367f96aa0f418046fe3c5b409df9de7ad82efc1c (commit)
via 0b69f9502d4a936d9f080603330d85df2e76062d (commit)
from ec5eace6395afbcf19f6fbe97f04b054c76b8d3e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 1ad984a90ab1bd4d5b7b12714af1539326c667de
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Oct 31 19:03:59 2019 +0000
Bug 23938: Restore title display in last checked out box
To test:
1 - Check out to a patron
2 - Note the display under the checkotu box does not have title
3 - Apply patch
4 - Checkout another item
5 - Note the title displays
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit dfdf3a74454d3844b6ed82f549d67f25c7001ded)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 5d9b0109c3ca813c3497ee6baa01a9e469121649
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Oct 31 13:19:24 2019 +0000
Bug 23630: (QA follow-up) Fix tests
marc_records_to_documents is now an arrayref of hashes, not an arrayref of arrays
_sanitise_records has been removed, we don't need those tests anymore
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit bc8b8a7a6b08d602bf4e98255461d3b849d78a05)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 4077a6faa98a8fe269c384eac8c7de31eedfc5ea
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Sep 19 16:55:51 2019 +0200
Bug 23630: Do not remove field 999 in Elasticsearch indexing
Elasticsearch indexing uses 999$c to store record id by deleting the all field first !
So you can not store anything in field 999, even in UNIMARC and even in authorities records.
Looks like it is quick fix code added to start Elasticsearch use.
This behavior is disturbing and very strange for UNIMARC flavour.
This patch corrects by defining record ids mandatory in Koha::SearchEngine::Elasticsearch::Indexer::update_index().
This ids array is actually always given (except in UT).
I think it is useless to allow adding a record without its id.
Test plan :
1) Use Elasticsearch as SearchEngine
2) Create a subfield 999$z in default framework
3) Create a record with default framework
4) Enter a random string (never used in catalog) like "tototata" in 999$z
5) In Search engine configuration, define search field "subject" for 999$z
6) Rebuild record : misc/search_tools/rebuild_elasticsearch.pl -b -bn <biblionumber> -v
7) Search for the random string => You get a result
8) Optionnaly look at records in ES : <es server>:9200/<es index name>/data/<biblionumber>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit fb083813a8237691f0b9d419d826fdea58096cd4)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 79f4870bd9d087316c4859e9f20e3f68f592649e
Author: Nick <nick at bywatersolutions.com>
Date: Thu Oct 10 16:40:55 2019 +0000
Bug 23626: (follow-up) Fix JS when not viewing results
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 85b5abcc4e8a0d41c0e286d1b9f7deba4905636c)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 6e414e69bde6329a17a407605c510ed6c2d171d4
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Oct 9 08:28:32 2019 -0400
Bug 23626: Add missing TT failure
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 90e2882568375bce956d0cb50edfa070c42cafce)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 17e13e525abb393168ff06e9186597a347d0d3c5
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Oct 7 12:34:07 2019 -0400
Bug 23626: [alternate] Default to including all rows
If a person is fetching all data, it seems most likely that that person wants
to see all the data in the chart. We should default to that behavior.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit afa1106782d794b98efa90200ac793d7078a2686)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 66f1e396ea57c267468bef305682996c4b6b6b66
Author: Nick <nick at bywatersolutions.com>
Date: Wed Oct 2 09:58:59 2019 +0000
Bug 23626: Only fetch full chart data if requested
This patchset prevents the full return of report data unless explicitly requested by the user for charting purposes
Additionally the user is warned if requesting more than 1000 rows of data
To test:
1 - Create a report that returns over 1000 rows of data
2 - Run the report
3 - Note you have two buttons now 'Chart data' and 'Fetch all data for chart'
4 - Click chart data
5 - Note the note that you are only charting visible data
6 - Create the chart and confirm it works
7 - Close the chart
8 - Click 'Fetch all data'
9 - Note the confirm window
10 - Click 'cancel', note there is no change
11 - Repeat and click ok
12 - Fetch all data button is gone
13 - Page to next data, note fetch all does not return
14 - Click 'Chart data'
15 - Note you now have checkbox option to use all data in report
16 - Click it
17 - Create chart
18 - Confirm it works as expected
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 83a545d8318560eb2ee385289ff8c291f07f6716)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit b5d96249fa0244b82594b2035c2cce4c958b9626
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Oct 22 12:29:40 2019 +0000
Bug 23867: Resolve "truncated incorrect double" for empty string
Updatedatabase, rev. 18.12.00.051
Solved by testing the value of the pref first.
Tested by copying the change in a new atomic update with XXX.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 6d1b3cf2120fbd2c9beb4317797c260d9b647f79)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 9bf384ba96beced2721cd15a0a639074ab2c2749
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Oct 11 10:57:30 2019 +0100
Bug 17140: DBRev 19.05.04.001
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 9d9bb45865c9d6c88952f47f52f0e92ddcce0054)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit e25e850bf51e840f0e32cf4cd7beed6d298fb16c
Author: Nick <nick at bywatersolutions.com>
Date: Fri Oct 4 08:15:43 2019 +0000
Bug 17140: Atomic update file
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit bc6e5902898fc3fbaa69b0fcc99359eadd6a8c76)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 95417e25fe36ed1d96b1f4d39bcf5fd66a522368
Author: Nick <nick at bywatersolutions.com>
Date: Thu Oct 3 11:06:47 2019 +0000
Bug 17140: Make rounding syspref controlled
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit ae075fded2a4ef8fb2f241e4cf9bb90d7587b02c)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 8166424b07602d5e32f4a30adf859d3a54e00525
Author: Blou <philippe.blouin at inlibro.com>
Date: Fri Dec 21 10:33:29 2018 -0500
Bug 17140: fix rounding errors when paying fines
Whenever a fine (accountlines in DB) has a precision longer than two floating points, it becomes very hard for a user to clear it.
Ex: 1.035 will be displayed as 1.04 or 1.03 depending on the screen. But entering any of those value in Pay Fine will not clear it.
The user has no way to know the exact value to enter.
This fix makes sure that the intent of the user is met, by matching the EXACT needed sum when the difference is less than 0.01.
TEST
1) Create a 1.035 fine
- Go to a Patron screen
- Fines tab on the left
- Create manual invoice
2) go to Pay fines, click Pay amount on bottom left.
3) It will show 1.03 as Total, and as Collect from patron. Click confirm.
4) An error message will appear.
5) Apply patch, do again.
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit c2df905bfef771415d47aeba7db6ea445a33f1e1)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 367f96aa0f418046fe3c5b409df9de7ad82efc1c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Oct 20 10:16:51 2019 +0200
Bug 18743: Correct number of pending suggestions (acq home page)
This patch could be moved to its own bug report if we want to adjust
tests.
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 4274a2f51dcf0e7ee0dfebc805036ddbc7f3e4fa)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 0b69f9502d4a936d9f080603330d85df2e76062d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 16 16:43:46 2019 +0200
Bug 18743: Fix suggestion listing when organized by library
There are some weird behaviors happening when using the "Organize by:
library" dropdown along with the library filter (in the "Acquisition
information" box).
I am suggesting the following test plan:
0. Create several suggestion from different libraries
A. You are superlibrarian and IndependentBranches is not set (=No)
1. Hit /suggestion/suggestion.pl
=> Default view shows the suggestions from your library
2. Filter by another library
=> You see the suggestions from this library
3. Filter by "Any" libraries
=> You see all the suggestions
4. "Organize by library"
=> You see all the suggestions, organized by library
5. Filter by a specific library
=> You see the suggestion from your library, all in one tab
B. You are not superlibrarian and IndependentBranches is not set (=No)
Same as A.
C. You are superlibrarian and IndependentBranches is set
Same as A.
D. You are not superlibrarian and IndependentBranches is set
You will never see suggestions coming from outside your library
QA: To be clear: the whole script needs a rewrite, but here we are just
trying to fix weird behaviors.
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 9f16ab9e758aeb1a9e64bde03c6c8dcfb7f6e094)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Suggestions.pm | 26 +++---
Koha.pm | 2 +-
Koha/SearchEngine/Elasticsearch.pm | 5 +-
Koha/SearchEngine/Elasticsearch/Indexer.pm | 39 +--------
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 16 +++-
koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc | 14 +++-
.../prog/en/includes/reports-toolbar.inc | 8 +-
.../en/modules/admin/preferences/circulation.pref | 6 ++
.../prog/en/modules/circ/circulation.tt | 2 +-
.../en/modules/reports/guided_reports_start.tt | 27 +++++--
members/pay.pl | 1 +
members/paycollect.pl | 1 +
reports/guided_reports.pl | 13 +--
suggestion/suggestion.pl | 14 +++-
t/Koha/SearchEngine/Elasticsearch.t | 84 ++++++++++----------
t/Koha/SearchEngine/Elasticsearch/Indexer.t | 78 ------------------
.../Koha/SearchEngine/Elasticsearch/Indexer.t | 2 +-
18 files changed, 145 insertions(+), 194 deletions(-)
delete mode 100644 t/Koha/SearchEngine/Elasticsearch/Indexer.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list