[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.04-8-g267d0a9

Tue Oct 8 09:27:19 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  267d0a90333006004f527fbc535556e04f6786de (commit)
       via  4d8dece7ff91d619f71b1edfd8803300ed9a06bf (commit)
       via  acf3eb5217d32753b8f59f626d976707d0d6a90a (commit)
       via  8e6313eaf7cd9b91ecfb8ed3c56c18fa9d488561 (commit)
       via  d8a1871dd0a08b86931c80ad717b4d5e55577c3f (commit)
       via  0dab9b927e149792bfd3f280e12426a328bedf24 (commit)
      from  9fe6c016ab23265bcfed6684135e4040179094fd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 267d0a90333006004f527fbc535556e04f6786de
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Sep 17 15:41:12 2019 -0400

    Bug 23625: Make new 'required' attributes match the currently used syntax in other templates

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 0aeb5998481a28fb72c8f184bd3f85f7491dc858)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 4d8dece7ff91d619f71b1edfd8803300ed9a06bf
Author: Eric Phetteplace <phette23 at gmail.com>
Date:   Mon Sep 16 12:53:32 2019 -0700

    Bug 23625: ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required

    Test plan:

    1. Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes )
    2. Set one or more fields to require in the ArticleRequestsMandatoryFields, ArticleRequestsMandatoryFieldsItemOnly, and/or ArticleRequestsMandatoryFieldsRecordOnly settings (all these settings are affected in the same manner)
    3. Search for a title and select the "Request Article" button from the OPAC search results
    4. Authenticate as a patron
    5. Neglect to fill out at least one of the mandatory fields
    6. Select the "Place Request" button at the bottom of the form
    7. The form submits despite the empty mandatory fields
    8. Apply patch
    9. Repeat steps 3, 5, & 6
    10 . The form should refuse to submit, show a browser-native message about the missing required fields.

    Sponsored-by: California College of the Arts
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 64148cf4ac6f20787a809b36243672430faa6e8f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit acf3eb5217d32753b8f59f626d976707d0d6a90a
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Sep 6 11:13:27 2019 +0000

    Bug 22602: Fix OverDrive circulation when coming from another site

    On bug 21078 we caught an error and returned, this makes us skip some variable setting that we need.

    This patch moves that code into its own function.

    To test:
    0 - Have OverDrive circulation setup and working
    1 - Place a link to your kohadev installation on another site
    2 - Follow that link to the opac
    3 - Note all items show as 'Place hold' even if available copies
    4 - Apply patch
    5 - Repeat 1&2
    6 - Note the items availability shows correctly

    Signed-off-by: Elizabeth Quinn <EQuinn at chplnj.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 4b642386d8983a12c1a79924ae1fac180b10c3d0)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 8e6313eaf7cd9b91ecfb8ed3c56c18fa9d488561
Author: Nick <nick at bywatersolutions.com>
Date:   Fri Sep 20 16:44:53 2019 +0000

    Bug 23651: Add address of restricted page to syspref description

    To test:
    1 - Look at the restricted page syspref
    2 - Check that the url is listed
    3 - Add some content to the page
    4 - Save the prefs
    5 - Verify the address listed takes you to the page on the opac

    Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit fa97bc90df532720287eaf296c15f7facdaa730d)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit d8a1871dd0a08b86931c80ad717b4d5e55577c3f
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed May 31 16:54:32 2017 +0200

    Bug 18710: Wrong subfield modified in batch item modification

    In Tools > Batch item modification, one can modify or delete a subfield.
    When deleting a subfield et modifying another, the wrong subfield gets modified.

    This is caused by the fact that disabled inputs are not posted in form.
    So for a subfield to delete :
    Input name=field_value is not posted. But input name=subfield is posted with subfield code.
    So these 2 arrays does not have the same size :
        my @subfields = $input->multi_param('subfield');
        my @values    = $input->multi_param('field_value');

    For exemple, deleting $2, not changing $u and modidying $v will modify $u with value for $v o_O

    This patch correts but setting disabled all inputs of a deleted subfield : field_value, tag, subfield and mandatory. Like it was not present in the form.

    Test plan :
    - Go to Tools > Batch item modification
    - Enter a barcode and submit
    - Lets say there are subfields : $2 (not mandatory), $u and $v
    - Check the subfield $2 to be deleted
    => $2 input is disabled
    - Enter a text in $v
    - Submit the form
    => Without patch, the text for $v gets into $u
    => With patch, the text for $v gets into $v
    - Check the subfield $2 is well deleted

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit adb232c8f0f4bf8574ca3dce9548196430c57fb0)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 0dab9b927e149792bfd3f280e12426a328bedf24
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Sep 16 17:22:17 2019 -0300

    Bug 23627: Reduce Koha::Biblio->get_coins noise if no 245

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 8766689d34c63416f38a8248367483c573c5036e)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Biblio.pm                                     |    2 +-
 .../prog/en/modules/admin/preferences/opac.pref    |    2 +-
 .../prog/en/modules/tools/batchMod-edit.tt         |    6 ++---
 .../bootstrap/en/modules/opac-request-article.tt   |   23 +++++++++++++-------
 koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js      |   17 +++++++++------
 5 files changed, 30 insertions(+), 20 deletions(-)

hooks/post-receive
-- 
main Koha release repository