[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.04-23-gf8ab33c

Tue Oct 8 10:54:09 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  f8ab33c2fa888683f34443f99a8d7b1d0147d1cf (commit)
       via  b01568040c1f137b5c27b1416cb8407458b9d4d2 (commit)
       via  0c9c78341b5f0c855fcf2a697edc31eb6e1262fc (commit)
       via  19b44c8b44b1c0b92afb3f34b4b6fd41ab1faf5d (commit)
       via  43f15f13123c705bb750af43a74997e581b48719 (commit)
       via  d851b3019b7504beb7c0e9fcb55694f475ba5e56 (commit)
       via  1b22ae96e86ac8da55a98ae1551bb9f955a9502f (commit)
       via  34f49c908c430ff63d1419cab9f1f5dcfd7d6055 (commit)
       via  528aa88b7e7978b25331258f4f69274a3c21945f (commit)
       via  b332b365edbab4197580ecd4b3fe684dadfe070f (commit)
       via  654c13e7d9aa911fb42d40d2a1c34a6d554967fa (commit)
       via  be8bade672b279da24f15154c88a5c5faf840b19 (commit)
       via  278cffa3f1c8f86b59537b12d3d9feac72bd554e (commit)
       via  13e47de787894c0ebd0c50cc9b65a1646f22c412 (commit)
       via  4c681e4e913a62f9efc72e145a327d2ee5b77711 (commit)
      from  267d0a90333006004f527fbc535556e04f6786de (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f8ab33c2fa888683f34443f99a8d7b1d0147d1cf
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Sep 30 14:59:20 2019 +0200

    Bug 23689: (follow-up) Use Library limitations to match other occurrences

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 7e35c3d14b63a49ea16d248b2d4260555e8fcb3f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit b01568040c1f137b5c27b1416cb8407458b9d4d2
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Sep 27 14:41:51 2019 +0100

    Bug 23689: Fix terminology for branches limitations on authorized values

    This patch corrects the terminology and also updates the tooltip to use
    the current bootstrap tooltip library.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 47c2e215875127b843c9720976f2c94e1cd66662)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 0c9c78341b5f0c855fcf2a697edc31eb6e1262fc
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Sep 27 07:23:28 2019 -0400

    Bug 23688: System preference uppercasesurnames broken by typo

    In the process of moving this feature from memberentry.pl to Patron.pm, the 's' on uppercasesurnames was dropped, breaking the feature.

    Test Plan:
    1) Test uppercasesurnames, note it does not work
    2) Apply this patch
    3) Test uppercasesurnames, note it works now!

    Signed-off-by: Kyle Hall <kyle at bywatersolutions.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 62ad053894c57ae990a9724cf58beaa4441448c6)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 19b44c8b44b1c0b92afb3f34b4b6fd41ab1faf5d
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Sep 26 09:08:40 2019 +0200

    Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t

    I've choosen to add it to db_dependent because we may add other tests
    to cover transferbook() cases that will change DB

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d096eeab8a7d23cf460b1ad5f10df746f3d62dda)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 43f15f13123c705bb750af43a74997e581b48719
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Sep 26 09:09:15 2019 +0200

    Bug 23679: fix software error when trying to transfer an unknown barcode

    When trying to transfer an unknown barcode in
    /cgi-bin/koha/circ/branchtransfers.pl you get the error :

    Can't call method "itemnumber" on an undefined value at
    /home/koha/src/C4/Circulation.pm line 319.

    This comes from C4::Circulation::transferbook which should stop when
    finding unknown barcode.

    Test plan :
    1) Go to /cgi-bin/koha/circ/branchtransfers.pl
    2) Enter a barcode not existing in database
    3) Without patch you get a software error, with patch you get a message
       saying 'No Item with barcode'
    4) Enter a barcode existing in database and check transfer is OK

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 3848a3a772e2202ac3339bd241adcef987e48361)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit d851b3019b7504beb7c0e9fcb55694f475ba5e56
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu May 2 16:26:55 2019 +0000

    Bug 22804: OPAC Overdrive JavaScript contains untranslatable strings

    This patch moves untranslatable strings out of overdrive.js and into
    opac-bottom.inc where other strings are defined for use in JavaScript
    files.

    To test you must have OverDrive integration set up, including
    OverDriveCirculation. Test the various Overdrive integration features:

     - Placing holds
     - Cancelling holds
     - Checking out
     - Checking in

    These features should work as expected.

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 740d0bde7860c1d67f1612d5fd3c4a68d0714ef0)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 1b22ae96e86ac8da55a98ae1551bb9f955a9502f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Sep 30 15:52:02 2019 +0100

    Bug 23624: (RM follow-up) Sponsorship Line

    Sponsored-by: Higher Education Libraries of Massachusetts
    Sponsored-by: Fenway Libraries Online
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit ace678ba6f19821bbdaaa9b31c96db2c2ce5e026)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 34f49c908c430ff63d1419cab9f1f5dcfd7d6055
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Sep 25 10:44:03 2019 -0300

    Bug 23624: (QA follow-up) Test error cases

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 6c90c6f7d9e0f04ce148b723fc3a4828f03e9079)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 528aa88b7e7978b25331258f4f69274a3c21945f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Sep 20 07:14:34 2019 -0400

    Bug 23624: (QA follow-up) Don't fetch the count unless the query was successful

    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit f2b27975679e64722f06b175e759801227a313fc)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit b332b365edbab4197580ecd4b3fe684dadfe070f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Sep 19 11:13:28 2019 -0300

    Bug 23624: (QA follow-up) Optimize even more

    This patch makes counting the results have no memory footprint by
    leveraging on the DB to count the rows.

    To test:
    - Without this path, run:
      $ kshell
     k$ prove t/db_dependent/Reports/Guided.t
    => SUCCESS: Tests pass
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Reports/Guided.t
    => SUCCESS: Tests still pass!

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit bca4453c50d8b5b1d3c7029ded2b522a9a2bf868)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 654c13e7d9aa911fb42d40d2a1c34a6d554967fa
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Sep 19 10:50:46 2019 -0300

    Bug 23624: Unit tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 7958e7f3f9b4275cd8da0ed2e04dfbc90d863a60)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit be8bade672b279da24f15154c88a5c5faf840b19
Author: Paul Hoffman <paul at flo.org>
Date:   Tue Sep 17 13:00:03 2019 -0400

    Bug 23624: Count rows in report without (potentially) consuming all memory

    C4::Reports::Guided::nb_rows (called by get_prepped_report in reports/guided_reports.pl) uses DBI::fetchall_arrayref to retrieve all rows at once; counts them; and then discards the rows and returns the count.  This has the potential, if the number of rows is very large, to exhaust all available memory.

    (Other code in guided_reports.pl has the same potential effect, but because the solution to that is much less straightforward it will be addressed in a separate bug report.)

    This patch uses the second ($max_rows) parameter to DBI::fetchall_arrayref to retrieve a smaller number (1,000) of rows at a time, looping until all results have been retrieved.  This will only use as much memory as the maximum amount used by a single call to DBI::fetchall_arrayref.

    Test Plan:
    1) Create a report the will generate a huge number of results
    2) Run the report, watch your memory usage spike
    3) Apply this patch
    4) Restart all the things!
    5) Run the report again, note your memory usage is much lower

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 79e15278f718768fa082b7b3d7b48e6adde164da)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 278cffa3f1c8f86b59537b12d3d9feac72bd554e
Author: caroline <caroline at inlibro.com>
Date:   Tue Sep 17 17:59:21 2019 -0400

    Bug 23631: fr-CA translation of NEW_SUGGESTION notice

    This patch provides the fr-CA translation for the NEW_SUGGESTION notice.

    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 4ca44685bb56c6e172ec5d9ad3dd769fe2eabfa2)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 13e47de787894c0ebd0c50cc9b65a1646f22c412
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Sun Sep 22 02:01:23 2019 +0000

    Bug 23683: Course reserves public notes on specific items should allow for HTML

    Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d8187991a40f58ab815fd1e75d6a3671ca72a668)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 4c681e4e913a62f9efc72e145a327d2ee5b77711
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Sep 13 11:26:03 2019 -0300

    Bug 23607: Make /patrons/:patron_id/account staff only

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 8171c9d05dc3adf0014a727e304f666606f7f751)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    1 +
 C4/Reports/Guided.pm                               |   22 +++++++--
 Koha/Patron.pm                                     |    2 +-
 api/v1/swagger/paths/patrons_account.json          |    2 -
 .../mysql/fr-CA/obligatoire/sample_notices.sql     |   30 ++++++-------
 .../prog/en/modules/admin/authorised_values.tt     |   17 ++++---
 .../en/modules/course_reserves/course-details.tt   |    2 +-
 .../bootstrap/en/includes/opac-bottom.inc          |   11 ++++-
 .../bootstrap/en/modules/opac-course-details.tt    |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js      |   47 +++++++++++---------
 .../Database.t => Circulation/transferbook.t}      |   19 ++++++--
 t/db_dependent/Koha/Patrons.t                      |    6 +--
 t/db_dependent/Reports/Guided.t                    |   36 ++++++++++++++-
 t/db_dependent/api/v1/patrons_accounts.t           |    4 +-
 14 files changed, 139 insertions(+), 62 deletions(-)
 copy t/db_dependent/{Koha/Database.t => Circulation/transferbook.t} (63%)

hooks/post-receive
-- 
main Koha release repository