[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-40-g5bf9a83495

Thu Apr 2 00:50:37 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  5bf9a83495971a196224f9342394a5b2d065d3e1 (commit)
       via  1fbd4468642aa09b999b3baf014b6f3a0afd6df8 (commit)
       via  d09da7444c90ec4d80757a7d2c72be643d1a9f70 (commit)
       via  74e3ef126c5992ac049a35c75a7d3879669d7a49 (commit)
       via  a3143506b2edf7ffca185e650c18b89dc249423f (commit)
      from  5d22e0b3a331e35b8f1e494bc366c1624c982cf8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5bf9a83495971a196224f9342394a5b2d065d3e1
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu May 23 07:55:15 2019 +0200

    Bug 22969: fix biblionumber on 001 in UNIMARC XSLT

    In UNIMARC default configuration the 001 is linked to biblio.biblionumber.
    In some XSLT files, 090$a is used.
    This is by default biblioitems.biblionumber so it usually works but it may not be the same and var biblionumber is used to create hyperlinks to record detail page.

    Test plan :
    1) Use UNIMARC database
    2) Set default in all XSLT system preferences
    3) At OPAC, perform a search and click on a result
    4) Check displayed page shows the correct biblio record
    5) Same at intranet

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Tested on clean UNIMARC install.
    Before insert new records: "alter table biblioitems AUTO_INCREMENT = 5"
    Added two records, with result:
    +--------------+------------------+
    | biblionumber | biblioitemnumber |
    +--------------+------------------+
    |            1 |                5 |
    |            2 |                6 |
    +--------------+------------------+
    Without patch, OPAC results shows for first record
      http://opac/cgi-bin/koha/opac-detail.pl?biblionumber=5, Wrong!
    with patch result is correct

    Works, no errors

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 1fbd4468642aa09b999b3baf014b6f3a0afd6df8
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Mar 4 18:29:24 2020 +0000

    Bug 24798: smart-rules.tt has erroneous comments

    This patch corrects a couple of invalid Template Toolkit comments in the
    Circulation and Fines rules template.

    To test, apply the patch and log into the staff client as an
    administrator.

    On the Circulation and Fines Rules page "View source" and look for
    instances of the text "[#% Default branch %#]" There should be none.

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    [EDIT] There is a theoretical difference between [% # and [%#. The latter
    marks the whole directive as a comment and not just until EOL.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit d09da7444c90ec4d80757a7d2c72be643d1a9f70
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Mar 4 19:47:26 2020 +0000

    Bug 24803: Remove JS error when clicking "Log in to your account"

    This patch removes the "data-toggle" attribute from the login link in
    order to avoid a JavaScript error. Since we have a custom click handler
    to trigger the modal we don't need Bootstrap's "automatic" modal
    handling.

    Test plan:
    1. Apply patch
    2. Open F12 dev tools
    3. Click "Log in to your account" on OPAC
    4. Observe no Javascript errors in console

    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 74e3ef126c5992ac049a35c75a7d3879669d7a49
Author: David Cook <dcook at prosentient.com.au>
Date:   Thu Feb 27 00:28:48 2020 +0000

    Bug 24719: Remove use of CGI object in C4::Context::set_remote_address()

    This patch replaces the CGI "http" object method with its equivalent
    class method, which doesn't require object instantiation and thus skips
    global initialization and premature handling of the incoming HTTP request.

    Test plan:
    0. Disable Plack if it is enabled
    1. Set koha_trusted_proxies in koha-conf.xml to 1.1.1.1
    2. Clear Memcached
    3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl
    4. Note that form below "Upload progress" never appears and errors show
    in browser console
    5. Apply the patch
    6. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl
    7. Note that form appears below "Upload progress"

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit a3143506b2edf7ffca185e650c18b89dc249423f
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Jan 31 11:13:47 2020 +0100

    Bug 24552: Be compatible with Search::Elasticsearch 6.00

    There is no need to specify the `client` param here because
    '5_0::Direct' is the default value for Search::Elasticsearch 5.x and it
    breaks when Search::Elasticsearch 6.x is installed

    Test plan:
    1. Apply the patch
    2. Make sure you have Search::Elasticsearch 5.x
    3. Reload starman
    4. Verify that search works
    5. Install Search::Elasticsearch 6.x
    6. Reload starman
    7. Verify that search works

    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Context.pm                                                       | 3 +--
 Koha/SearchEngine/Elasticsearch.pm                                  | 1 -
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt        | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc              | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl    | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl   | 6 ++----
 7 files changed, 8 insertions(+), 12 deletions(-)

hooks/post-receive
-- 
main Koha release repository