[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-42-g30f12f7dec

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  30f12f7dece8e2f214781df824f45e83b5243c67 (commit)
       via  c405b03dd367adb7c1c274477865a7444f59c9e9 (commit)
      from  5bf9a83495971a196224f9342394a5b2d065d3e1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 30f12f7dece8e2f214781df824f45e83b5243c67
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Mar 4 12:08:29 2020 -0500

    Bug 24802: Updating holds can cause suspensions to apply to wrong hold
    
    On request.pl, the table of holds shows a suspend_until date picker for each hold, *unless* that hold is waiting or in transit. The script reserve/modrequest.pl assumes that there will be a suspend_until input for each hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of them are waiting or in transit. If you were to then set the suspend until date on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions would apply to the 10 found holds and not the holds they should apply to!
    
    Test Plan:
    1) Place two holds on a record
    2) Check in an item and trap it for the first hold
    3) Now that one hold is waiting and the other is not, attempt to set
       a suspension date using the "Update hold(s)" button
    4) Note your hold does not get suspended!
    5) Apply this patch
    6) Restart all the things!
    7) Repeat steps 1-3
    8) Your hold should now be suspended!
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit c405b03dd367adb7c1c274477865a7444f59c9e9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 5 16:27:15 2020 +0100

    Bug 24813: Prevent api/v1/holds.t to fail randomly
    
    Hold cannot be suspended if found=W:
    Koha::Hold->suspend_hold
     90     if ( $self->is_found ) {    # We can't suspend found holds
    
    So when TestBuilder generate a hold with found=W the test fail.
    
    A question however:
    Why did not we have the correct exception displayed somewhere? That
    would be much more helpful to find the problem!
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 4 ++--
 reserve/modrequest.pl                                    | 4 ++--
 t/db_dependent/api/v1/holds.t                            | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository