[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-120-gb17c16f910
Git repo owner
gitmaster at git.koha-community.org
Fri Apr 3 23:46:34 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via b17c16f9106eb159a1690da80a2a46b1f3a165ab (commit)
via 44d91396128a38a29b21f643f2e6439383a03e5c (commit)
via cda91af335a163b9e1d12c2aac57ec46b24ddea4 (commit)
via abb8865d75df361de6cbbd812613d4761f837771 (commit)
via 1f1ab3842371858ff5e76a721216a686684fd99d (commit)
via 78f10451101b38bb160bb50941f377f5c41ea49e (commit)
via 32e0e6dafd484f8f92239b1eaf8bc837681189dc (commit)
from 59953212052ad480cb76de8946175b3602f7942f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b17c16f9106eb159a1690da80a2a46b1f3a165ab
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Feb 20 01:36:32 2020 +0000
Bug 24688: Check the priority of the fulfilled hold when fixing priorities
Currently when fixing priorities of existing holds, priorities aren't
fixed when checking out a middle priority hold because the hold has been
fulfilled and deleted. This patch adds a check for, if the hold can't be
found, an old hold with the required reserve_id.
To test:
1. Place at least four holds on a biblio for different borrowers
2. Check out an item to the 3rd priority borrower
3. Check the existing holds table for the biblio. The priorities might be
out of order, or try clicking the dropdowns and there might be an empty
dropdown option, or open the browser developer tools and notice the option
values in the select are missing value=3.
4. Apply patch and restart memcached
5. Check out an item to the 2nd priority borrower
6. Check the existing holds table for the biblio. Confirm the priorities
have been fixed and are now consecutive with no gaps.
Sponsored-by: Chartered Accountants Australia and New Zealand
Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 44d91396128a38a29b21f643f2e6439383a03e5c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Mar 18 13:54:52 2020 +0000
Bug 24892: Resolve uninitialized warns from opac-memberentry
Especially line 500 (current master).
Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.
Simple fix, not completely trivial due to adding xor ;)
Test plan:
Do not apply, update from opac memberentry. Check warns in log.
Apply patch, update again. Less warns?
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit cda91af335a163b9e1d12c2aac57ec46b24ddea4
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Mar 13 17:40:38 2020 +0000
Bug 24848: Improve manual links for the label creator
Some of the manual links in the label creator tool were
not working correctly or pointing to the wrong pages.
A problem is the label-manage.pl file. This can show
different data depending on an added parameter. Example:
/cgi-bin/koha/labels/label-manage.pl?label_element=template
But it appears that parameters will be ignored when creating
links to the manual. So this patch links to the beginning
of the label creator section in the manual for now.
To test:
- Go to the lable creator
- Try the various pages of the tool
- Note: All 'New ...' links should point to the
correct section in the manual (batches, templates, ...)
Except: Barcode range. This feature is new and not
yet documented in the manual. Link goes to label creator section.
- Note: All 'Manage ...' links should point to the
beginning of the 'label creator' section in the manual
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit abb8865d75df361de6cbbd812613d4761f837771
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Feb 25 14:42:29 2020 +0000
Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron
The drop_hold routine was using the wrong parameter for item info in the patron's
array of holds. We store it as 'barcode' not 'item_id'. This is true for both waiting and unavailable
holds
To test:
1 - Apply unit tests patch
2 - prove -v t/db_dependent/SIP/ILS.t
3 - It fails
4 - Apply second patch
5 - prove -v t/db_dependent/SIP/ILS.t
6 - It passes!
You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling a hold
and check the messages, test coverage is improved by this patch and should be sufficient
for testing
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 1f1ab3842371858ff5e76a721216a686684fd99d
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Feb 25 14:42:17 2020 +0000
Bug 24553: Unit tests
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 78f10451101b38bb160bb50941f377f5c41ea49e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 16 15:43:49 2020 +0100
Bug 22025: Remove warnings when importing patrons
The following warning is raised when importing patrons
Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018
if one of the following headers is passed but does not have a value:
* privacy
* privacy_guarantor_fines
* privacy_guarantor_checkouts
* anonymized
Test plan:
- Do not apply the patch
- Generated a csv file with at least one those headers
- Import it using the import_patrons.pl script (or using the GUI)
- Notice the warnings without the patch
- Apply the patch
- Confirm that the warnings do not longer appear
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 32e0e6dafd484f8f92239b1eaf8bc837681189dc
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 16 15:43:38 2020 +0100
Bug 22025: Add a regression test
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Reserves.pm | 4 +++
C4/SIP/ILS/Patron.pm | 2 +-
Koha/Manual.pm | 16 ++++-----
Koha/Patrons/Import.pm | 9 +++++
opac/opac-memberentry.pl | 3 +-
t/db_dependent/Koha/Patrons/Import.t | 7 ++--
t/db_dependent/SIP/ILS.t | 69 +++++++++++++++++++++++++++++++++++-
7 files changed, 96 insertions(+), 14 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list