[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-125-gcd78e5cb18

Fri Apr 3 23:58:01 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  cd78e5cb18a27d7ded9ef1c03f36fdc2bb97a417 (commit)
       via  6cb9b3634dcc06bdd69b82960a257f38fd75e0d0 (commit)
       via  ca2ebddb1386665a3332ac67f7b5ce971a828c90 (commit)
       via  b713241845e8f730b46c756fa65c4ddd17ed746b (commit)
       via  554391e56a4bf774283653f98fc24608cd9186e2 (commit)
      from  b17c16f9106eb159a1690da80a2a46b1f3a165ab (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cd78e5cb18a27d7ded9ef1c03f36fdc2bb97a417
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Mar 22 12:10:43 2020 +0100

    Bug 24876: Fix capitalization on patron search for holds

    When placing a hold in the staff interface, the heading on the
    search box reads: Search Patrons or clubs
    The patch changes it to be Search patrons...  instead.
    Also changes club id to club ID.

    To test:
    - Place a hold in the staff interface
    - Verify the capitalization error
    - Switch tabs to Clubs, see: club id
    - Apply patch
    - Verify it's all good now

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 6cb9b3634dcc06bdd69b82960a257f38fd75e0d0
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue Mar 10 15:11:07 2020 +0000

    Bug 21708: Sort MARC fields in TransformHtmlToMarc

    Instead of pushing 999 in the front :)

    Test plan:
    Do not yet apply this patch.
    Edit a record. Save. And open MARC view/view plain on opac-detail.
    Verify that the biblionumber field (MARC21 999) follows leader.
    Apply this patch. Restart Plack.
    Edit a record. Save. And open MARC view/view plain on opac-detail.
    Verify that the biblionumber field is in right position.
    Run t/db_dependent/Biblio/TransformHtmlToMarc.t. Should pass now.

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit ca2ebddb1386665a3332ac67f7b5ce971a828c90
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Mar 11 13:22:31 2020 +0000

    Bug 21708: Add a few tests in TransformHtmlToMarc.t

    Test plan:
    Run t/db_dependent/Biblio/TransformHtmlToMarc.t without the module change
    patch. Verify that the test fails on the order of fields.
    Go to test plan of the second patch.

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit b713241845e8f730b46c756fa65c4ddd17ed746b
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Fri Jan 3 21:18:27 2020 +0000

    Bug 24324: Resolve error with delete_records_via_leader.pl

    To test:

    Have a record with the 000 position 5 set to "deleted" (record status)
    Use koha-shell to run the job with the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -i -v
    * items and the record should be deleted
    Mark another record with the 000 position 5 set to deleted (record status)
    Use koha-shell to run the job without the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -v
    * if the record had items, it will not be deleted
    * if the record did not have items, it will be deleted.

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 554391e56a4bf774283653f98fc24608cd9186e2
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Thu Mar 19 09:38:52 2020 +0100

    Bug 24902: Join different mc- limits with AND (elasticsearch)

    In the advanced search form, you can enable several limits using syspref
    AdvancedSearchTypes (namely itemtypes, shelving locations, collections)
    When used, the resulting query parts end up being joined with OR, even
    if the field is different. That means that if you pick "Book" under
    itemtypes tab, and "Fiction" under collection tab, it will search
    "itype:BOOK OR ccode:FIC". It should be AND.

    For instance, if you select:
        Itemtypes:
            ✓ Book
            ✓ DVD
        Location:
            ✓ Child
            ✓ Adult

    it should search:
        itype:(Book OR DVD) AND location:(Child OR Adult)

    Test plan:
    0. Do not apply the patch yet
    1. Enable elasticsearch
    2. Set syspref AdvancedSearchTypes = 'itemtypes|loc|ccode'
    3. Create a new itemtype and a new authorised value for categories LOC
       and CCODE
    4. Create a biblio with the new itemtype, another biblio with the new
       location, another biblio with the new collection, and again another
       biblio with the new itemtype, location and collection
    5. Verify that you can find these new biblio records using only the
       "advanced search types" in the advanced search form
    6. In the advanced search form, pick all 3 limits (itemtype, location,
       collection) and verify that it returns the 4 records.
    7. Apply the patch
    8. Repeat step 6, it should now return only the biblio that satisfies
       all criteria
    9. Verify that if you select more than one
       {itemtype|location|collection} it still returns results that
       satisfies any selected criteria
    10. prove t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |  1 +
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    | 26 +++++++-----
 .../prog/en/modules/reserve/request.tt             |  4 +-
 misc/cronjobs/delete_records_via_leader.pl         |  6 +--
 t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t   | 31 ++++++++++++++-
 t/db_dependent/Biblio/TransformHtmlToMarc.t        | 46 ++++++++++++++++++++--
 6 files changed, 95 insertions(+), 19 deletions(-)

hooks/post-receive
-- 
main Koha release repository