[koha-commits] main Koha release repository branch master updated. v19.11.00-1603-g25fa93a406
Git repo owner
gitmaster at git.koha-community.org
Mon Apr 6 12:24:47 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 25fa93a40683870c0e9c0fd96d839878aa2229c6 (commit)
via 57333cda12111dd9582eabaa06069eda2dd154f5 (commit)
via 7fe2c9147b6dd7a53969204586ca7b7460e30a05 (commit)
via 27dd3feafde45c4a949d63829035885e995120f2 (commit)
via 8cec8d548ce2924eaf4cc9a668ed7f9b7258460e (commit)
via dd0d2fa1c99126de9942ca7802baf18a42c2680e (commit)
via 8a56f176c083f7156584d07af7650162d13814e2 (commit)
via 26d4b7fd5e35f784f951c4f9e9bb084a9f4612a4 (commit)
via 93244efa3cbb66ff9e98d1eb4871da56a7565e5f (commit)
from f2efa1898db8b4d8d73bbc99de95571815561750 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 25fa93a40683870c0e9c0fd96d839878aa2229c6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 6 11:44:18 2020 +0200
Bug 24964: Restore pagination for patrons for owner/users of funds
admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only
retrieve patrons with acq (order_manage) permissions.
The original bug was hidden in the existing code, but the behavior was
terrible.
To prevent patrons matching the permissions contrainst to be hidden, we
fetched ALL the patrons from the DB, then filtered them depending on
their permissions. This might have awful performance on DB with lot of
patrons.
So basically with this patch we are adding the pagination back to the
"owner/users for funds" feature, as the permission filtering is now done
at DB level.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 57333cda12111dd9582eabaa06069eda2dd154f5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Apr 6 10:56:04 2020 +0100
Bug 4944: DBRev 19.12.00.064
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7fe2c9147b6dd7a53969204586ca7b7460e30a05
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Mar 31 14:45:14 2020 +0200
Bug 4944: Do not rely on the values from cache during the update DB process
We never know, as we insert values direcly to the DB, the cache may not
be correct.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 27dd3feafde45c4a949d63829035885e995120f2
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Mar 27 06:00:29 2020 +0000
Bug 4944: Add OpacNoItemTypeImages system preference
At the moment noItemTypeImages pref controls staff and OPAC
display. With this patch, there will be a separate OpacNoItemTypes
preference that allows to control display of each separately.
To test:
- Apply patch and run database update
In Administration:
- Search for 'noItemTypes' preferences
- Verify the settings of both prefs match
- Toggle prefs, verify everything works ok
- Go to the item types configuration page
- Try different settings for both prefs:
- Both set to No: Only a message with a link to the prefs should show
- Both set to Yes or either set to Yes: image configuration options
should show
In the OPAC:
- Check the following pages with item-level_itypes = record
- advanced search
- detail page
- place hold page
- Check the following pages with item-level_itypes = item
- result list
- a list (opac-shelves)
- checkouts and overdues tabs in patron account
(Note: this didn't work right before, but will now.)
- reading history in patron account
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8cec8d548ce2924eaf4cc9a668ed7f9b7258460e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Apr 6 10:48:09 2020 +0100
Bug 22534: DBRev 19.12.00.063
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dd0d2fa1c99126de9942ca7802baf18a42c2680e
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Mon Mar 23 04:14:39 2020 +0000
Bug 22534: Added syspref for defining what guarantee fields are pre filled
Librarians should be able to define what sections in member entryfields in 'Main address',
'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record
The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields
in the 'Contact' section should not be filled from guarantor patron
record as those fields are intended for guarantor's without patron
records in Koha.
Test plan:
1. On an adult patron's record (which has all fields filled out in the
'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor
first name', and 'relationship'), 'Alternate address', and 'Alternate contact') select 'Add guarantee'
2. Observe:
* Fields in 'Main address' are all automatically pre-filled
from guarantor record
* Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname'
and 'relationship') are all automatically pre-filled from guarantor
record
* Fields in 'Alternate address' (except for Contact note) are pre-filled from guarantor record
* None of the fields in 'Alternate contact' are pre-filled from guarantor
4. Apply patch
5. Run database updates
cd installer/data/mysql
sudo koha-shell <instancename>
./updatedatabase.pl
6. Restart plack:
sudo koha-plack --restart <instancename>
7. Go to Administration > Global system preferences and search for the
new PrefillGuaranteeField system preference
8. Observe this syspref contains checkboxes and the following are
selected by default:
Contact - Primary email
Contact - Primary phone
Main address - Address
Main address - City
Main address - Country
Main address - State
Main address - ZIP/Postal code
Main address - street number
Please note: 'Contact - Guarantor surname', 'Contact - Guarantor first
name', Contact - relationship' are not in PrefillGuaranteeField syspref
as they are for non Koha patrons and so should not be pre-filled from a Koha
patron.
9. Repeat step 1 and observe the following fields are prefilled from guarantor:
In Main address section -
streetnumber
address
city
state
zipcode/postal code
country
In Contact section -
Primary phone
Primary email
10. In the PrefillGuaranteeField syspref click '[Select all]' checkboxes
11. Repeat step 1 and observe all fields in 'Main address', 'Contact'
(except Guarantor surname, Guarantor first name, and relationship),
Alternate address and Alterate contact are filled from guarantor record.
i.e. The values in guarantor's 'Alternate address' fields fill the
guarantee's 'Alternate address' fields
12. Change a few of the prefilled field values and 'Save' and observe your changes
have been saved in addition to the unaltered pre-filled values in other
fields
13. Amend PrefillGuarantee field syspref to have no checkboxes selected
14. Repeat step 1 and observe none of the fields in Main address,
Contact, Alternate address and Alternate contact are pre-filled
15. Run tests:
sudo koha-shell <instancename>
prove xt
prove t
Sponsored-by: Waitaki Distict Council, NZ
Signed-off-by: Sally <sally.healey at cheshiresharedservices.go.uk>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8a56f176c083f7156584d07af7650162d13814e2
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Dec 5 17:42:50 2019 +0000
Bug 24183: Add before_send_messages hook
This patch adds a simple hook to the process_message_queue cronjob
to allow plugins to pre-process messages in the messaging queue before
they are sent.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 26d4b7fd5e35f784f951c4f9e9bb084a9f4612a4
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Feb 20 14:43:43 2020 +0000
Bug 24699: Split items.uri in OPAC detail view
Same change as in bug 24697 for staff. If there are more URIs in 952u,
we split them and show the real URL instead of Link to resource or the
value of pref URLLinkText.
I introduced a few template variables here to make the code a bit more
compact and readable.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 93244efa3cbb66ff9e98d1eb4871da56a7565e5f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 13 10:48:11 2020 +0100
Bug 16547: Do not display "multi holds" view if only one is selected
If a hold is selected from the result list, we should let the ability to
select an item-level hold.
Test plan:
I. Detail page
1/ Go to a bibliographic record detail page
2/ Click "Place hold"
3/ Select a patron
=> No change expected, you can select an item
II. Search result, multiple holds
1/ Search for an item with more than one search result
2/ Select several items, click 'Place hold'
3/ Enter a patron card number
=> No change expected, item level holds are not available.
III. Search result, single hold
1/ Search for an item with more than one search result
2/ Select only one item, click 'Place hold'
3/ Enter a patron card number
=> With this patch applied, item level hold is available. The screen is the same
as when you place a hold from the bibliographic record detail page
=> Without this patch you cannot place an item-level hold
QA notes: We could go a bit further and remove the 2 biblionumbers and
biblionumber from hold script, as well as remove the checkMultiHold in
request.tt. We should not have a biblionumbers param that contain a list
of biblionumber separated by '/' but several biblionumber parameters
instead.
QA notes 2: About placerequest.pl, see bug 19618 comment 27.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/UsageStats.pm | 1 +
Koha.pm | 2 +-
installer/data/mysql/sysprefs.sql | 4 +-
installer/data/mysql/updatedatabase.pl | 21 +++++++++
.../prog/en/modules/admin/itemtypes.tt | 14 +++---
.../prog/en/modules/admin/preferences/admin.pref | 2 +-
.../prog/en/modules/admin/preferences/opac.pref | 7 +++
.../prog/en/modules/admin/preferences/patrons.pref | 36 ++++++++++++++++
.../prog/en/modules/catalogue/advsearch.tt | 2 +-
.../prog/en/modules/catalogue/results.tt | 1 -
.../prog/en/modules/common/patron_search.tt | 8 +---
.../prog/en/modules/reserve/request.tt | 12 ------
.../prog/en/modules/virtualshelves/shelves.tt | 1 -
.../bootstrap/en/modules/opac-advsearch.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 47 +++++++--------------
.../bootstrap/en/modules/opac-readingrecord.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +-
.../bootstrap/en/modules/opac-results-grouped.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +-
members/.nfs0000000000721f7f00000014 | Bin 0 -> 16384 bytes
members/memberentry.pl | 15 +++----
misc/cronjobs/process_message_queue.pl | 17 ++++++++
reserve/modrequest.pl | 3 +-
reserve/placerequest.pl | 18 +++-----
reserve/request.pl | 7 ++-
27 files changed, 138 insertions(+), 96 deletions(-)
create mode 100644 members/.nfs0000000000721f7f00000014
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list