[koha-commits] main Koha release repository branch master updated. v19.11.00-1647-gce940939d4
Git repo owner
gitmaster at git.koha-community.org
Mon Apr 6 13:49:20 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via ce940939d445aad121a6b48f72c6c93bd79c0157 (commit)
via a5301a99ab015423fe9315eb5e7ccbf25aa9f118 (commit)
via c98d6f14ee588e5648c97ad75dfa07d0a719739f (commit)
via 0885344e8056f34dd2cd9f38626fcaf321dda961 (commit)
via bbb72bbd8d0b43c5b16401ee3c27a60fcc089093 (commit)
via fb1bdea6d1eefba754d0eb384a8c2e4b03ffd150 (commit)
via d6134c29174494e5fd85cb1d3c2a8f733c769a8f (commit)
via 01c3067a7ca66e358b89ddf34eb08b48df0c5d1b (commit)
via 3509f9cff86da2faea2ccc53ecdd0fdee70366c5 (commit)
via dcc93ec356dbc5a4a94b3e9f63a9c4073a3f4176 (commit)
via b8b2301f1320c2b7978b202cd1d196ae838dd8b5 (commit)
via f12da2c1dd7333578324b2e9b6a5e78190a1e7f6 (commit)
via fefb95b2e7cba0a0bfd47eacae92c1319ad5d496 (commit)
via 185adc167433133626710edd296555db2d27865c (commit)
via 12d2d3f69bbd04889e21ccd4568a1b40dadfad2c (commit)
via c95ae98d6085495e055d6d6775fb8e0acc1e1cc5 (commit)
via 282b85ef69b7e1fb55409d609e870832383ef710 (commit)
via fc8f2d261bbf6a1850c9f8fa2de230550e27a616 (commit)
via 7de7d4095a6092bc4b3dacd1f2e3b5c616fc572f (commit)
via ffb5a071cbf8a5d54ecfcf26994fd0349b994180 (commit)
via d198aaec04d5dc9ee26a702fb81fdad62d4edde6 (commit)
via a0775299e2109fb54fef1c104616290a5b2d929e (commit)
via 7fd92fcce9efdb45cc4fb6f309bfccbd3779a415 (commit)
via fa23374d06f75f47e674cb46298b8e2a8325e404 (commit)
via 499c6e45d271c507a757deb58d9dd42f4323a47d (commit)
via 96883e69b577e1861741d5d5c4ea48d40f4eca1d (commit)
via 414da449ddc341624c8ae35ebb1e86f07ecf70fb (commit)
via 5d05b4d01c6393c4566fc10d080f14717f881798 (commit)
via 5877fcf2c9caacfb7c0417403a2bdf209c94e230 (commit)
via 87c3a1fa6316552650aacc4699555beafc1be24b (commit)
via d6d0c4b7921a80ff62336efcd8ca01bf562c0f02 (commit)
via 5523fb02734a91aa86d44c2e6aac30050adcc85e (commit)
via 910815a49ca0dbec4f31fd8a62ea075ccba269f1 (commit)
via fb482d2767c7a70d7e60c4bd892aa334447f3938 (commit)
via 48e1716a8a5c0bd7de2de7f76fd12c8f18c88715 (commit)
via 2a2da6c0ea1e323fb3ab5c9a44db45acc906b1b4 (commit)
via dd1d8f35a9330c9edc01627ef806c463ff31db80 (commit)
via f5edd39e612656d7fffbedc29f7112a49cd5999b (commit)
via a592317d864148c80c09d4f3a7d17a2a1506a1ac (commit)
via be853b43039832a9b7a7fbca4b74602b10ec43dc (commit)
via 67daec2e5a3bf3eea207fe8250db43878ed7ffc3 (commit)
via dd55209f251dfbb34a6c95266ea6e0fd4d6580d8 (commit)
via cede9bbe43f39d44317b7cd9ba742a71d45e67f9 (commit)
via 2e1e9c5b4846b057ac707f3e5fc84427c1dd71d9 (commit)
from 25fa93a40683870c0e9c0fd96d839878aa2229c6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ce940939d445aad121a6b48f72c6c93bd79c0157
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Apr 6 11:25:02 2020 +0100
Bug 4461: DBRev 19.12.00.066
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a5301a99ab015423fe9315eb5e7ccbf25aa9f118
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 3 15:06:53 2020 +0200
Bug 4461: Use inbound_email_address to know if we display the dropdown list
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c98d6f14ee588e5648c97ad75dfa07d0a719739f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 3 13:52:12 2020 +0200
Bug 4461: Correctly deal with encoding/escaping chars
This patch deals (hopefully) correctly with encoding and escaping chars.
It also remove OPACBaseURL from the url stored in DB, and readd is on
display, to avoid possible attacks.
Test plan:
Go to the authority search
fill term with something hacky
<script>alert('booh!')</script>And Ŝ♥m€ E★tr₳
Search
Click the "Report a problem" link
Fill the form and make sure the url is displayed correctly
submit
Check problem_reports.problempage in DB => Should be correctly displayed
Go to staff interface, "OPAC problem reports"
=> Confirm the link is correctly display
Click it
=> Confirm that you are at the OPAC, and the URL is correct
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0885344e8056f34dd2cd9f38626fcaf321dda961
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 3 14:40:16 2020 +0200
Bug 4461: Extend problem_reports.problempage to TEXT
255 chars is not enough if want want to store any kind of URL, for
instance an authorities search can be much longer
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit bbb72bbd8d0b43c5b16401ee3c27a60fcc089093
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 3 14:39:45 2020 +0200
Bug 4461: dbic schema update
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fb1bdea6d1eefba754d0eb384a8c2e4b03ffd150
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 3 14:04:38 2020 +0200
Bug 4461: Hide link if KohaAdminEmailAddress is not set
opac-reportproblem.pl returns a 404 in that case
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d6134c29174494e5fd85cb1d3c2a8f733c769a8f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Apr 2 12:51:39 2020 +0200
Bug 4461: Fix OPAC link from staff
QA: We have a security issue here, we should not make this link
clickable from the staff side.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 01c3067a7ca66e358b89ddf34eb08b48df0c5d1b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Apr 2 11:25:31 2020 +0200
Bug 4461: get_effective_email has been renamed inbound_email_address
On commit 027051c938924a33a64014794705526ab68351af
Bug 22823: Rename method with ->inbound_email_address
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3509f9cff86da2faea2ccc53ecdd0fdee70366c5
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Wed Mar 18 22:50:50 2020 +0000
Bug 4461: Fix status and borrowernumber fields in problem_reports and more
status varchar(6) with readable statuses
borrowernumber not null default 0
hide form if message successfully sent
fixing hide viewed and hide closed filters
adding recipient column
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dcc93ec356dbc5a4a94b3e9f63a9c4073a3f4176
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Mar 11 09:08:52 2020 +0000
Bug 4461: DBIC Schema Files
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b8b2301f1320c2b7978b202cd1d196ae838dd8b5
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Mar 19 00:26:33 2020 +0000
Bug 4461: Checks on library email before enqueuing letter
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f12da2c1dd7333578324b2e9b6a5e78190a1e7f6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 12 12:51:27 2020 +0100
Bug 4461: Update license statements
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fefb95b2e7cba0a0bfd47eacae92c1319ad5d496
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Mar 11 09:06:09 2020 +0000
Bug 4461: (follow-up) Add missing relationship accessor
I think this was a simple case of Aliesha missing a file when commiting.
So I could proceed with testing I just quickly re-implimented the patron
relationship accessor.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 185adc167433133626710edd296555db2d27865c
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Wed Mar 11 01:52:27 2020 +0000
Bug 4461: Manage problem reports on the staff client
Test plan:
- Update database and upgrade schema files (if you haven't already).
Restart memcached
- Check your user's permissions and ensure the 'problem_reports'
permission is ticked. Confirm the OPACReportProblem syspref is enabled
- Log into the OPAC and submit a problem report
- Log into the staff client
- You should see a box at the bottom of the main page showing your
pending problem report
- Click the link and confirm it takes you to the new page for managing
problem reports
- Go to Administration
- Confirm you can see a link to 'OPAC problem reports' under the
'Additional parameters' heading
- Click 'OPAC problem reports'
- Confirm your problem report is showing in the table
- Open the OPAC in another tab and submit at least two more problem
reports (so you should have at least three in the table after
refreshing)
- Try the different buttons
- selecting multiple problem reports and using the big 'mark
viewed', 'mark closed', 'mark new' buttons. Confirm there are no
failures and that the number of selected problem reports is correct
- select all, clear all, hide viewed, hide closed, hide new, show
all
- individual 'mark viewed', 'mark closed', 'mark new' buttons for
each problem report. Confirm the status shows and the correct button
is disabled while others are enabled
- Confirm the problem page link works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 12d2d3f69bbd04889e21ccd4568a1b40dadfad2c
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Mar 10 22:52:29 2020 +0000
Bug 4461: Add problem reports link to mainpage and admin home
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c95ae98d6085495e055d6d6775fb8e0acc1e1cc5
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Mar 10 22:27:56 2020 +0000
Bug 4461: Adding user flags for managing OPAC problem reports
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 282b85ef69b7e1fb55409d609e870832383ef710
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Mar 2 15:18:33 2020 +0000
Bug 4461: Use get_effective_email from bug 22823
Use the get_effective_email from Koha::Library to get an appropriate
inbound address for the branch as aposed to using branchemail directly.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fc8f2d261bbf6a1850c9f8fa2de230550e27a616
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Mar 2 15:16:37 2020 +0000
Bug 4461: Drop 'from_address' use 'reply_address'
This patch adds support for using the reply-to field added in bug 10269
and drops 'from_address' as it will get defined at a later stage in the
emailing process anyway.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7de7d4095a6092bc4b3dacd1f2e3b5c616fc572f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Mar 2 14:58:15 2020 +0000
Bug 4461: Remove hard requirement on OpacKohaUrl
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ffb5a071cbf8a5d54ecfcf26994fd0349b994180
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 26 12:15:42 2020 +0100
Bug 4461: Better error handling
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d198aaec04d5dc9ee26a702fb81fdad62d4edde6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 26 11:59:34 2020 +0100
Bug 4461: Simplify recipients code
As the feature is now turned off without KohaAdminEmailAddress, we only
need to check if the email address of the library if defined.
Not that we should not check for $library->branchreplyto or
ReplytoDefault, but only $library->branchemail, as we do everywhere else
(I think)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a0775299e2109fb54fef1c104616290a5b2d929e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 26 11:41:39 2020 +0100
Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7fd92fcce9efdb45cc4fb6f309bfccbd3779a415
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 26 11:28:30 2020 +0100
Bug 4461: Use our local_referer instead of HTTP_REFERER
Cannot remember why exactly, but it seems that we should not use
HTTP_REFERER directly.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fa23374d06f75f47e674cb46298b8e2a8325e404
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 26 11:08:51 2020 +0100
Bug 4461: Use KohaAdminEmailAddress pref as 'from'
We usually do not specify the from_address on enqueuing the notice, but
when sending it (from _send_message_by_email). That way a) the code is
centralized (as we must use $patron->notice_email_address) and b) the
email used is the one that is in the DB when the letter is effectively
sent.
Here I guess you need to give it when the notice is enqueued as you want
to default to the koha admin address.
I do not think it's a good idea, we should not send an email with "from"
if not really sent by the user.
We have the borrowernumber anyway to know who filled the form.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 499c6e45d271c507a757deb58d9dd42f4323a47d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 26 10:58:38 2020 +0100
Bug 4461: Rename report date with created_on
And make it a timestamp type column
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 96883e69b577e1861741d5d5c4ea48d40f4eca1d
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Feb 25 04:04:43 2020 +0000
Bug 4461: (follow-up) Creating sample notice and other fixes
- filters
- capitalisation
- atomic update
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 414da449ddc341624c8ae35ebb1e86f07ecf70fb
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Feb 11 19:48:30 2020 +0000
Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5d05b4d01c6393c4566fc10d080f14717f881798
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Feb 11 03:16:11 2020 +0000
Bug 4461: Submit a problem report
To test:
1) Apply patch, update database, rebuild schema file
2) Restart koha-common and memcached
3) Confirm that your user has an email address.
4) Confirm that your library does NOT have an email address.
5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref.
6) Log into OPAC
7) Click the 'Report a problem' link at the bottom of whatever page
you're on
8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted
9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'.
10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message.
11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option.
12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message.
13) Ensure all details in the message_queue are correct.
14) Log out of the OPAC
15) Click the Report a problem link again and confirm you are forced to log in
Sponsored-by: Catalyst IT
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5877fcf2c9caacfb7c0417403a2bdf209c94e230
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Feb 11 00:00:11 2020 +0000
Bug 4461: Problem Report Koha objects
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 87c3a1fa6316552650aacc4699555beafc1be24b
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Mon Feb 10 00:50:51 2020 +0000
Bug 4461: Database and syspref changes
Adding problem_reports table and OPACReportProblem syspref
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d6d0c4b7921a80ff62336efcd8ca01bf562c0f02
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Apr 6 11:11:12 2020 +0100
Bug 23173: DBRev 19.12.00.065
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5523fb02734a91aa86d44c2e6aac30050adcc85e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Apr 1 15:13:06 2020 -0400
Bug 23173: (follow-up) Fix QA script errors
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 910815a49ca0dbec4f31fd8a62ea075ccba269f1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Apr 1 15:09:48 2020 -0400
Bug 23173: (follow-up) Small improvements in efficiency
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fb482d2767c7a70d7e60c4bd892aa334447f3938
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Mon Mar 16 12:06:03 2020 +0000
Bug 23173: (follow-up) Display available partners
When selecting partners for search during the "Place request with
partner libraries" workflow, there was no indication of which partners
could actually be searched (i.e. are attached to a Z target and enabled
for partner search). We now list them
Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at tudublin.ie>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 48e1716a8a5c0bd7de2de7f76fd12c8f18c88715
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Mon Feb 17 12:29:19 2020 +0000
Bug 23173: (follow-up) Allow for customisable display name
We now allow for the service to return a name that can be specified in
the plugin config. This patch switches to using that, rather than just
the plugin name defined in the plugin's metadata hashref
Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at tudublin.ie>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2a2da6c0ea1e323fb3ab5c9a44db45acc906b1b4
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Thu Feb 6 11:08:41 2020 +0000
Bug 23173: (follow-up) Allow for wide characters
The conversion of the metadata into Base64 for passing in the API call
to the plugin API routes was failing if the metadata contained a wide
character, so we now encode it into UTF-8 first
Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at tudublin.ie>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dd1d8f35a9330c9edc01627ef806c463ff31db80
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Sep 10 16:32:49 2019 +0100
Bug 23173: Add unit tests
Test Koha::Illrequests::Availability
Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at tudublin.ie>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f5edd39e612656d7fffbedc29f7112a49cd5999b
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Thu Jul 11 14:15:55 2019 +0100
Bug 23173: Provide core infrastructure
This patch adds the required infrastructure to enable ILL availability
plugins to intercept the request creation process and, using the
supplied metadata, search for and display possible relevant items from
whichever availability plugins are installed.
Currently three availability plugins exist:
z39.50 - Searches any number of the Koha instance's configured Z targets
https://github.com/PTFS-Europe/koha-plugin-ill-avail-z3950
EDS - Searches the EBSCO Discovery Service
https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds
Unpaywall - Searches the Unpaywall API for possible open access versions
of the requested item
https://github.com/PTFS-Europe/koha-plugin-ill-avail-unpaywall
The Unpaywall plugin is intended to serve as a "reference" plugin as the
API it deals with is extremely simple
Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at tudublin.ie>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a592317d864148c80c09d4f3a7d17a2a1506a1ac
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Fri Jun 21 10:17:03 2019 +0100
Bug 23173: Add ILLCheckAvailability syspref
This patch adds the new syspref "ILLCheckAvailability"
Sponsored-by: Public Health England
Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon at tudublin.ie>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit be853b43039832a9b7a7fbca4b74602b10ec43dc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Apr 1 00:11:19 2020 -0300
Bug 18227: (QA follow-up) Add fix to koha-common.postinst
Now koha-common.postinst has a way to patch log4perl configs on
instances, we should patch the Z3950 responder config accordingly,
before it is backported to 19.11 or the 20.05 release :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 67daec2e5a3bf3eea207fe8250db43878ed7ffc3
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Wed Mar 8 12:51:43 2017 +0200
Bug 18227: Handle utf8 in Koha::Logger
No more wide characters in print when logging to a file with Koha::Logger.
Test with this string
"♯Turpo :"
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dd55209f251dfbb34a6c95266ea6e0fd4d6580d8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Apr 1 06:19:24 2020 -0400
Bug 24537: Tidy code
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cede9bbe43f39d44317b7cd9ba742a71d45e67f9
Author: David Cook <dcook at prosentient.com.au>
Date: Thu Jan 30 14:53:09 2020 +1100
Bug 24537: Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask
This patch uses Net::Netmask to match IPs from ILS-DI:AuthorizedIPs
against $ENV{REMOTE_USER}. By using Net::Netmask, we can use addresses
in a variety of formats. This includes 127.0.0.1, 192.168.1.0/24,
10.0.0, and so on.
To Test:
1. Apply the patch
2. Empty the 'ILS-DI:AuthorizedIPs' system preference
3. Send a request to '/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber'
3b. Note that the request is successful
4. Set the 'ILS-DI:AuthorizedIPs' system preference to a subnet including
your IP address (e.g. 192.168.1.0/24)
5. Send a request to '/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber'
5b. Note that the request is successful
6. Set the 'ILS-DI:AuthorizedIPs' system preference to a subnet that doesn't include
your IP address (e.g. 1.1.1)
7. Send a request to '/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber'
7b. Note that your request is refused
8. Try a variety of permutations including bad values (e.g. 192.168.1.) or multiple values
(e.g. 10.0.0.0/8,192.168.1.0/24) or multiple values including a mix of good and bad values
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2e1e9c5b4846b057ac707f3e5fc84427c1dd71d9
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Mar 30 15:16:36 2020 +0000
Bug 23601: Prevent default for auxclick
The issue appears to be that the default action is not prevented for middle click because it registers
an 'auxclick' event as opposed to a 'click' event
To test:
1 - Perform a search in staff client
2 - Shift-click and hold on a result
3 - Note a new tab opens
4 - Release the click, no change
5 - Middle click and hold on a result
6 - New tab opens
7 - Release, a second new tab opens
8 - Apply patch
9 - Reload page
10 - Middle click and hold
11 - New tab opens
12 - Release
13 - No new tab
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 3 +-
C4/InstallAuth.pm | 1 +
C4/Letters.pm | 1 +
Koha.pm | 2 +-
Koha/Illrequest/Availability.pm | 127 +++++++++++
Koha/{Review.pm => ProblemReport.pm} | 34 +--
Koha/{Items.pm => ProblemReports.pm} | 23 +-
Koha/Schema/Result/Borrower.pm | 19 +-
Koha/Schema/Result/Branch.pm | 19 +-
Koha/Schema/Result/ProblemReport.pm | 189 +++++++++++++++++
circ/checkout-notes.pl => admin/problem-reports.pl | 42 ++--
debian/koha-common.postinst | 1 +
debian/templates/log4perl-site.conf.in | 3 +
etc/log4perl.conf | 3 +
ill/ill-requests.pl | 78 ++++++-
.../data/mysql/de-DE/mandatory/sample_notices.sql | 3 +-
.../data/mysql/en/mandatory/sample_notices.yml | 17 ++
.../data/mysql/es-ES/mandatory/sample_notices.sql | 3 +-
.../mysql/fr-CA/obligatoire/sample_notices.sql | 3 +-
.../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 3 +-
installer/data/mysql/it-IT/necessari/notices.sql | 3 +-
installer/data/mysql/kohastructure.sql | 21 ++
.../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 3 +-
.../data/mysql/pl-PL/mandatory/sample_notices.sql | 3 +-
.../data/mysql/ru-RU/mandatory/sample_notices.sql | 3 +-
installer/data/mysql/sysprefs.sql | 2 +
.../data/mysql/uk-UA/mandatory/sample_notices.sql | 4 +-
installer/data/mysql/updatedatabase.pl | 57 +++++
installer/data/mysql/userflags.sql | 3 +-
installer/data/mysql/userpermissions.sql | 3 +-
koha-tmpl/intranet-tmpl/js/browser.js | 2 +-
.../intranet-tmpl/prog/css/src/staff-global.scss | 23 ++
.../intranet-tmpl/prog/en/includes/admin-menu.inc | 3 +
.../prog/en/includes/ill-availability-table.inc | 16 ++
.../intranet-tmpl/prog/en/includes/permissions.inc | 9 +
.../prog/en/modules/admin/admin-home.tt | 4 +
.../en/modules/admin/preferences/circulation.pref | 7 +
.../prog/en/modules/admin/preferences/opac.pref | 8 +
.../prog/en/modules/admin/problem-reports.tt | 231 +++++++++++++++++++++
.../prog/en/modules/ill/ill-requests.tt | 87 +++++++-
.../intranet-tmpl/prog/en/modules/intranet-main.tt | 9 +-
.../prog/en/modules/plugins/plugins-home.tt | 1 +
.../prog/js/ill-availability-partner.js | 41 ++++
.../intranet-tmpl/prog/js/ill-availability.js | 222 ++++++++++++++++++++
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 9 +
.../en/includes/ill-availability-table.inc | 17 ++
.../bootstrap/en/includes/opac-bottom.inc | 11 +-
.../bootstrap/en/modules/opac-illrequests.tt | 47 +++++
.../bootstrap/en/modules/opac-reportproblem.tt | 96 +++++++++
.../opac-tmpl/bootstrap/js/ill-availability.js | 178 ++++++++++++++++
mainpage.pl | 3 +
opac/ilsdi.pl | 21 +-
opac/opac-illrequests.pl | 43 ++++
opac/opac-reportproblem.pl | 144 +++++++++++++
svc/{checkout_notes => problem_reports} | 29 +--
.../Illrequest/Availability.t} | 47 ++---
tools/letter.pl | 4 +
57 files changed, 1860 insertions(+), 128 deletions(-)
create mode 100644 Koha/Illrequest/Availability.pm
copy Koha/{Review.pm => ProblemReport.pm} (68%)
copy Koha/{Items.pm => ProblemReports.pm} (78%)
create mode 100644 Koha/Schema/Result/ProblemReport.pm
copy circ/checkout-notes.pl => admin/problem-reports.pl (53%)
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/ill-availability-table.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/problem-reports.tt
create mode 100644 koha-tmpl/intranet-tmpl/prog/js/ill-availability-partner.js
create mode 100644 koha-tmpl/intranet-tmpl/prog/js/ill-availability.js
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/includes/ill-availability-table.inc
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/js/ill-availability.js
create mode 100755 opac/opac-reportproblem.pl
copy svc/{checkout_notes => problem_reports} (63%)
copy t/{Koha/Script_cron.t => db_dependent/Illrequest/Availability.t} (52%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list