[koha-commits] main Koha release repository branch master updated. v19.11.00-1711-g63b44f2ddd

Tue Apr 14 17:40:24 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  63b44f2ddd9cb67b80b840a7ad2bd3d77971cb2d (commit)
       via  73fd85fd02c2ea5aa69c93413e3d7fcd00c12b15 (commit)
       via  a2f24f8e58410cd6d7ceed131182131dd3ce46aa (commit)
       via  79754df526d4b0225419678b76ece8315000d671 (commit)
       via  8a049803665d3e600f19ae70158c53132ec5a505 (commit)
       via  c0f615fe533b802dec0e4a49923556e117ceca78 (commit)
       via  2598feedb90faedf31e12c0f1f90e7707b11f846 (commit)
       via  467dbcc60962dcef31c109a4efb93e2085af6696 (commit)
       via  135ab4c26ad8f32f4aed291578145b82574ab075 (commit)
       via  1709388c3a9c59f8d5bcd9d73add2236acdda84f (commit)
       via  51dbb84a78e7ad833ab2ce6104ed54954ded6835 (commit)
       via  30ea935720f8848be8a9a467d9dda89275d4557b (commit)
      from  1cae1929d366d16e36f7a777537bbef9a906d62c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 63b44f2ddd9cb67b80b840a7ad2bd3d77971cb2d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Apr 14 15:57:58 2020 +0100

    Bug 21190: DBRev 19.12.00.068

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 73fd85fd02c2ea5aa69c93413e3d7fcd00c12b15
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Jan 30 09:27:56 2020 +0000

    Bug 21190: (follow-up) Save patron id in failure when available

    The wrong password might belong to an existing user. If that is the case,
    we have a $patron.
    Note that logaction will save the object info but has no user in the
    context environment for a failure.

    Test plan:
    Login with good user, bad pw and bad user, bad pw. Check logviewer.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a2f24f8e58410cd6d7ceed131182131dd3ce46aa
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Oct 28 10:06:11 2019 +0000

    Bug 21190: Add tests for authentication success and failure

    Test plan:
    Run t/db_dependent/Log.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 79754df526d4b0225419678b76ece8315000d671
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 25 10:12:16 2019 +0000

    Bug 21190: Allow browsing the system logs for AUTH events

    Trivial change, adding AUTH to viewlog template only.

    Test plan:
    Look for the Authentication log lines in viewlog.pl (intranet tools).

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8a049803665d3e600f19ae70158c53132ec5a505
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 25 09:55:32 2019 +0000

    Bug 21190: Add authentication logging to checkpw

    Add optional logging for successful and failing login attempts in
    checkpw.

    Test plan:
    Enable the preferences
    Perform a good login and a bad attempt
    Check action_logs

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c0f615fe533b802dec0e4a49923556e117ceca78
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 25 09:36:03 2019 +0000

    Bug 21190: Introduce preferences AuthFailureLog and AuthSuccessLog

    Test plan:
    Run atomic update.
    Check the Logs tab of preferences.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2598feedb90faedf31e12c0f1f90e7707b11f846
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 25 08:21:20 2019 +0000

    Bug 21190: Remove t/Log.t

    Since we have t/db../Log.t and t/Log.t simply does nothing, we would
    better remove it.

    No test plan either :)

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 467dbcc60962dcef31c109a4efb93e2085af6696
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 25 08:10:18 2019 +0000

    Bug 21190: Add interfaces parameter to POD in C4::Logs

    Just fixing documentation along the way.
    No test plan, just read the patch.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 135ab4c26ad8f32f4aed291578145b82574ab075
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 25 07:32:56 2019 +0000

    Bug 21190: Add subtest to Log.t for GDPR logging

    Apart from a new subtest, doing some more cleanup:
    [1] Copyright statement
    [2] Removing the (unneeded) flush
    [3] Removing C4::Log from the BEGIN block; we seem to skip that nowadays.
    [4] $succes goes to the subtest, $schema and $dbh are global our vars.
        Not required but just what we should do if it would run under Plack.

    Test plan:
    Run t/db_dependent/Log.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1709388c3a9c59f8d5bcd9d73add2236acdda84f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 25 07:14:18 2019 +0000

    Bug 21190: Prepare Log.t for further changes

    This patch only makes cosmetic changes:
    [1] It moves the existing tests at 'root level' inside a new subtest.
    [2] It obviously adds indentation for step 1.
    [3] It fixes some whitespace (tabs, space before newline)

    Test plan:
    Run t/db../Log.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 51dbb84a78e7ad833ab2ce6104ed54954ded6835
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Mar 31 16:39:12 2020 +0200

    Bug 25027: Use localStorage instead of sessionStorage for results browser

    Staff side, when a search a done and a result clicked, a browser appears
    on the left, to navigate between the different results.

    We use sessionStorage to know the list of biblionumber from the result.

    As sessionStorage is only for the current tab, we do some ugly things,
    to catch the click events, then open the new tab, attach it to the
    current window, and put the focus back on the result list.

    We really should not do that, and let the user decide what they want to
    do with their clicks!

    To do so, let use the correct storage, localStorage, and have the
    results shared between the windows.

    We may need to clear that at some point, isn't it?

    Test plan:
    Launch a search, click result (left or middle), confirm you see the
    browser and that the window/tab opened like any other websites
    (depending on your web browser settings).

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 30ea935720f8848be8a9a467d9dda89275d4557b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Apr 14 15:54:17 2020 +0100

    Bug 20754: (RM follow-up) Fix DB Update

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                         |   9 ++
 C4/Log.pm                                          |   2 +-
 Koha.pm                                            |   2 +-
 installer/data/mysql/sysprefs.sql                  |   2 +
 installer/data/mysql/updatedatabase.pl             |  16 +-
 koha-tmpl/intranet-tmpl/js/browser.js              |  22 +--
 .../prog/en/modules/admin/preferences/logs.pref    |  13 ++
 .../intranet-tmpl/prog/en/modules/tools/viewlog.tt |   3 +-
 t/Log.t                                            |  12 --
 t/db_dependent/Log.t                               | 173 ++++++++++++---------
 10 files changed, 147 insertions(+), 107 deletions(-)
 delete mode 100755 t/Log.t

hooks/post-receive
-- 
main Koha release repository