[koha-commits] main Koha release repository branch master updated. v19.11.00-1761-g3999741d4a
Git repo owner
gitmaster at git.koha-community.org
Tue Apr 14 18:51:29 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 3999741d4a753ba593e4716618deac2141c4c889 (commit)
via 66b62058d6d95469bc0fe1add52f7319a0839401 (commit)
via 234262fae33a73d96d9c04e1ede0a48eca1fd5d2 (commit)
via d117a7d3eadbb9ce019b92e18187ed53b2ef3249 (commit)
via 323e1a2a2f28881e6aed13c78df1d0a3d5069c4e (commit)
via b925d88de16e5e391a91f32d62dc32355095be84 (commit)
via 2ce0327480b95c7fbb6b556966524d7c803ef2d7 (commit)
via dcaba0ac4eb969abddcdb7d79c0c2c6f6e0f8dff (commit)
via c132946cc075f0d622440054c439f69ff38544b5 (commit)
via 0a70b46119c5df2c610a396393887161be9b3f85 (commit)
via 2fbae01c9b127516953bbeafd77d1a030379f3a8 (commit)
via e5e26645ee411488f01502892f841ba54a79604e (commit)
via 0d4fed889904c5eeba05f12bdbf8d14f0e3ae0a8 (commit)
via 83cde3858e5bfaf0619ecd4e9075d47e7063f199 (commit)
via 17afb2b9ba6e9c38c9ed106deb7c2cf1023d7a5c (commit)
via 29f399f1f8608310172b8f6963ad79a077783225 (commit)
via 5793a29221cb9b687ec43381d6e1562d1b948e55 (commit)
via 2e4fa2d677873778d53b92422642b62e9034cd77 (commit)
via 936976a1fe9d0996c22e1b3727d5782a9f114cb2 (commit)
via ec6c143f1b26f219f1e9ab5852436da09c857758 (commit)
via 74c63d27c7f250da99255d7e64cfdad08a1702aa (commit)
via e788ac4e5838ad530424eeff24302f5aee4c452a (commit)
via fc4cffe1f0ac1379ddd1ce621189f1ef2d55d1fa (commit)
via bf60a9c88cd223e53acd1d8e58508eb6d1febbb5 (commit)
via fc29f2afa177fd3c497bcf5ec4bdb9299d396dc9 (commit)
via f3e02aedf38b7f72207df5263c184d3e6af60f52 (commit)
via 860264af6f6e3b51fb8b6eac4da25599c8568931 (commit)
via 70ea3e39a883a4feb85f894e4fb25b59d21d5688 (commit)
via 675ab180b098af15c2a24d90c1015a2291fd9126 (commit)
via 294d6f54e5e57279168c042f76c209eb2b0e346e (commit)
via b32c8fb91bf6c19124e7626a45191e3c50e0b73e (commit)
via 91f9f8cdfd1ecbf56bbc4771d7c58cd9b468fc64 (commit)
via 220c4906bf1bc399e639d5bd1c2c84319c54e3b8 (commit)
via 82244a30b75435ee7e37d07e499c49844732d941 (commit)
via f843e8be51edfd3f7d01e79d3d63bb1f389bc8f1 (commit)
via 97876fa76dc3f618e76c6ff246da68be197a74dd (commit)
via 6380c479b64ee78f6533312fc9c97530a843ac08 (commit)
via 41e6f0447c00a817ff982ce70bbf98f78b968712 (commit)
via f5b8b6b38c4db29ab66d5aeaf50eb6f1ab4e6e19 (commit)
via 6f6f68d55b0a2740fde5c75364c12736b00bd020 (commit)
via 468047c383536d802e1e02e3fefb2168dc9d27c7 (commit)
via 86db304cd45ad2fc2f59bde30ae261b18831e8c6 (commit)
via e98e77bd7323876c45854280ab9788f01c41503c (commit)
via cd268bdbb2a9dfd2c70bc3f1fe1057b5860d06b4 (commit)
via d6fc05891b5558fd5f2bb95c1fd200bcc43e2806 (commit)
via 2d2ffbd075c95eb465fcc32c53b19f11d67cb4b6 (commit)
via 77b7014f883e4f48310c3e03ca56f50a6ffa60f2 (commit)
via d3a6cc48d0b7c6557d8d263580a96e1d87d79814 (commit)
via fd831a07883993e8437fa80cb631cff3d4ed27ed (commit)
via 6aee18111ed9c4efa92a242974c5ac439aa38880 (commit)
from 63b44f2ddd9cb67b80b840a7ad2bd3d77971cb2d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3999741d4a753ba593e4716618deac2141c4c889
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Apr 14 17:21:25 2020 +0100
Bug 22887: DBRev 19.12.00.071
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 66b62058d6d95469bc0fe1add52f7319a0839401
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 14 10:12:57 2020 +0200
Bug 22887: Remove dup fr-FR for existing installs
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 234262fae33a73d96d9c04e1ede0a48eca1fd5d2
Author: Lari Taskula <lari.taskula at hypernova.fi>
Date: Tue Apr 7 11:47:44 2020 +0000
Bug 22887: Schema changes
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d117a7d3eadbb9ce019b92e18187ed53b2ef3249
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 26 10:29:11 2020 +0100
Bug 22887: Rely on unique constraint in av admin
Test plan:
Try to create 2 AV with the same code for the same category.
You should see a warning
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 323e1a2a2f28881e6aed13c78df1d0a3d5069c4e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 26 10:36:03 2020 +0100
Bug 22887: Remove dup in fr-FR av.sql
https://en.wikipedia.org/wiki/Cocos_(Keeling)_Islands
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b925d88de16e5e391a91f32d62dc32355095be84
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 26 10:28:50 2020 +0100
Bug 22887: Warn if duplicates exist
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2ce0327480b95c7fbb6b556966524d7c803ef2d7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri May 10 15:32:03 2019 +0100
Bug 22887: Add unique constraint to authorised_values
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dcaba0ac4eb969abddcdb7d79c0c2c6f6e0f8dff
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Mar 10 07:12:07 2020 -0400
Bug 24620: Fix test, remove replaced code, use dt_from_string
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c132946cc075f0d622440054c439f69ff38544b5
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Feb 10 18:19:07 2020 +0000
Bug 24620: Close existing transfers when setting item to waiting
This patch adds a clause in ModReserveAffect to check if there
are existing transfers and close them when setting a hold to waiting
To test:
1 - Set AutomaticItemReturn to Do
2 - Checkin an item from Library B at Library A
3 - Confirm item is in transfer (check the details page)
4 - Place a item level hold for pickup at library A
5 - Checkin the item at Library A
6 - Confirm the hold
7 - View the details page
8 - Note the item is in transit and waiting
9 - Apply patch
10 - Delete hold and repeat
11 - Confirm that transfer is closed when hold marked waiting
Signed-off-by: Sally <sally.healey at cheshirewestandchester.gov.uk>
Signed-off-by: Stina Hallin <stina.hallin at ub.lu.se>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0a70b46119c5df2c610a396393887161be9b3f85
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Feb 10 18:18:45 2020 +0000
Bug 24620: Unit tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2fbae01c9b127516953bbeafd77d1a030379f3a8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 14 10:18:31 2020 +0200
Bug 23571: (QA follow-up) Remove perlcritic warning
Bareword file handle opened at line 138, column 5. See pages 202,204 of PBP. (Severity: 5)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e5e26645ee411488f01502892f841ba54a79604e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Apr 13 15:50:54 2020 -0300
Bug 23571: (QA follow-up) Add missing newline in warning
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0d4fed889904c5eeba05f12bdbf8d14f0e3ae0a8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Sun Apr 12 10:27:57 2020 -0300
Bug 23571: Prevent concurrent execution of fines.pl
This patch introduces locking in fines.pl. It does so by leveraging on
bug 25109, which introduces a generic locking implementation on
Koha::Script.
The introduced changes:
1. Try to get the lock
2.a. If success, normal execution happens
2.b. If rejected, cronlogaction is called with a meaningful message and
a normal exit happens, so we don't flood the logs in vain. --verbose
will make the script print the same message on STDERR, as already is
the case with this script
To test:
1. Apply this patch
2. In two separate consoles run:
$ kshell
k$ perl misc/cronjobs/fines.pl --verbose
SUCCESS => The first one runs normally, the second one exists really fast
and prints a message about the lock.
3. Sign off :-D
Sponsored-by: Orex Digital
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 83cde3858e5bfaf0619ecd4e9075d47e7063f199
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Apr 13 15:45:50 2020 -0300
Bug 25109: (QA follow-up) Add a test for lockdir writable in about.pl
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 17afb2b9ba6e9c38c9ed106deb7c2cf1023d7a5c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Apr 13 12:02:29 2020 -0300
Bug 25109: (QA follow-up) Fix typo in configuration entry name
This patch fixes an error in the configuration retrieving line.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 29f399f1f8608310172b8f6963ad79a077783225
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Apr 13 08:43:10 2020 -0300
Bug 25109: Add 'wait' tests
This simple patch introduces a test for the lock waiting scenario. It
replicates the previous tests, but calls a script that passes the wait
=> 1 parameter to ->lock_exec.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5793a29221cb9b687ec43381d6e1562d1b948e55
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Apr 10 19:37:31 2020 -0300
Bug 25109: Add ->new and ->lock_exec to Koha::Script
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2e4fa2d677873778d53b92422642b62e9034cd77
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Apr 10 19:36:41 2020 -0300
Bug 25109: Add entry in about.pl about the configuration lockdir entry
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 936976a1fe9d0996c22e1b3727d5782a9f114cb2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Apr 10 19:36:09 2020 -0300
Bug 25109: Add lockdir configuration entry
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ec6c143f1b26f219f1e9ab5852436da09c857758
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Oct 22 14:31:08 2019 +0200
Bug 23871: data inconsistencies - check title exists
In biblio records, a field must be linked to biblio.title.
200$a in UNIMARC, 100$a MARC21 (and other).
If this field is undefined, some pages like checkouts table can fail.
Test plan :
1) Remove biblio title in SQL :
UPDATE biblio SET title='' WHERE biblionumber=XXX
2) Run misc/maintenance/search_for_data_inconsistencies.pl
3) You see the record as an inconsistency
4) Reset a title
UPDATE biblio SET title='50 shades of Grey' WHERE biblionumber=XXX
5) Run misc/maintenance/search_for_data_inconsistencies.pl
6) Record is no longer an inconsistency
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 74c63d27c7f250da99255d7e64cfdad08a1702aa
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed Mar 11 17:39:18 2020 +0300
Bug 21865: allow test arg alone
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e788ac4e5838ad530424eeff24302f5aee4c452a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Nov 19 15:45:49 2018 +0100
Bug 21865: add confirm to remove_unused_authorities.pl script
Like in most scripts in misc, add confirm argument
to ensure script is not run without knowing what it does.
Test plan:
1) Run misc/migration_tools/remove_unused_authorities.pl -h
2) You see help line for confirm
3) Run misc/migration_tools/remove_unused_authorities.pl
4) You see help and script does nothing
5) Run misc/migration_tools/remove_unused_authorities.pl -c
6) Script runs like wanted
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fc4cffe1f0ac1379ddd1ce621189f1ef2d55d1fa
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Nov 19 15:19:46 2018 +0100
Bug 21865: ES compatiblity of remove_unused_authorities.pl
The script misc/migration_tools/remove_unused_authorities.pl directly checks if Zebra search is OK.
This patch changes so that this test is only if Zebra is the search engine.
It also adds a test on the search off any authority number indexed (index 'an').
With Zebra its : an,alwaysmatches=''
With ES its : an:*
This test ensure that biblios records are indexed and that not all autorities will be deleted.
Test plan:
1) On a catalog create a new authority
2) Use Zebra in systempreference SearchEngine
3) Stop Zebra server
4) Run misc/migration_tools/remove_unused_authorities.pl -c
5) The script does nothing and says :
Zebra server seems not to be available. This script needs Zebra runs.
6) Restart Zebra server
7) Delete biblio index base
8) Run misc/migration_tools/remove_unused_authorities.pl -c
9) The script does nothing and says :
Searching authority number in biblio records seems not to be available : an,alwaysmatches=''
10) Use ElasticSearch in systempreference SearchEngine
11) Delete biblio index base
12) Run misc/migration_tools/remove_unused_authorities.pl -c
13) The script does nothing and says :
Searching authority number in biblio records seems not to be available : an:*
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit bf60a9c88cd223e53acd1d8e58508eb6d1febbb5
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Nov 19 14:46:05 2018 +0100
Bug 21865: improve remove_unused_authorities.pl script
remove_unused_authorities.pl script can be improved.
This patch changes changes verbosity so than test mode can be used
to know the autorities that are used and those that can be deleted.
It also writes a line in output if limited authority type(s).
This patch also removes the unused vars $thresholdmin and $thresholdmax.
It also changes the query to use SQL with parameters for authority types.
Test plan :
1) On a catalog create a new authority
2) Be sure catalog is well indexed
3) Run misc/migration_tools/remove_unused_authorities.pl -t
4) You will see the line :
*** Testing only, authorities will not be deleted. ***
5) You will see lines of :
authid=x type=y : used X time(s)
6) You will see the line for the authority created in 1) :
authid=x type=y : can be deleted
7) You will see at the end :
x authorities parsed
y can be deleted because unused
z unchanged because used
8) Run misc/migration_tools/remove_unused_authorities.pl
9) You don't see the line :
*** Testing only, authorities will not be deleted. ***
10) You will see lines of :
authid=x type=y : used X time(s)
11) You will see the line for the authority created in 1) :
authid=x type=y : deleted
12) You will see at the end :
x authorities parsed
y deleted because unused
z unchanged because used
13) Run misc/migration_tools/remove_unused_authorities.pl --auth NP --auth CO
14) You see the line :
Restricted to authority type(s) : NP,CO.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fc29f2afa177fd3c497bcf5ec4bdb9299d396dc9
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Apr 14 16:52:49 2020 +0100
Bug 22774: DBRev 19.12.00.070
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f3e02aedf38b7f72207df5263c184d3e6af60f52
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Apr 13 20:28:06 2020 +0200
Bug 22774: (QA follow-up) Rephrase OPAC notes
I've changed the OPAC notes a little bit, main change is
the removal of the <b> tags used to highlight single words
in one sentence as they would result in splitting up the
sentence into multiple parts which makes proper translations really
hard.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 860264af6f6e3b51fb8b6eac4da25599c8568931
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Apr 13 20:11:00 2020 +0200
Bug 22774: (QA follow-up) Add syspref descriptions to database update and sysprefs.sql
Moves the updatedatabase entry to the new format and
adds information for the explanation column of the
systempreferences table.
Also slightly rephrases the description in the system preference
editor.
To test:
- Verify database update still works the same with addition
of explanations
- Verify the sys pref description makes sense
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 70ea3e39a883a4feb85f894e4fb25b59d21d5688
Author: Nazlı Çetin <nazli at devinim.com.tr>
Date: Mon Mar 23 13:30:48 2020 +0000
Bug 22774: (follow-up) Limit purchase suggestion in a specified time period
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 675ab180b098af15c2a24d90c1015a2291fd9126
Author: Devinim <kohadevinim at devinim.com.tr>
Date: Thu Jan 9 10:48:15 2020 +0000
Bug 22774: Limit Purchase Suggestion in a specified Time period
Test plan:
1 - Apply this patch
2 - Run updatedatabase.pl
3 - By default the preferences are blank and do not limit.
4 - Set the limits to 3 in 30 days
5 - Go to purchase suggestion page from OPAC as a logged in patron
6 - Place 3 suggestions and confirm you cannot place any more
7 - Alter one of the suggestions to have been made more than 30 days ago
UPDATE suggestions SET suggesteddate = '2020-01-01' WHERE suggestionid=3;
8 - Confirm you can place another suggestion
9 - Log out of OPAC
10 - Make sure AnonSyggestions is set to 'Allow' and AnonymousPatron is set
11 - Confirm anonymous suggestions are not limited by the syspref
12 - Confirm that a blank value in either MaxTotalSuggestions or NumberOfSuggestionDays does not limit suggestions
Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 294d6f54e5e57279168c042f76c209eb2b0e346e
Author: Nazlı Çetin <nazli at devinim.com.tr>
Date: Fri Feb 21 14:08:16 2020 +0000
Bug 22774: New systempreferences for suggestions added to sysprefs.sql
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b32c8fb91bf6c19124e7626a45191e3c50e0b73e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 15 19:38:29 2019 -0300
Bug 20728: Remove the 2 GetLastOrder* subroutines
At this point the 2 subroutines are no longer in used.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 91f9f8cdfd1ecbf56bbc4771d7c58cd9b468fc64
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 15 19:37:52 2019 -0300
Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent
There are 2 subroutines from C4::Acquisition that could be removed:
- GetLastOrderReceivedFromSubscriptionid
- GetLastOrderNotReceivedFromSubscriptionid
After bug 20726 only GetLastOrderReceivedFromSubscriptionid will be used
(from acqui/neworderempty.pl) and this call could be replaced easily with Koha::Acquisition::Orders
The code (+ tests) related to these 2 subroutines could then be removed.
The parameters for the search is basic and does no really deserve its own subroutine.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 220c4906bf1bc399e639d5bd1c2c84319c54e3b8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 15 19:24:19 2019 -0300
Bug 20728: Proof that there is no cheating
To make sure the replacing code will acchieve the same things as the
actual one, we replace the raw SQL query with the DBIC version of it.
Then the tests will show us that they are equivalent.
Test plan:
Apply only this patch, run the tests, confirm they pass.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 82244a30b75435ee7e37d07e499c49844732d941
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Apr 14 16:37:43 2020 +0100
Bug 23591: Compiled CSS
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f843e8be51edfd3f7d01e79d3d63bb1f389bc8f1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 19 17:35:09 2019 +0100
Bug 23591: Hide archived suggestions
However we are adding a note on top of the table to tell how many
suggestions are archived. It seems that there is no good reason to
display the archived suggestions on this table.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 97876fa76dc3f618e76c6ff246da68be197a74dd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 18 16:37:43 2019 +0100
Bug 23591: Use same css for suggestion notes
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6380c479b64ee78f6533312fc9c97530a843ac08
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 18 15:50:55 2019 +0100
Bug 23591: Display a new "Suggestion detail" tab on the bib detail page
This patch adds a new "Suggestion detail" tab on the bibliographic
detail page. It will help suggestion management.
Test plan:
- Create several suggestions for a given biblio
- Go to the detail page of the bibliographic record and confirm that
there is a new "Suggestion detail" tab with all the suggestions you
created.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 41e6f0447c00a817ff982ce70bbf98f78b968712
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 18 15:52:57 2019 +0100
Bug 23591: Add some useful methods to Koha::Suggestions
Those are methods initially written for bug 23991. I finally need them
before than expected.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f5b8b6b38c4db29ab66d5aeaf50eb6f1ab4e6e19
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Feb 17 17:21:03 2020 +0100
Bug 23596: (follow-up) Add missing use statement and set correct variable name
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6f6f68d55b0a2740fde5c75364c12736b00bd020
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Nov 8 15:50:57 2019 +0100
Bug 23596: Edit suggestion's reason when receiving
This patch displays and let the librarian edit the suggestion.reason
information when receiving an order.
Note that if no reason was given the edit is not possible (easily
modifiable if needed but it seems that we do not want to display too
much details unnecessarily)
Test plan:
- Create a suggestion and fill the reason
- Create an order from this suggestion
- Close the basket and start receiving the order
=> The reason is displayed and editable
- Modify the reason and click Save
- Receive again
=> The reason has been correctly modified
- Play with the "Others..." option and give a specific reason
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 468047c383536d802e1e02e3fefb2168dc9d27c7
Author: David Roberts <david at koha-ptfs.co.uk>
Date: Sat Apr 4 23:13:00 2020 +0000
Bug 25053: Clarify the description of syspref PatronSelfRegistrationExpireTemporaryAccountsDelay
This patch changes the wording of this system preference.
To test:
1) Check the current wording of this system preference.
2) Install the patch.
3) Check that the wording of this system preference has changed to "Delete patrons still in the category indicated by PatronSelfRegistrationDefaultCategory X days after account creation."
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 86db304cd45ad2fc2f59bde30ae261b18831e8c6
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Apr 14 16:25:31 2020 +0100
Bug 22784: DBRev 19.12.00.069
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e98e77bd7323876c45854280ab9788f01c41503c
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Apr 11 09:39:31 2020 +0000
Bug 22784: Fix small display issue with fa icon in suggestions table
The <i> was not closed resulting in the "Archived" displaying in
the wrong font. Might be a browser specific issue, but adding the
closing </i> fixed it and follows the existing pattern.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cd268bdbb2a9dfd2c70bc3f1fe1057b5860d06b4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 27 07:55:52 2020 +0100
Bug 22784: DBIC changes
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d6fc05891b5558fd5f2bb95c1fd200bcc43e2806
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Nov 14 16:41:40 2019 +0100
Bug 22784: Add a cronjob to archive suggestions given age or status criteria
In order to deal automatically with suggestions that need to be
archived, this cronjob will help to add the "archived" flag following
their age or status.
Test plan:
- Execute the script with the --help parameter and read the documentation.
- Does it make sense?
- Use it without the --confirm flag and try several combination
For instance you will want to archive suggestions that have been
rejected for more than a week:
perl misc/cronjobs/archive_purchase_suggestions.pl
--age-date-field=rejecteddate --age=weeks:1
or even suggestion that have been suggested for more than a year and
have a ORDERED status:
perl misc/cronjobs/archive_purchase_suggestions.pl
--age-date-field=suggesteddate --age=years:1 --status=ORDERED
- Use it with the --confirm flag and make sure the suggestions have been
archived.
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2d2ffbd075c95eb465fcc32c53b19f11d67cb4b6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 18 15:16:24 2019 +0100
Bug 22784: Do not display an empty table
This is terrible and highlight that the whole script must be rewrite.
GetDistinctValues does not handle the "archived" flag (and we do not
want to put our hands there), so let's hack that and plan to rewrite the
whole script.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 77b7014f883e4f48310c3e03ca56f50a6ffa60f2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 18 14:56:05 2019 +0100
Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d3a6cc48d0b7c6557d8d263580a96e1d87d79814
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Nov 13 16:34:56 2019 +0100
Bug 22784: Add the ability to archive/unarchive a purchase suggestions
There are performance issues when searching suggestions if there are
thousands of suggestions.
To prevent that we are going to add the ability to archive purchase
suggestions, in order to remove them from the search list (by default).
Test plan:
0. Apply all the patches, execute the updatedatabase.pl script, restart
all
1. Create some suggestions
2. Search for them
3. Use the "Archive" action button for one of them
4. Restart the search
=> The archived suggestion does no longer appear in the list
5. Use the filter "Included archived" in the "Suggestion information"
filter box
=> The archived suggestion is now displayed
6. Use other filters
=> The "archived" filter is kept from one search to another
7. Use one of the action at the bottom of the suggestion list (change
the status for instance)
=> The "archived" filter is still kept
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fd831a07883993e8437fa80cb631cff3d4ed27ed
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Nov 13 15:06:23 2019 +0100
Bug 22784: DB Changes
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6aee18111ed9c4efa92a242974c5ac439aa38880
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Jan 30 10:29:05 2020 -0500
Bug 24547: Add more action logs for holds
It seems like ModReserveFill and ModReserveAffect should both produce action logs for holds.
Test Plan:
1) Apply this patch
2) Place a hold
3) Check in the item to trap the hold
4) Check out the item to fill the hold
5) Check the action logs for that reserve id
6) Note the new logs!
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 65 -------
C4/Reserves.pm | 19 +-
C4/Suggestions.pm | 5 +
Koha.pm | 2 +-
Koha/Schema/Result/AuthorisedValue.pm | 20 ++-
Koha/Schema/Result/Suggestion.pm | 16 +-
Koha/Script.pm | 97 +++++++++++
Koha/Suggestion.pm | 62 ++++++-
Makefile.PL | 9 +
about.pl | 14 ++
acqui/finishreceive.pl | 9 +
acqui/neworderempty.pl | 15 +-
acqui/orderreceive.pl | 10 +-
admin/authorised_values.pl | 31 ++--
catalogue/detail.pl | 14 ++
debian/templates/koha-conf-site.xml.in | 1 +
etc/koha-conf.xml | 1 +
.../fr-FR/1-Obligatoire/authorised_values.sql | 1 -
installer/data/mysql/kohastructure.sql | 2 +
installer/data/mysql/sysprefs.sql | 2 +
installer/data/mysql/updatedatabase.pl | 57 ++++++
.../intranet-tmpl/prog/css/src/staff-global.scss | 12 ++
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 14 ++
.../prog/en/modules/acqui/orderreceive.tt | 54 +++++-
.../prog/en/modules/admin/authorised_values.tt | 2 -
.../prog/en/modules/admin/preferences/opac.pref | 12 +-
.../prog/en/modules/catalogue/detail.tt | 82 +++++++++
.../prog/en/modules/suggestion/suggestion.tt | 50 +++++-
.../bootstrap/en/modules/opac-suggestions.tt | 23 ++-
misc/cronjobs/archive_purchase_suggestions.pl | 193 +++++++++++++++++++++
misc/cronjobs/fines.pl | 14 ++
.../maintenance/search_for_data_inconsistencies.pl | 15 ++
misc/migration_tools/remove_unused_authorities.pl | 87 ++++++----
opac/opac-suggestions.pl | 23 ++-
suggestion/suggestion.pl | 22 ++-
t/Koha/Script.t | 40 ++++-
t/Koha/sleep.pl | 19 ++
t/Koha/wait.pl | 17 ++
t/db_dependent/Acquisition/OrderFromSubscription.t | 17 +-
t/db_dependent/Circulation.t | 43 ++++-
t/db_dependent/Koha/Suggestions.t | 63 ++++++-
42 files changed, 1086 insertions(+), 170 deletions(-)
create mode 100755 misc/cronjobs/archive_purchase_suggestions.pl
create mode 100755 t/Koha/sleep.pl
create mode 100755 t/Koha/wait.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list