[koha-commits] main Koha release repository branch master updated. v19.11.00-1850-gc42674cfd9

Tue Apr 21 14:01:06 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  c42674cfd98a2774881f48db5454bdb3392c57c8 (commit)
       via  3d022f0f27e3c2cfa42dbcad3b472acb5232fc71 (commit)
       via  c7d067667c4c2494505b736553b19150d1838464 (commit)
       via  8d306ff2ffb399a66e179e1d9e4cf45246dc83af (commit)
       via  49c15f06ac545a4374441076a7f8192f576b1f26 (commit)
       via  4a2cc4e9039dbeeb77d776ff8ae1099aa84fde30 (commit)
      from  e94ea221df93bb0bcbc3a2e90b4b8ff5daab761a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c42674cfd98a2774881f48db5454bdb3392c57c8
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Apr 21 12:33:47 2020 +0100

    Bug 24913: DBRev 19.12.00.078

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3d022f0f27e3c2cfa42dbcad3b472acb5232fc71
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Tue Apr 14 04:51:41 2020 +0000

    Bug 24913: Add PatronSelfRegistrationConfirmEmail syspref

    To test:
    1) update database, restart memcached/plack
    2) Go to Administration -> System preferences -> OPAC tab. Enable the
    new PatronSelfRegistrationConfirmEmail system preference. Enable other
    required self registration sysprefs.
    3) Go to the OPAC home page. (You may need to log out). Click the
    'Register' link so you are redirected to the member entry form.
    4) Notice the 'Confirm primary email' field after the 'primary email'
    field. Put 'a at a.com' in primary email, and 'b at b.com' in the confirm
    field. Scroll to the end of the form and Submit.
    5) Confirm the form is not successfully submitted, and an error message
    is shown to indicate the email addresses do not match.
    6) Confirm you cannot cut, copy or paste in either the primary email or
    confirm primary email fields. Confirm the right click menu doesn't work
    in these fields.

    7) Disable javascript in your browser.
    8) Repeat steps 3 and 4.
    9) Confirm there is an error message to indicate the email addresses do
    not match.

    10) Re-enable javascript. Fill in the form correctly with matching email
    addresses and confirm it successfully submits.

    11) Disable the PatronSelfRegistrationConfirmEmail syspref.
    12) Attempt to register an account on the OPAC again. Confirm the
    'confirm email address' field is gone and form works as expected.
    13) Re-enable the PatronSelfRegistrationConfirmEmail syspref.
    14) Log in to the OPAC and go to your personal details
    15) Edit the primary email field
    16) Confirm you are able to submit your changes (you should not see an
    error about emails not matching).

    Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
    Signed-off-by: holly <hc at interleaf.ie>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c7d067667c4c2494505b736553b19150d1838464
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Apr 20 08:37:10 2020 +0100

    Bug 25123: (QA follow-up) Re-used variable name

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8d306ff2ffb399a66e179e1d9e4cf45246dc83af
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 13 11:38:28 2020 +0000

    Bug 25123: Count the current fine when reducing for maxFine

    If maxFine is set, we total the patrons outstanding fines when making an adjustment, however, we neglect to count the amount of a currently updating fine when doing so.

    To test:
    1 - Set maxFine to 5
    2 - Create an overdue amount of 4.99 for a patron
    3 - Set an itemtype to have a fine of $.10 per day
    4 - Checkout an item of that type to a patron and backdate the due date so it is overdue
    5 - Run fines.pl with -v
    6 - Note the fine is reduced from $.10 (or a multiple) to .01
    7 - Run it again, a second cent is added
    8 - Repeat and note it keeps happening until the amount of the fine is reached, exceeding the maxFine setting
    9 - Apply patch
    10 - Note the fine is now reduced to 0 and nothing is added to account

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 49c15f06ac545a4374441076a7f8192f576b1f26
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 13 11:38:23 2020 +0000

    Bug 25123: Unit tests

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4a2cc4e9039dbeeb77d776ff8ae1099aa84fde30
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 12 22:06:05 2020 +0000

    Bug 14369: Only show 'Create labels' link on staged records import when status is imported

    The label creator won't be able to add a batch for items, if they are
    not imported into the database (missing itemnumber). This patch hides
    the link, when the status is not imported, to avoid the error situation.

    To test:
    - Export a record with items from your Koha installation
    - Delete items and record from Koha
    - Stage the record with the items - the "Create labels" link should be showing
    - Try to create the labels - note error
    - Apply patch
    - Retry - the link should no longer show
    - Import the records - the link should show now
    - Create labels again - a new batch should have been created
    - Verify the link on the batch # leads to the batch in the labels module

    Bonus: Moves the message from the .pl file to the template to make
    it translatable.

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Overdues.pm                                     |  1 -
 Koha.pm                                            |  2 +-
 installer/data/mysql/sysprefs.sql                  |  1 +
 installer/data/mysql/updatedatabase.pl             |  7 +++++
 .../prog/en/modules/admin/preferences/opac.pref    |  6 ++++
 .../prog/en/modules/tools/manage-marc-import.tt    | 16 ++++++++--
 .../bootstrap/en/modules/opac-memberentry.tt       | 34 ++++++++++++++++++++++
 opac/opac-memberentry.pl                           |  6 ++++
 t/db_dependent/Overdues.t                          | 32 +++++++++++++++++++-
 tools/manage-marc-import.pl                        |  4 +--
 10 files changed, 101 insertions(+), 8 deletions(-)

hooks/post-receive
-- 
main Koha release repository