[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-155-gc33f598c5c

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  c33f598c5cdea829390660419498e15f968f9abe (commit)
      from  3401e94d942a8d8a4e216ea44bd295f96b8f3e24 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c33f598c5cdea829390660419498e15f968f9abe
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 14 13:22:44 2020 +0200

    Bug 25142: Fix wrong grep logical test
    
    To test and understand what's going on, you can try that bit of code:
    my @a = qw( a b c a);
    my @b = qw( b c d );
    my @c;
    @c = grep { 'a' eq $_ } @a ? 'ok' : ();
    say @c;
    @c = ( grep { 'a' eq $_ } @a ) ? 'ok' : ();
    say @c;
    @c = grep { 'a' eq $_ } @a ? ('ok') : (undef);
    say @c;
    
    The problem here:
    Have patrons in 3 branches CPL, MPL, SPL
    Have a non superlibrarian with edit_borrowers permission but
    without view_borrower_infos_from_any_libraries, from CPL
    Create a library group with CPL, MPL
    Use that non superlibrarian to search for patrons
    You can search for patrons fro CPL and MPL
    BUT, edit the value for CPL, use SPL (edit the DOM)
    Search and... oops
    
    Apply this patch, try again
    
    Also use a superlibrarian patron (and/or with view_borrower_infos_from_any_libraries)
    and confirm that they can see all patrons
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Tested with edit_borrowers permission but NOT view_borrower_infos_from_any_libraries
    Editing the DOM I can search (not edit) from any branch
    With patch no entries found :)
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Amended test plan slightly (+ without)
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Utils/DataTables/Members.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository