[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-20-g300dbea812

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  300dbea81219245614d95599c7cd98c51a005242 (commit)
       via  96956fee2440f20a112bc1413253d6043ada704f (commit)
       via  6c962a7d5af5117fc7f858b2a78ddb818b679397 (commit)
       via  62b6e283a2c72d5e8c7f7f9a048df44fba2de8c3 (commit)
       via  b3d97ce0294bebd89c65830b1851cea5d936f0c4 (commit)
      from  1a20da353e6d96a121c7862b0920842c46769007 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 300dbea81219245614d95599c7cd98c51a005242
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 6 11:44:18 2020 +0200

    Bug 24964: [19.11.x] Do not fetch all patrons for owner/users of funds
    
    admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only
    retrieve patrons with acq (order_manage) permissions.
    
    The original bug was hidden in the existing code, but the behavior was
    terrible.
    To prevent patrons matching the permissions contrainst to be hidden, we
    fetched ALL the patrons from the DB, then filtered them depending on
    their permissions. This might have awful performance on DB with lot of
    patrons.
    
    So basically with this patch we are adding the pagination back to the
    "owner/users for funds" feature, as the permission filtering is now done
    at DB level.
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 96956fee2440f20a112bc1413253d6043ada704f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Mar 26 08:53:59 2020 -0400

    Bug 24964: [19.11.x] Fix perl critic warning
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 6c962a7d5af5117fc7f858b2a78ddb818b679397
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 25 13:50:45 2020 +0100

    Bug 24964: [19.11.x] Prevent random failures sorting by borrowernumber
    
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 62b6e283a2c72d5e8c7f7f9a048df44fba2de8c3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 25 11:21:15 2020 +0100

    Bug 24964: [19.11.x] Do not filter patrons after they have been fetched
    
    The svc/members/search script is called in different places.
    In some places (Set owner for a fund, add users to a fund, or set a
    manager to a suggestion), we need patrons to be filtered depending on
    the permissions they have.
    For instance you can only set a fund's owner with a patron that has
    acquisition.order_manage.
    
    Currently we have fetching X (default 20) patrons, then filter them
    depending on their permission.
    Says you have 3 patrons that have the correct permissions but are not in
    the 20 first patrons, if you do not define a search term, the search
    result will be empty.
    
    This is not ideal and we should filter when requesting the DB.
    
    Test plan:
    - Have more than 20 patrons, remove them their permissions
    - Create 3 more:
    1 superlibrarian
    1 with the full acq permission
    1 with acquisition.order_manage
    - Create a fund and set a owner
    - Search for patrons, without specifying a search term (to get them all)
    => Without this patch the new patrons you created are not displayed
    => With this patch they are!
    
    Same test plan apply to set a manager to a suggestion (freshly pushed,
    see bug 23590), with suggestions and suggestions.suggestions_manage
    
    Note: The code has been written that way to rely on
    C4::Auth::haspermission, but the SQL query is quite trivial and the gain
    is important.
    
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit b3d97ce0294bebd89c65830b1851cea5d936f0c4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 25 11:20:20 2020 +0100

    Bug 24964: [19.11.x] Add tests
    
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Utils/DataTables/Members.pm                     | 43 +++++++++++---
 .../prog/en/modules/common/patron_search.tt        |  8 +--
 svc/members/search                                 | 30 ++--------
 t/db_dependent/Utils/Datatables_Members.t          | 68 ++++++++++++++++++++--
 4 files changed, 106 insertions(+), 43 deletions(-)


hooks/post-receive
-- 
main Koha release repository