[koha-commits] main Koha release repository branch master updated. v19.11.00-1954-gcb390a35d6
Git repo owner
gitmaster at git.koha-community.org
Wed Apr 29 19:03:50 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via cb390a35d637d8f74cc7103ceff60f0a1a4283fc (commit)
via 7761051a831ffbe135b994ab3b67273e7bdaa63e (commit)
via afec0fb4997524cde1c2ac6ac0c0ab66f9c5d67b (commit)
via 9ea7fbcb30bf4b4879d4eb68c940316024c08760 (commit)
via f0cbb2063aa17b9832cc89bdd7a532d826dc48c8 (commit)
via e03e5a2ecee3c7c773e1cce418703a88cc53bb53 (commit)
via cad8d450356a0865ab52880b2e06e9e59e9f3db8 (commit)
via cfb73860dcc3ead3fc955ff55303c935aca1f04a (commit)
via 94097761d518c37afab52ab91f8149d3b45e29d8 (commit)
via 18ea57a92f9fefcb471e094a41b8b51a55a42711 (commit)
via 5fed21f065592073e197a062375332903073dba5 (commit)
via a51afd969819eb5fabc8a44d14992aa660c6664c (commit)
via 605d6c9b6ef6cb6ee3bd10a5d418ca9871f69e13 (commit)
via 3ecc5d59fe05c70b34a70afd788dc0a1b612f064 (commit)
via d37a3576f21a5eb1ad09efb1080e66fec452c1f6 (commit)
via ddad175f1131442b60513370b2cf00b0d87f1652 (commit)
via 256fe470fcf92e9732d7b65940756a99febb1693 (commit)
via 11bf5d7afaa92f129acca2644c6f69e0a7850093 (commit)
via 8cd362a422cba66a1728e7e7d083d0b1d390edb3 (commit)
via f6913e74c3b7aa7bfa3d76c4879c331daa1f108c (commit)
via 9fa6bb64014f6474e86846985609d8850e0839df (commit)
via feab2cbeb2179589c74524135bd2ff57b660a8e1 (commit)
via 76bf4dc056f0e234344045569fee2daa63ac2e45 (commit)
via 4249b20a394ea8f0addf0bcb162323a8f3cc27d5 (commit)
via 5fdd436558c4a9c84e4cfac2a4d6663ee41adc9a (commit)
via 985c8f1da93192622b9fdc6c9a1c410391bb983f (commit)
via 8b99b6525e876dc6a1e12a117c62ea41d1bf0e43 (commit)
via 738f8fe2a53b2679d15d1577d813fb072b162070 (commit)
from 0bb0b6c7b42428320603896233f45ea5f4af670c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit cb390a35d637d8f74cc7103ceff60f0a1a4283fc
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Apr 23 11:50:34 2020 +0000
Bug 25166: (follow-up) Update icons generated in JS
This patch adds aria attributes to Font Awesome icons generated by
JavaScript. The icons won't appear under normal circumstances because
the code for displaying the modal dialog should replace the icons with a
text label. The icons are a fallback.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7761051a831ffbe135b994ab3b67273e7bdaa63e
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Apr 15 23:14:15 2020 +0000
Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC
Font Awesome's accessibility guidelines
(https://fontawesome.com/v4.7.0/accessibility/) suggest that we include
'aria-hidden="true"' in the icon markup. This prevents screen
readers from trying to read the icon. This patch adds the attribute.
To test apply the patch and browse the OPAC looking for any problems
with icons: On search results, bibliographic details page, the cart,
lists, etc.
Check the source and verify that Font Awesome icons have the
"aria-hidden" attribute.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Attribute present, all looks good. The 'aria-label' attribute is
not translatable, but it's another problem.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit afec0fb4997524cde1c2ac6ac0c0ab66f9c5d67b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Apr 27 15:21:30 2020 +0000
Bug 25294: Don't show deletion button if user can't delete suggestions
This patch adds logic to the OPAC suggestions template so that when the
OPACViewOthersSuggestions system preference is enabled and the logged-in
user is viewing other users' suggestions, the "Delete selected" button
is only displayed when there are suggestions the user can delete.
To test you should have suggestions in your system from at least two
users.
- Set the OPACViewOthersSuggestions preference to "Show"
- Log in to the OPAC as a user who hasn't submitted any suggestions
- Go to the suggestions page (with "?suggested_by_anyone=1" appended to
the URL if necessary, see Bug 22515).
- In the table of suggetions, there should be no titles with a checkbox
in the first column.
- At the bottom of the table there should be no "Delete selected"
button.
- Log in to the OPAC as a user with suggestions.
- Return to the suggestions page and view all suggestions.
- There should be titles with corresponding checkboxes and the "Delete
selected" button should appear at the bottom.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9ea7fbcb30bf4b4879d4eb68c940316024c08760
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Mar 27 23:35:51 2020 +0000
Bug 25002: JS Includes should be wrapped with template comments
This patch adds HTML comments to Template::Toolkit include files which
contain <script> tags so that it is clear where the embedded scripts can
be found in the code.
To test, apply the patch and view source on the following pages to
verify the presence of the comments:
Acquisitions home page:
- acquisitions-toolbar.inc
- validtor-strings.inc
- js_includes.inc
- format-price.inc
Acquisitions -> Add order from new record,
Acquisitions -> Receive order:
- additem.js.inc
Cataloging -> Add/Edit item:
- columns_settings.inc
- strings.inc
- select2.inc
- calendar.inc
- str/cataloging_additem.inc
Authorities home page:
- authorities_js.inc
Bibliographic detail page:
- catalog-strings.inc
Cataloging -> Advanced editor:
- cateditor-ui.inc
- cateditor-widgets-marc21.inc
Administration -> Item types:
- greybox.inc
ILL requests:
- ill-list-table-strings.inc
Web installer
- installer-intranet-bottom.inc
Web installer -> Onboarding
- installer-strings.inc
Lists -> List contents -> Merge records
- merge-record-strings.inc
Patrons -> Patron -> Change password
- password_check.inc
- str/members-menu.inc
Patrons -> Patron -> Print summary
- slip-print.inc
Circulation -> Check out
- timepicker.inc
Administration -> System preferences:
- str/tinymce_i18n.inc
- wysiwyg-systempreferences.inc
Cataloging -> Z39.50 Search:
- z3950_search.inc
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f0cbb2063aa17b9832cc89bdd7a532d826dc48c8
Author: Andreas Roussos <a.roussos at dataly.gr>
Date: Wed Apr 15 09:46:50 2020 +0200
Bug 25149: Fix Zebra language code for Greek
According to the list of two-letter language codes found in ISO 639-1
(https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes), the correct
Zebra language option for Greek should be 'el', not 'gr'.
This patch fixes that.
Test plan:
0) Apply the patch.
1) Confirm that 'gr' has been changed to 'el' in all relevant files.
2) Create a new Koha instance using `koha-create --zebralang el testinst1`.
3) Edit /etc/koha/koha-sites.conf and set ZEBRA_LANGUAGE to 'el'. Then,
create another Koha instance with `koha-create testinst2`.
4) Confirm that both instances created in steps 2) and 3) have picked up
the Zebra CHR file from the /etc/koha/zebradb/lang_defs/el/ directory.
This is done by inspecting the value of 'profilePath' in these files:
/etc/koha/sites/testinst{1,2}/zebra-authorities-dom.cfg
/etc/koha/sites/testinst{1,2}/zebra-biblios-dom.cfg
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e03e5a2ecee3c7c773e1cce418703a88cc53bb53
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Mar 19 12:04:39 2020 -0300
Bug 24908: Add text-formatted MARC support in /biblios/{biblio_id}
This patch makes the route support requesting (through the Accept
header) the MARC record to be output as formatted text as in
$record->as_formatted.
To test:
1. Apply the unit tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/biblios.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Try the route with your favourite API testing tool (Postman?)
=> SUCCESS: Accept: text/plain returns the expected results
=> SUCCESS: Wrong Accept header returns a list of valid formats, and
includes 'text/plain'.
6. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cad8d450356a0865ab52880b2e06e9e59e9f3db8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Mar 19 12:04:27 2020 -0300
Bug 24908: Unit tests
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cfb73860dcc3ead3fc955ff55303c935aca1f04a
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Apr 29 17:11:35 2020 +0100
Bug 22630: Schema Update
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 94097761d518c37afab52ab91f8149d3b45e29d8
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Apr 29 17:11:13 2020 +0100
Bug 22630: DBRev 19.12.00.081
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 18ea57a92f9fefcb471e094a41b8b51a55a42711
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Apr 27 06:23:59 2020 +0000
Bug 22630: Fix capitalization
Home Library -> Home library
Holding Library -> Holding library
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5fed21f065592073e197a062375332903073dba5
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Apr 24 11:01:46 2020 +0200
Bug 22630: Set is_boolean flag for course_items.homebranch_enabled
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a51afd969819eb5fabc8a44d14992aa660c6664c
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Apr 24 10:58:07 2020 +0200
Bug 22630: Update Koha::Schema::Result::CourseItem
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 605d6c9b6ef6cb6ee3bd10a5d418ca9871f69e13
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Apr 3 14:49:00 2019 +0200
Bug 22630: Allow to change homebranch in course reserves
Test plan:
1. Create a course (disabled)
2. Add a reserve to this course for an item and set a homebranch
different from the item's homebranch
3. Enable the course
4. Verify that the item's homebranch has changed
5. Disable the course
6. Verify that the item's homebranch was reset to its initial value
7. prove t/db_dependent/CourseReserves/CourseItems.t
Sponsored-by: Université de Lyon 3
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3ecc5d59fe05c70b34a70afd788dc0a1b612f064
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Apr 25 23:06:05 2020 +0000
Bug 25110: (QA follow-up) Add aria-hidden="true" to FA icons
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d37a3576f21a5eb1ad09efb1080e66fec452c1f6
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Apr 14 16:31:28 2020 +0000
Bug 25110: Allow patrons to add star ratings to titles on their summary/checkout page
This patch adds the ability for logged-in patrons to add star ratings to
titles in their list of current checkouts and on the reading history
page.
The reading history page previously only showed existing ratings. Now it
will allow the entry of ratings as well.
The JS and markup for the feature are in separate include files to
facilitate re-use. It includes markup for non-js display of ratings and
js-driven ratings controls.
To test, apply the patch and set the OpacStarRatings to all, "results,
details, and user" pages.
- Log in to the OPAC as a user with checkouts.
- On the "your summary" page, test the features of setting star
ratings:
- Any title with existing ratings should show the rating and the
average rating number.
- Set a rating. Confirm that it shows a message with your rating.
- Click the "cancel rating" link, and confirm that your rating is
removed.
- Set a rating and reload the page. Confirm that the rating was
saved.
- Test the "cancel rating" link on the title you set before you
reloaded the page. The rating should be cancelled.
- Test the same functionality on the "your reading history" page.
- Test these pages with the OpacStarRatings preference set to "only
details" or "no." The pages should function correctly.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ddad175f1131442b60513370b2cf00b0d87f1652
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Apr 24 18:29:21 2020 +0000
Bug 25281: Use modal confirmation when deleting a list in the OPAC
This patch modifies the process of deleting a list in the OPAC so that
the deletion confirmation alert is replaced with a Bootstrap modal.
In the process, I moved the repeated deletion form markup into a block
To test, apply the patch and log in to the OPAC as a user who has
multiple lists, including some which have been shared with other users.
Go to the list of your lists and click the "Delete" link next to any of
your lists. It should trigger a confirmation modal:
- The modal should show the title of the list you're deleting.
- If the list has titles on it, it show how many.
- If the list has been shared with someone it should say so.
Next, view a list which is not empty.
- Test the "Delete list" link in the toolbar.
- You should see the same information in the confirmation message as in
the previous step.
Do the same with a list which is empty.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 256fe470fcf92e9732d7b65940756a99febb1693
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Apr 24 14:48:21 2020 +0000
Bug 25280: Use modal confirmation when removing share from a list in the OPAC
This patch updates the process of removing a share from a list in the
OPAC so that the confirmation request shown to the user is a Bootstrap
modal instead of a plain JavaScript confirm dialog.
To test you should have the OpacAllowSharingPrivateLists enabled.
- Log in to the OPAC as a user who has multiple private lists.
- Share two or more lists with another user in the system.
- Accept the list shares on behalf of the other user and log in to the
OPAC as that user.
- In the list of that user's lists, test the process of removing a
share:
- Clicking "Remove share" should trigger a modal which asks if you
want to remove sharing. It should show the name of the list in
question.
- Test the funcionality of both the "No" and "Yes" options.
- Confirm that the "Remove share" button works correctly for any of
multiple lists.
- View the contents of a list which has been shared with this user.
- Test the "Remove share" button at the top of the list's contents.
- The same confirmation dialog should be triggered.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 11bf5d7afaa92f129acca2644c6f69e0a7850093
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 15 16:38:16 2020 +0200
Bug 23137: Move cache flushing to the method
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8cd362a422cba66a1728e7e7d083d0b1d390edb3
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Apr 14 10:14:00 2020 +0000
Bug 23137: Add documentation
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f6913e74c3b7aa7bfa3d76c4879c331daa1f108c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Mar 19 16:37:24 2020 +0000
Bug 23137: Add reset and delete to koha-elasticsearch
Same as previous test, but use the script to run the reindex
reset_all to update the scripts or use
misc4dev/cp_debian_files.pl
sudo koha-elasticsearch --rebuild -r -v
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9fa6bb64014f6474e86846985609d8850e0839df
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Mar 19 16:30:29 2020 +0000
Bug 23137: Add reset option to rebuild_elasticsearch.pl
Setup:
1 - Be using Elasticsearch
2 - Reload mappings from the db
Admin->Search configuration
Reset Mappings
3 - Reindex ES and confirm searching is working
To test:
1 - Apply patch
2 - Alter your mappings file for elastic (just change a description for a field)
3 - perl misc/search_tools/rebuild_elasticsearch.pl -r -v
Verbose not necessary, but good for letting you know things are progressing
4 - Confirm the mapping change shows in the interface
5 - Confirm reindex worked and searching is working
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit feab2cbeb2179589c74524135bd2ff57b660a8e1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 15 16:15:33 2020 +0200
Bug 21294: Replace BOOLEAN with TINYINT(1) in our DB structure
To match the coding guideline SQL12.
We do this for consistency.
Note that we do not need an update DB as BOOLEAN is an alias for
TINYINT(1).
The is_boolean flags have been added to the schema.
Test plan:
1. `dbic` should run correctly
2. kohastructure.sql should be syntaxicaly correct
3. `git grep -i boolean installer/data/mysql/kohastructure.sql`
should not return relevant occurrences.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 76bf4dc056f0e234344045569fee2daa63ac2e45
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Feb 21 16:07:23 2020 +0100
Bug 22828: Add tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 4249b20a394ea8f0addf0bcb162323a8f3cc27d5
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu May 2 11:27:27 2019 +0000
Bug 22828: Elasticsearch - display errors encountered during indexing on the command line
To test:
1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest way is using advanced cataloging editor
2 - Reindex elasticsearch
3 - Check the ES count on the about page
4 - Check the count in the DB (SELECT count(*) FROM biblio)
5 - They don't match!
6 - perl misc/search_tools/rebuild_elastic_search.pl -v -v
7 - No errors indicated
8 - Apply patch
9 - perl misc/search_tools/rebuild_elastic_search.pl -v
10 - You should be notified of an error
11 - perl misc/search_tools/rebuild_elastic_search.pl -v -v
12 - You should be notified of the specific biblio with an error and a (somewhat) readable reason
13 - perl misc/search_tools/rebuild_elastic_search.pl
14 - No output
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5fdd436558c4a9c84e4cfac2a4d6663ee41adc9a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 24 12:45:04 2020 +0200
Bug 23495: Fix if no sms provider defined
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 985c8f1da93192622b9fdc6c9a1c410391bb983f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Apr 23 18:50:18 2020 +0000
Bug 23495: Add SMS provider to moremember.tt
To test:
1 - Enable SMS using the Email driver
2 - Add an SMS provider under admimistration
3 - Add an SMS number and provider to a patron
4 - Note on the patron details you don't see the provider :-(
5 - Apply patch
6 - Reload
7 - Note you do see the provider :-)
8 - prove t/db_dependent/Koha/Patrons.t
9 - Sign off!
Signed-off-by: Lisette <lisetteslatah at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8b99b6525e876dc6a1e12a117c62ea41d1bf0e43
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Apr 21 21:19:49 2020 +0000
Bug 25234: Update OPAC search results pagination with aria labels
This patch updates the include file which generates OPAC search results
pagination so that it has better semantic markup and correct aria
labels.
To test, apply the patch and do a search in the OPAC which will return
multiple pages of search results.
View the source to confirm the markup changes:
- <nav> instead of <div> surrounding the list of links, with a
corresponding aria label
- Navigation links should have labels indicating which page in the
results they point to.
- The current link should have "aria-disabled," and "aria-current" set.
- Numbered links should have aria labels that indicate their number.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 738f8fe2a53b2679d15d1577d813fb072b162070
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Apr 21 17:30:00 2020 +0000
Bug 25231: Rename button instead of alert/confirm when replacing record
This test plan applies to the basic editor only
To test:
1 - Edit an existing record
2 - Click 'Z3950 Search'
3 - Note the confirmation box
4 - Add a new record
5 - Click 'Z3950 Search'
6 - Note no popup
7 - Apply patch
8 - Edit existing record
9 - Note button now says 'Replace record via Z3950 search'
10 - Add a new blank record
11 - Note the button says 'Z3950 search'
12 - Confirm editing/saving/replacing works as in the past
Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/CourseReserves.pm | 11 +-
Koha.pm | 2 +-
Koha/Patron.pm | 13 +++
Koha/REST/V1/Biblios.pm | 8 +-
Koha/Schema/Result/Aqcontact.pm | 8 ++
Koha/Schema/Result/Branch.pm | 34 +++++-
Koha/Schema/Result/CourseItem.pm | 71 +++++++++++-
Koha/Schema/Result/EdifactMessage.pm | 3 +
Koha/Schema/Result/OldReserve.pm | 6 ++
Koha/Schema/Result/SavedSql.pm | 4 +
Koha/Schema/Result/SearchMarcToField.pm | 6 +-
Koha/Schema/Result/Subscription.pm | 3 +-
Koha/SearchEngine/Elasticsearch.pm | 7 ++
Koha/SearchEngine/Elasticsearch/Indexer.pm | 6 +-
Makefile.PL | 2 +-
admin/searchengine/elasticsearch/mappings.pl | 13 +--
api/v1/swagger/paths/biblios.json | 3 +-
course_reserves/add_items.pl | 4 +
debian/docs/koha-create.xml | 2 +-
debian/docs/koha-elasticsearch.xml | 15 +++
debian/scripts/koha-create | 2 +-
debian/scripts/koha-elasticsearch | 16 +++
debian/templates/koha-sites.conf | 2 +-
.../lang_defs/{gr => el}/sort-string-utf.chr | 0
installer/data/mysql/kohastructure.sql | 41 +++----
installer/data/mysql/updatedatabase.pl | 44 ++++++++
.../prog/en/includes/acquisitions-toolbar.inc | 2 +
.../intranet-tmpl/prog/en/includes/additem.js.inc | 2 +
.../prog/en/includes/authorities_js.inc | 2 +
.../intranet-tmpl/prog/en/includes/calendar.inc | 2 +
.../prog/en/includes/catalog-strings.inc | 2 +
.../prog/en/includes/cateditor-ui.inc | 2 +
.../prog/en/includes/cateditor-widgets-marc21.inc | 3 +-
.../prog/en/includes/columns_settings.inc | 3 +-
.../prog/en/includes/format_price.inc | 2 +
.../intranet-tmpl/prog/en/includes/greybox.inc | 2 +
.../prog/en/includes/ill-list-table-strings.inc | 2 +
.../prog/en/includes/installer-intranet-bottom.inc | 2 +
.../prog/en/includes/installer-strings.inc | 2 +
.../prog/en/includes/js-date-format.inc | 2 +
.../intranet-tmpl/prog/en/includes/js_includes.inc | 9 ++
.../prog/en/includes/merge-record-strings.inc | 2 +
.../prog/en/includes/password_check.inc | 2 +
.../intranet-tmpl/prog/en/includes/select2.inc | 2 +
.../intranet-tmpl/prog/en/includes/slip-print.inc | 2 +
.../prog/en/includes/str/cataloging_additem.inc | 2 +
.../prog/en/includes/str/members-menu.inc | 3 +-
.../prog/en/includes/str/tinymce_i18n.inc | 4 +-
.../intranet-tmpl/prog/en/includes/strings.inc | 2 +
.../intranet-tmpl/prog/en/includes/timepicker.inc | 2 +
.../prog/en/includes/validator-strings.inc | 2 +
.../prog/en/includes/wysiwyg-systempreferences.inc | 3 +-
.../prog/en/includes/z3950_search.inc | 2 +
.../prog/en/modules/admin/preferences/opac.pref | 2 +-
.../prog/en/modules/cataloguing/addbiblio.tt | 15 ++-
.../en/modules/course_reserves/add_items-step2.tt | 26 +++++
.../en/modules/course_reserves/course-details.tt | 23 +++-
.../prog/en/modules/members/moremember.tt | 4 +
.../bootstrap/en/includes/holds-table.inc | 14 +--
.../bootstrap/en/includes/masthead-langmenu.inc | 6 +-
.../bootstrap/en/includes/masthead-sco.inc | 2 +-
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 16 +--
.../bootstrap/en/includes/opac-detail-sidebar.inc | 24 ++---
.../bootstrap/en/includes/page-numbers.inc | 32 ++++--
.../bootstrap/en/includes/shelfbrowser.inc | 4 +-
.../bootstrap/en/includes/title-actions-menu.inc | 24 ++---
.../bootstrap/en/includes/user-star-ratings.inc | 53 +++++++++
.../bootstrap/en/modules/clubs/clubs-tab.tt | 4 +-
.../bootstrap/en/modules/opac-ISBDdetail.tt | 6 +-
.../bootstrap/en/modules/opac-MARCdetail.tt | 6 +-
.../opac-tmpl/bootstrap/en/modules/opac-account.tt | 6 +-
.../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 22 ++--
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 40 +++----
.../bootstrap/en/modules/opac-illrequests.tt | 8 +-
.../opac-tmpl/bootstrap/en/modules/opac-main.tt | 2 +-
.../bootstrap/en/modules/opac-readingrecord.tt | 28 ++---
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 16 +--
.../bootstrap/en/modules/opac-search-history.tt | 8 +-
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 120 ++++++++++++++-------
.../bootstrap/en/modules/opac-showreviews.tt | 2 +-
.../bootstrap/en/modules/opac-suggestions.tt | 10 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 18 +++-
.../opac-tmpl/bootstrap/en/modules/sci/sci-main.tt | 4 +-
.../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 14 +--
koha-tmpl/opac-tmpl/bootstrap/js/global.js | 6 +-
koha-tmpl/opac-tmpl/bootstrap/js/ratings.js | 46 ++++++++
koha-tmpl/opac-tmpl/bootstrap/js/script.js | 4 +-
misc/search_tools/rebuild_elasticsearch.pl | 51 ++++++++-
opac/opac-user.pl | 7 ++
t/db_dependent/CourseReserves/CourseItems.t | 16 ++-
t/db_dependent/Koha/Patrons.t | 11 +-
.../Koha/SearchEngine/Elasticsearch/Indexer.t | 7 +-
.../Koha/SearchEngine/Elasticsearch/Reset.t | 11 +-
t/db_dependent/api/v1/biblios.t | 10 +-
95 files changed, 860 insertions(+), 265 deletions(-)
rename etc/zebradb/lang_defs/{gr => el}/sort-string-utf.chr (100%)
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/includes/user-star-ratings.inc
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/js/ratings.js
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list