[koha-commits] main Koha release repository branch master updated. v19.11.00-1964-g46f5b1ff21

Wed Apr 29 20:34:24 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  46f5b1ff21b1ee516ced8cd199d2e14ce189b950 (commit)
       via  25c8f087cbca8c3e39e973f3dca10590ea660bd1 (commit)
       via  e289e400789d2ba6f00004b65564f1201f39f191 (commit)
       via  4805b9b9dd0a95d79faf450ed1aaaec62d544ec6 (commit)
       via  7acc0637093dbb569dc89d1a848114dc010997cd (commit)
       via  be67b8c18ed726f0887e36b54a4a13942da0504b (commit)
       via  fce7094c297acd57f22b99c06d8ae97af04f5596 (commit)
       via  78badbdad7be1531c4be2f72c9dd67f2b6236e13 (commit)
       via  5cb03c39600b455d4848216da24db501b3e15179 (commit)
       via  9aa4a0d65affb029cb206d756bab592659aefd90 (commit)
      from  cb390a35d637d8f74cc7103ceff60f0a1a4283fc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 46f5b1ff21b1ee516ced8cd199d2e14ce189b950
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 29 15:47:27 2020 +0200

    Bug 25303: Effectively delete the city to avoid endless loop

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 25c8f087cbca8c3e39e973f3dca10590ea660bd1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 28 14:37:43 2020 +0200

    Bug 25303: Make Koha::Objects->delete loop on the object set

    If we call Koha::Libraries->delete but Koha::Library->delete exists
    (ie. Koha::Object->delete is overridden), then we Koha::Objects->delete
    will be called and the overridden will not be executed.

    This patch suggests to test if the method is overridden (using
    Class::Inspector->function_exists). If so we loop on the different
    objects of the set in a transaction and call the overridden ->delete method.

    Existing tests widely cover this change.
    t/db_dependent/Koha/Objects.t
        subtest 'Return same values as DBIx::Class' => sub {

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e289e400789d2ba6f00004b65564f1201f39f191
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Apr 28 11:31:28 2020 -0300

    Bug 25303: Unit tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4805b9b9dd0a95d79faf450ed1aaaec62d544ec6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Apr 29 09:28:04 2020 -0300

    Bug 25296: Make ->empty work for uninstantiated calls

    In OO we would usually instantiate the class and then interact with it
    like in:
        my $rs = Koha::Patrons->new;
        $rs->empty;

    Koha's practice is to call things like Koha::Patrons->search without
    instantiating the Koha::Patrons class. To keep consistency, this patch
    instantiates the resultset object on behalf of the caller if required.

    To test:
    1. Apply the tests patch
    2. Run:
       $ kshell
      $k prove t/db_dependent/Koha/Objects.t
    => FAIL: Tests fail because it is expected to have the class
    instantiated
    3. Apply this patch
    4. Repeat 2.
    => SUCCESS: Tests pass, instantiation happens implicitly.
    5. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7acc0637093dbb569dc89d1a848114dc010997cd
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Apr 29 09:27:22 2020 -0300

    Bug 25296: Tests for uninstantiated behaviour

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit be67b8c18ed726f0887e36b54a4a13942da0504b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Apr 27 18:33:05 2020 -0300

    Bug 25296: Add a way to force an empty Koha::Objects resultset

    This patch adds a new ->empty method to Koha::Objects, that can be used
    to make the underlying DBIC resultset empty. This way, we can have
    consistency in our method's return values without the need to build
    a query that we know in advance that will be empty. No need to hit the
    DB at all.

    To test:
    1. Apply this patches
    2. Notice the tests cover what is expected
    3. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Objects.t
    => SUCCESS: Tests pass! Yay!
    4. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fce7094c297acd57f22b99c06d8ae97af04f5596
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Apr 27 18:32:50 2020 -0300

    Bug 25296: Unit tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 78badbdad7be1531c4be2f72c9dd67f2b6236e13
Author: George Veranis <gveranis at dataly.gr>
Date:   Wed Apr 22 13:53:56 2020 +0200

    Bug 19313: Fix typo in in unimarc_field_130.pl value builder

    This patch fixes a simple typo

    Test plan:
    1) Go to Administration -> MARC bibliographic framework
    2) Select a framework and add plugin unimarc_field_130.pl to 130 field
    3) Open cataloguing screen
    4) Go to 130 field and check if for subfield a shows value for
       'unknown' select it and close the window, check on value on 130$a at
       position 8 to have the value 'd'.
    5) Repeat step 4 and select the value 'mixed emulsion' close the plugin
       window and check at position 8 to have the value 'u'
    6) Apply the patch
    7) Go to field 130, open the plugin window and select value 'unknown'
       close the window and check at position 8 to have the value 'u'
    8) Go to field 130, open the plugin window and select value 'mixed
       emulsion', close the window and check at position 8 to have the
       value 'v'

    https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_130_update2017.pdf

    Mentored-by: Andreas Roussos
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5cb03c39600b455d4848216da24db501b3e15179
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Apr 29 18:57:47 2020 +0100

    Bug 25271: Compiled CSS

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9aa4a0d65affb029cb206d756bab592659aefd90
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Apr 24 00:51:35 2020 +0000

    Bug 25271: Add floating toolbar to OPAC cart

    This patch adds JavaScript to the OPAC cart view so that the toolbar at
    the top of the display "floats" as you scroll down.

    The patch also makes a minor correction to the OPAC SCSS affecting the
    display of the buttons in the cart toolbar.

    To test, apply the patch and rebuild the OPAC CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

     - Add some items to a cart in the OPAC.
     - Open the cart and confirm that the toolbar sticks to the top of the
       window as you scroll down.
     - Confirm that it works in the "More details" view.
     - Confirm that other JavaScript-based operations are not affected:
       table sorting and all the various toolbar buttons.

    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Objects.pm                                    | 46 +++++++++++++++++-
 .../cataloguing/value_builder/unimarc_field_130.tt | 12 ++---
 koha-tmpl/opac-tmpl/bootstrap/css/opac.css         |  2 +-
 .../opac-tmpl/bootstrap/css/src/_responsive.scss   |  2 +-
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss    |  5 --
 .../opac-tmpl/bootstrap/en/modules/opac-basket.tt  |  9 ++++
 t/db_dependent/Koha/Objects.t                      | 55 +++++++++++++++++++++-
 7 files changed, 115 insertions(+), 16 deletions(-)

hooks/post-receive
-- 
main Koha release repository