[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.13-31-g296524c978

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  296524c9784145301eba713d4f5ffdc59d724577 (commit)
       via  416528064eb4e1e3015c6303b5880d53154e0792 (commit)
       via  c3ad074be492b705fe2f16a2d2fb7d34e054f96e (commit)
      from  ab03647466597bdfb6ed34efbf6083b1de412c83 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 296524c9784145301eba713d4f5ffdc59d724577
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date:   Tue Dec 17 13:59:55 2019 +0000

    Bug 24016: (QA follow-up) Format code to adhere to perltidy format
    
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 3bfbf2589788474f0d37acc5d6df2d1fc7cc0005)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 8ecc071915c4117a712d6b03cd34f6d20f9a0cb8)
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

commit 416528064eb4e1e3015c6303b5880d53154e0792
Author: Lari Taskula <lari.taskula at hypernova.fi>
Date:   Tue Nov 12 12:18:27 2019 +0000

    Bug 24016: manager_id in Koha::Patron::Message->store should not depend on userenv alone
    
    Koha::Patron::Message->store has this
    
        my $userenv = C4::Context->userenv;
        $self->manager_id( $userenv ? $userenv->{number} : undef);
    
    This breaks in REST API when userenv is not set.
    
    Let API user pass manager_id without relying on C4::Context->userenv.
    
    To test:
    1. prove t/db_dependent/Koha/Patron/Messages.t
    2. Observe success
    
    Sponsored-by: Koha-Suomi Oy
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 49eac22b1f977b439e5d3f8f313dee3164719b60)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit e13770ad11b4b504413ef020770cd15e8ee55bbc)
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

commit c3ad074be492b705fe2f16a2d2fb7d34e054f96e
Author: Lari Taskula <lari.taskula at hypernova.fi>
Date:   Tue Nov 12 12:24:30 2019 +0000

    Bug 24016: Add a failing test for overwrite-able manager_id in Koha::Patron::Message
    
    To test:
    1. prove t/db_dependent/Koha/Patron/Messages.t
    2. Observe failure
    
    t/db_dependent/Koha/Patron/Messages.t .. 2/12
       Failed test 'Manager id should be overwrite-able even if defined in userenv'
       at t/db_dependent/Koha/Patron/Messages.t line 90.
              got: '1100'
         expected: '1101'
     Looks like you failed 1 test of 12.
    t/db_dependent/Koha/Patron/Messages.t .. Dubious, test returned 1 (wstat 256, 0x100)
    Failed 1/12 subtests
    
    Sponsored-by: Koha-Suomi Oy
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit c74820c2273393825c73b90769424544579a1aae)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 3d73723a9ff618d2d7b5685ce2ac969b27899d31)
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Patron/Message.pm                |  6 ++++--
 t/db_dependent/Koha/Patron/Messages.t | 26 +++++++++++++++++++-------
 2 files changed, 23 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository