[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.13-32-gb6a6bfb9fb

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  b6a6bfb9fb346ffaf29f05b6283fa7173af3620f (commit)
      from  296524c9784145301eba713d4f5ffdc59d724577 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b6a6bfb9fb346ffaf29f05b6283fa7173af3620f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Dec 27 14:55:36 2019 +0100

    Bug 24313: Always display XSLT errors in logs
    
    From
      commit 295ae33800a322facfdf56795f4c02b2fd53432b
      Bug 20272: Replace error numbers by codes in XSLT_Handler
    
    """
        Make XSLT_Handler a little bit less noisy by defaulting print_warns to
        false unless $ENV{DEBUG} is set. (See also bug 19018).
    """
    
    I think we should warn the errors in the logs. They are not debug messages here, we should not rely on DEBUG.
    If too noisy we should fix the original issues, not hide all the errors (which make the XSLT debugging super hard)
    
    Test plan:
    Break a XSLT, reload the page and confirm that there are useful errors in the Koha log file
    
    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit ec79582374c829049ebac891644fb9f6e30a9614)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 8bcafbe3cfa15974b34c8bb8dc9d10f72205283e)
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 Koha/XSLT_Handler.pm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository