[koha-commits] main Koha release repository branch master updated. v19.11.00-187-gb8c0a38

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  b8c0a387c858c011d193f1023b75285a05dc0383 (commit)
       via  276b64692520108431c539b4d9124b3371129419 (commit)
       via  c66637670b4fa084438925d3e9a4bfa8e0275ef2 (commit)
      from  7514ecb6c99851e9334875973a8085b6447fb2b9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b8c0a387c858c011d193f1023b75285a05dc0383
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jan 7 16:06:38 2020 +0100

    Bug 21684: Fix Hold.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 276b64692520108431c539b4d9124b3371129419
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jan 7 13:30:32 2020 +0100

    Bug 21684: Koha::Object->delete must return a Koha::Object
    
    Not a DBIx::Class object.
    
    Tests have been added, add Bookseller.t fixed
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c66637670b4fa084438925d3e9a4bfa8e0275ef2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jan 7 12:10:05 2020 +0100

    Bug 21684: Fix UploadedFile[s]->delete
    
    Tests were failing with:
     #   Failed test 'Test delete via UploadedFile as well as UploadedFiles'
     #   at t/db_dependent/Upload.t line 193.
     DBIx::Class::Row::delete(): Not in database at /kohadevbox/koha/Koha/Object.pm line 219
    
    I am not sure this patch is perfect, a set of uploaded files should be
    deleted in a transaction, which would be rollback if something is wrong.
    But it will be tricky to restore the files after they have been deleted.
    It seems that we should deal with that with a more complicated process
    and should be part of a separate bug.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Object.pm                |    7 ++++++-
 Koha/UploadedFile.pm          |    7 -------
 Koha/UploadedFiles.pm         |    8 ++++----
 t/db_dependent/Bookseller.t   |    2 +-
 t/db_dependent/Hold.t         |    4 ++--
 t/db_dependent/Koha/Objects.t |    7 +++++--
 t/db_dependent/Upload.t       |   21 ++++++++++++---------
 7 files changed, 30 insertions(+), 26 deletions(-)


hooks/post-receive
-- 
main Koha release repository