[koha-commits] main Koha release repository branch master updated. v19.11.00-188-gba892d3

Git repo owner gitmaster at git.koha-community.org
Tue Jan 7 18:26:27 CET 2020


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  ba892d39d2e197cc9fad942ac5202d0706ef505f (commit)
      from  b8c0a387c858c011d193f1023b75285a05dc0383 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ba892d39d2e197cc9fad942ac5202d0706ef505f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 6 22:10:16 2020 +0100

    Bug 24350: Fix Branches.pickup_locations
    
    This will fix the following error:
    Template process failed: undef error - Not a HASH reference at
    /home/vagrant/kohaclone/Koha/Template/Plugin/Branches.pm line 96.
     at /home/vagrant/kohaclone/C4/Templates.pm line 122
    
    Koha::Libraries->pickup_locations does not always return an array, but
    arrayref if $biblio is not a Koha::Biblio object.
    
    I do not think it's the correct fix, the pattern in
    Koha::Libraries->pickup_locations is wrong: we should not expect 2
    different types for a given parameter, biblio should always be a
    Koha::Biblio (idem for item btw).
    That could be fixed easily if the template had the Koha::Biblio object
    sent.
    
    Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Template/Plugin/Branches.pm |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list