[koha-commits] main Koha release repository branch master updated. v19.11.00-547-g0ead9c0163
Git repo owner
gitmaster at git.koha-community.org
Fri Jan 31 15:16:39 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 0ead9c01633f00dac9cd249095904b7aa69d45b3 (commit)
via 46bc93b4da637add09ef00d4cd6984e0a1d8e767 (commit)
via 77979a03b44ff55b5aba889ca031b5251f0c3e63 (commit)
via 2dde059059fa30d808350bbb03727bd032d94ff0 (commit)
via 58356c12bbaf4dc7eb3f7c918b62f91606062761 (commit)
via 578b1aa8f754b49eacb47d0f652e174ab049d47b (commit)
via 528cc36f0c855b69e2257f7fbc754f3bbc4879c8 (commit)
from 6d456df81a03096342dd72df99284e23603a7bbc (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 0ead9c01633f00dac9cd249095904b7aa69d45b3
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Fri Jan 31 09:47:54 2020 +0000
Bug 24467: (QA follow-up) Clarify tests wording for ->count methods
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 46bc93b4da637add09ef00d4cd6984e0a1d8e767
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Fri Jan 31 09:46:56 2020 +0000
Bug 24467: (QA follow-up) Fix POD in Koha::Biblio
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 77979a03b44ff55b5aba889ca031b5251f0c3e63
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jan 22 16:21:22 2020 +0100
Bug 24467: Remove _count methods introduced for API use
This patch removes some methods that were introduced for API usage in
the first iteration of the object embedding development effort.
Those methods were obsoleted by bug 24528, which introduces a smarter
way for Koha::Object->to_api to embed *_count attributes on the output
structure based on the relationships and a call to ->count.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass
3. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2dde059059fa30d808350bbb03727bd032d94ff0
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jan 29 09:24:35 2020 -0300
Bug 24528: Add a syntax to x-koha-embed to specify counts
This patch adds a + syntax to specify on the x-koha-embed header that we
want the count of a relation in the response. For example:
GET /patrons/1
x-koha-embed: checkouts+count
Would return a JSON representation of a Koha::Patron, with a new
attribute added: checkouts_count, which will be the result of calling
$patron->checkouts->count.
This is all done automatically in to_api. This patch makes parsing the
x-koha-embed header build the right structure for passing to the to_api
method.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 58356c12bbaf4dc7eb3f7c918b62f91606062761
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 28 16:24:51 2020 -0300
Bug 24528: Add *_count support to to_api
This patch adds a way to tell to_api an attribute needs to be calculated
as the count on an existing method/relationship result. For example, if
we wanted to include the holds_count attribute for a Koha::Patron
object, we would call it:
$ patron_json = $patron->to_api({ embed => { holds_count => { is_count => 1 } } });
This way to_api will internally call
$json->{holds_count} = $self->holds->count;
To test:
1. Apply the tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat (2)
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 578b1aa8f754b49eacb47d0f652e174ab049d47b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 28 16:14:01 2020 -0300
Bug 24528: Unit tests for Koha::Object->to_api
This patch introduces unit tests for the new to_api bejaviour for
*_count methods.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail because the feature is not implemented
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 528cc36f0c855b69e2257f7fbc754f3bbc4879c8
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Mon Jan 27 22:06:06 2020 +0000
Bug 24523: Add missing </p>
Signed-off-by: David Roberts <david.roberts at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/Biblio.pm | 40 +++-------------------
Koha/Object.pm | 32 ++++++++++-------
Koha/REST/Plugin/Query.pm | 8 ++++-
acqui/basket.pl | 4 +--
acqui/parcel.pl | 2 +-
.../bootstrap/en/modules/opac-password-recovery.tt | 2 +-
t/Koha/REST/Plugin/Query.t | 9 +++--
t/db_dependent/Koha/Biblio.t | 28 +++++++--------
t/db_dependent/Koha/Object.t | 37 +++++++++++++++++++-
9 files changed, 92 insertions(+), 70 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list