[koha-commits] main Koha release repository branch master updated. v19.11.00-550-g268f03d34b

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  268f03d34b370633a801142a62525bf8ca53c520 (commit)
       via  82c8542cb6493c9d2ddc9a1f26c54d6aac675317 (commit)
       via  0bf254e4071ceb7c78e0387c184ae55b288695ef (commit)
      from  0ead9c01633f00dac9cd249095904b7aa69d45b3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 268f03d34b370633a801142a62525bf8ca53c520
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jan 30 15:38:26 2020 +0100

    Bug 24546: Fix intentions of build_sample_item in Club/Hold.t
    
    In t/db_dependent/Koha/Club/Hold.t:
    my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode });
    my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode });
    
    build_sample_item takes either "library" or the item's attributes.
    branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong.
    
    Test plan:
     % prove t/db_dependent/Koha/Club/Hold.t
    must return green before and after this patch
    
    Note that this patch also remove an uneeded debugging statement.
    
    This has been caught by bug 24363.
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 82c8542cb6493c9d2ddc9a1f26c54d6aac675317
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 11 09:39:30 2019 +0100

    Bug 24213: Fix Koha::Object->get_from_storage if the object has been deleted
    
    Without this patch it fails with something like:
      DBIC result _type  isn't of the _type Subscription at t/db_dependent/Biblio.t line 627.
    
    Test plan:
    - Apply the first patch (Add tests)
    - Confirm that they fail
    - Apply this patch
    - Confirm that the tests pass
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0bf254e4071ceb7c78e0387c184ae55b288695ef
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 11 09:39:15 2019 +0100

    Bug 24213: Add tests
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Object.pm                  |  1 +
 t/db_dependent/Koha/Club/Hold.t |  7 +++----
 t/db_dependent/Koha/Object.t    | 25 ++++++++++++++++++++++++-
 3 files changed, 28 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository