[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-61-g9882869f1a

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 20.05.x has been updated
       via  9882869f1a41f23590d53935d1a08d9f79a4c463 (commit)
      from  25d820f3226c6116d064591abc67e2463a571f50 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9882869f1a41f23590d53935d1a08d9f79a4c463
Author: Petro Vashchuk <stalkernoid at gmail.com>
Date:   Wed Jun 17 16:44:42 2020 +0300

    Bug 25322: fix for not selected "relationship" defaults to father
    
    When a user creates a patron's guarantor on /cgi-bin/koha/members/memberentry.pl but doesn't select the relationship from a dropdown, the relationship defaults to first value, which in default sysprefs is "father". This may or may not be correct as this is not a conscious choice from the user.
    
    The solution is to make the "Relationship" field mandatory when there is no empty entry in the system preferences, always starting with an empty option but not allowing the user to save an empty entry.
    And if there is an empty option in sysprefs, it allows to save empty, as well as makes it default choice.
    
    To reproduce with default system preferences:
        1) Create a new patron who is assumed to have a guarantor or modify the existing one.
        2) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes.
        3) Observe that relationship is set as "father".
        4) Apply the patch.
        5) Repeat steps 1 and 2.
        6) Observe that it doesn't allow you to save the form until you pick a relationship type.
    
    To reproduce with empty entry added to system preferences:
        1) Add an empty entry to borrowerRelationship at /cgi-bin/koha/admin/preferences.pl?tab=patrons in Patron relationships section (example: "|father|mother").
        2) Create a new patron who is assumed to have a guarantor or modify the existing one.
        3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes.
        4) Observe that relationship is set as "father".
        5) Apply the patch.
        6) Repeat steps 1, 2 and 3.
        7) Observe when you save the empty entry it does set the relationship as empty.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 029f41a667da8f054633432997bc818c1b26a27f)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/members/memberentrygen.tt      | 34 ++++++++++++++++++----
 members/memberentry.pl                             |  4 +++
 2 files changed, 32 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository