[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-66-g1c54f85456
Git repo owner
gitmaster at git.koha-community.org
Mon Jul 13 19:31:36 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 20.05.x has been updated
via 1c54f8545611b43672867ac7a34dd8a0c20c20a4 (commit)
via 1b505eee19cfd59f59dcc4b696c591f209931dcc (commit)
via 41fb8527b18d1ebaa25934cfd9a01f8b8c4e43be (commit)
via 7f89ea6e1843be235783b41f4c521e100edceebd (commit)
via b8a1515ad30200a58d4b1d62bf140b86a6f331e1 (commit)
from 9882869f1a41f23590d53935d1a08d9f79a4c463 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 1c54f8545611b43672867ac7a34dd8a0c20c20a4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jun 29 13:42:55 2020 +0200
Bug 21395: Remove 'variable $DEBUG masks earlier declaration in same scope' warning
% prove t/db_dependent/Serials.t
t/db_dependent/Serials.t .. 8/49 "my" variable $DEBUG masks earlier declaration in same scope at /kohadevbox/koha/C4/Barcodes/ValueBuilder.pm line 45.
"my" variable $DEBUG masks earlier declaration in same scope at /kohadevbox/koha/C4/Barcodes/ValueBuilder.pm line 87.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 61aa3f794240443f5c2c99adc016f0d80c7251d9)
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
commit 1b505eee19cfd59f59dcc4b696c591f209931dcc
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jun 25 13:48:36 2020 +0100
Bug 21395: (QA follow-up) POD fixes
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit b9e526a12fb338736e149934526e38da782f048f)
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
commit 41fb8527b18d1ebaa25934cfd9a01f8b8c4e43be
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jun 25 11:31:49 2020 +0100
Bug 21395: (QA follow-up) Remove some introduced issues
This patch removes some new error cases introduced during rebase
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit e968af43777d47c9134ea1875270af9661ef2f5a)
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
commit 7f89ea6e1843be235783b41f4c521e100edceebd
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Mon Apr 27 10:31:19 2020 +0200
Bug 21395: Fix QA errors
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 1682341b5849c34e59597cda780d4c877d6f3278)
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
commit b8a1515ad30200a58d4b1d62bf140b86a6f331e1
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Sep 21 18:05:42 2018 +0200
Bug 21395: Make perlcritic happy
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes
almost all perlcrictic violations according to this .perlcriticrc
The remaining violations are silenced out by appending a '## no critic'
to the offending lines. They can still be seen by using the --force
option of perlcritic
This patch also modify t/00-testcritic.t to check all Perl files using
the new .perlcriticrc.
I'm not sure if this test script is still useful as it is now equivalent
to `perlcritic --quiet .` and it looks like it is much slower
(approximatively 5 times slower on my machine)
Test plan:
1. Run `perlcritic --quiet .` from the root directory. It should output
nothing
2. Run `perlcritic --quiet --force .`. It should output 7 errors (6
StringyEval, 1 BarewordFileHandles)
3. Run `TEST_QA=1 prove t/00-testcritic.t`
4. Read the patch. Check that all changes make sense and do not
introduce undesired behaviour
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit b168f4a2e9a03ed56ce857353d4dde940980caba)
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
t/perlcriticrc => .perlcriticrc | 2 +
C4/Accounts.pm | 1 -
C4/Acquisition.pm | 1 -
C4/Auth_with_cas.pm | 18 +--
C4/AuthoritiesMarc.pm | 1 -
C4/Barcodes/ValueBuilder.pm | 141 +++++++++++----------
C4/Barcodes/annual.pm | 8 +-
C4/Biblio.pm | 1 -
C4/ClassSortRoutine.pm | 4 +-
C4/ClassSplitRoutine/RegEx.pm | 2 +-
C4/Context.pm | 2 -
C4/CourseReserves.pm | 2 +-
C4/Creators.pm | 2 +
C4/Creators/Lib.pm | 2 +-
C4/ImportBatch.pm | 12 +-
C4/InstallAuth.pm | 58 ++++-----
C4/Items.pm | 1 -
C4/Labels.pm | 2 +
C4/Labels/Label.pm | 5 +-
C4/Languages.pm | 4 +-
C4/Letters.pm | 1 -
C4/Matcher.pm | 2 +-
C4/Members/Messaging.pm | 1 -
C4/Patroncards.pm | 2 +
C4/Patroncards/Patroncard.pm | 8 +-
C4/Record.pm | 8 +-
C4/Ris.pm | 1 -
C4/Search.pm | 5 -
C4/Serials.pm | 21 +--
C4/Templates.pm | 2 +-
Makefile.PL | 6 +-
docs/CAS/CASProxy/examples/koha_webservice.pl | 6 +-
docs/CAS/CASProxy/examples/proxy_cas_callback.pl | 6 +-
docs/CAS/CASProxy/examples/proxy_cas_data.pl | 8 +-
fix-perl-path.PL | 4 +-
installer/data/mysql/labels_upgrade.pl | 2 +
installer/data/mysql/patroncards_upgrade.pl | 2 +
installer/data/mysql/update22to30.pl | 16 +--
installer/data/mysql/updatedatabase.pl | 10 +-
installer/externalmodules.pl | 6 +-
installer/install.pl | 2 +-
misc/admin/koha-preferences | 1 +
misc/batchRepairMissingBiblionumbers.pl | 1 -
misc/batchdeletebiblios.pl | 2 +-
misc/bin/connexion_import_daemon.pl | 1 +
misc/check_sysprefs.pl | 6 +-
misc/cronjobs/build_browser_and_cloud.pl | 2 +-
misc/cronjobs/gather_print_notices.pl | 3 +-
misc/cronjobs/holds/cancel_expired_holds.pl | 3 +-
misc/cronjobs/longoverdue.pl | 6 +-
misc/cronjobs/rss/rss.pl | 6 +-
.../thirdparty/TalkingTech_itiva_inbound.pl | 1 +
misc/cronjobs/update_totalissues.pl | 2 +-
misc/exportauth.pl | 6 +-
misc/link_bibs_to_authorities.pl | 2 +-
misc/maintenance/cmp_sysprefs.pl | 2 +-
.../fix_accountlines_rmdupfines_bug8253.pl | 1 -
misc/maintenance/touch_all_biblios.pl | 10 +-
misc/maintenance/touch_all_items.pl | 10 +-
.../migration_tools/22_to_30/export_Authorities.pl | 7 +-
.../22_to_30/export_Authorities_xml.pl | 7 +-
.../22_to_30/move_marc_to_biblioitems.pl | 8 +-
misc/migration_tools/buildCOUNTRY.pl | 2 +-
misc/migration_tools/buildEDITORS.pl | 1 -
misc/migration_tools/buildLANG.pl | 2 +-
misc/migration_tools/bulkmarcimport.pl | 7 +-
misc/migration_tools/remove_unused_authorities.pl | 1 -
misc/perlmodule_rm.pl | 2 +-
misc/translator/LangInstaller.pm | 2 +-
misc/translator/TmplTokenizer.pm | 58 ++++-----
misc/translator/VerboseWarnings.pm | 24 ++--
misc/translator/po2json | 14 +-
misc/translator/tmpl_process3.pl | 81 ++++++------
misc/translator/xgettext.pl | 30 +++--
opac/opac-MARCdetail.pl | 1 -
opac/opac-alert-subscribe.pl | 1 -
opac/opac-authorities-home.pl | 1 -
opac/opac-authoritiesdetail.pl | 1 -
opac/opac-basket.pl | 1 -
opac/opac-search.pl | 5 -
opac/opac-serial-issues.pl | 2 -
opac/opac-showreviews.pl | 1 -
patroncards/create-pdf.pl | 10 +-
patroncards/image-manage.pl | 2 +-
patroncards/print.pl | 12 +-
plugins/plugins-upload.pl | 2 +-
reports/acquisitions_stats.pl | 1 -
reports/bor_issues_top.pl | 26 ++--
reports/borrowers_out.pl | 7 +-
reports/catalogue_out.pl | 2 -
reports/catalogue_stats.pl | 5 -
reports/issues_avg_stats.pl | 5 -
reports/issues_stats.pl | 5 +-
reports/reserves_stats.pl | 8 +-
rewrite-config.PL | 33 +++--
svc/holds | 1 -
t/00-testcritic.t | 32 +----
t/Languages.t | 2 +-
t/Prices.t | 4 +-
t/SuggestionEngine.t | 2 +-
t/db_dependent/Accounts.t | 1 -
t/db_dependent/Acquisition/OrderFromSubscription.t | 3 +-
t/db_dependent/Acquisition/OrderUsers.t | 1 -
t/db_dependent/Barcodes.t | 4 +-
t/db_dependent/Context.t | 2 -
t/db_dependent/Hold.t | 2 +-
t/db_dependent/LDAP/test_ldap_add.pl | 2 +-
t/db_dependent/Record/Record.t | 32 ++---
t/db_dependent/Search.t | 6 +
t/db_dependent/Serials.t | 1 -
t/db_dependent/Serials_2.t | 1 -
t/db_dependent/XISBN.t | 1 -
t/db_dependent/cronjobs/advance_notices_digest.t | 6 +-
t/db_dependent/www/auth_values_input_www.t | 1 -
t/dummy.t | 1 +
tags/review.pl | 6 +-
tools/batchMod.pl | 5 +-
tools/export.pl | 2 -
tools/import_borrowers.pl | 3 -
tools/letter.pl | 2 +-
tools/modborrowers.pl | 3 +-
tools/overduerules.pl | 2 -
tools/picture-upload.pl | 14 +-
tools/upload-cover-image.pl | 6 +-
xt/author/show-template-structure.pl | 6 +-
xt/author/translatable-templates.t | 2 +-
xt/find-license-problems.t | 5 +-
xt/fix-old-fsf-address | 8 +-
xt/single_quotes.t | 2 +-
129 files changed, 460 insertions(+), 541 deletions(-)
rename t/perlcriticrc => .perlcriticrc (89%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list