[koha-commits] main Koha release repository branch master updated. v20.05.00-28-g9ac43fd97b

Fri Jun 12 14:46:13 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  9ac43fd97b58120560a33e26509d5acc712c97fb (commit)
       via  74c7530e3dacd7a1df9ed72d031bc1a5b7063142 (commit)
       via  13ec430eccd52413e756c88f90a370787842cbc2 (commit)
       via  4365b64403ba9492650e2e1733ccad8772dcdfc2 (commit)
       via  369a4e39b48456be4376292f724a787ef0b6667e (commit)
       via  5ae7554667a209962a169f3a3b1d4b5b4beb398c (commit)
       via  4c548cb08f3f3013778da71d47745f48b6adffd8 (commit)
       via  88cd45b0903ae7cfd8939045e60ffc7b0361e16c (commit)
       via  4714b08f7270b86c62d9e32ce8f14d3afb08f37e (commit)
       via  79f7879303724aa1ae69db8c3f2ea5aa34148dc5 (commit)
       via  4d003ad9cd5a0967f3235d687340a8b75d36acd3 (commit)
       via  f32825ae26aa443a1fde2c8884852e4298d96916 (commit)
       via  e239e13bc9663dc3d4a43f125761165875b08876 (commit)
      from  c9be26ad5ac7615f2f723900dfd16d83d71b66fe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9ac43fd97b58120560a33e26509d5acc712c97fb
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Sat May 23 14:35:45 2020 +0000

    Bug 25492: Your Account Menu button does nothing on mobile devices

    This patch removes some redundant code from the OPAC JavaScript which
    was causing problems with the show/hide action on two controls which are
    shown only at narrower browser widths: The "Your account" menu shown
    when the user is on a user-related page, and the "Refine your search"
    menu shown on the search results page.

    To test, apply the patch and go to the OPAC. Narrow your browser width
    to below 768 pixels.

     - Perform a search.
     - On the search results page you should see a "Refine your search"
       link at the top of the results. Clicking it should expand and
       collapse the facets menu.
     - Log in to the OPAC.
     - On the "Your summary" page there should be a "Your account menu" link
       at the top of the main part of the page. Clicking it should expand
       and collapse the account menu.
     - Verify that these menus display correctly when you widen and narrow
       the browser window.

    Signed-off-by: David Nind <david at davidnind.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 74c7530e3dacd7a1df9ed72d031bc1a5b7063142
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jun 2 11:05:12 2020 +0200

    Bug 17842: Simplify the code

    There is no need for all the conditions.
    From Encode::encode POD:
      "If the $string is undef, then undef is returned."

    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 13ec430eccd52413e756c88f90a370787842cbc2
Author: David Cook <dcook at prosentient.com.au>
Date:   Tue May 26 12:30:53 2020 +1000

    Bug 17842: UTF-8 encode ISO2709 MARC download from cart

    The cart was outputing ISO2709 MARC records with Latin-1
    encoding. Records containing non-latin1 characters were
    automatically re-encoded as UTF-8 by browsers, which led to
    inconsistent character encodings for downloaded MARC files.

    This patch explicitly encodes ISO2709 MARC characters from
    the cart download as UTF-8 encoded bytes, which resolves the problem.

    Test Plan:
    0) Don't apply patch
    1) Create bib record with only ASCII characters
    2) Add a ü character to the title
    3) Save bib record
    4) Download bib record from cart (opac and staff client)
    5) Using xxd or some other program, note that the ü is
    represented by a FC byte (latin-1 encoded)
    6) Apply the patch
    7) Download bib record from cart (opac and staff client)
    8) Using xxd or some other program, note that the ü is
    represented by C3 BC bytes (utf-8 encoded)
    9) Success

    (Note that you could potentially use Notepad++ or some other
    program to open the downloaded file and just note the encoding
    that it finds. You could also try "chardetect" instead. Lots
    of options for figuring out the encoding.)

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4365b64403ba9492650e2e1733ccad8772dcdfc2
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Jun 2 14:00:25 2020 +0000

    Bug 25653: Update tab selector to use 'active' and include all options

    It looks like the functionality was broken when ui tabs were upgraded
    and mainmainentry was added

    To test:
    1 - Browse to Authorities
    2 - Search in each tab
    3 - Note all search results revert to 'Search main heading a only'
    4 - Apply patch
    5 - Note selection is retained after search

    Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 369a4e39b48456be4376292f724a787ef0b6667e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Jun 8 11:12:07 2020 +0100

    Bug 14543: (QA follow-up) Add missing filter

    This patch adds a missing `| html` filter to the tax_rate value option
    that the patchset adds

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 5ae7554667a209962a169f3a3b1d4b5b4beb398c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jul 16 12:14:42 2015 -0400

    Bug 14543: Order lines updated that have a tax rate not in gist will have tax rate set to 0!

    If the tax rate for a given order line has been removed from the system
    preference gist, that tax rate will show in the pulldown as 0. If a
    librarian then saves the order line the original tax rate will be
    overwritten with 0%!

    Test Plan:
    1) Find an order line
    2) Remove the tax rate set for that order line from the syspref gist
    3) Edit the order line
    4) Note the tax rate is 0
    5) Apply this patch
    6) Edit the order line
    7) Note the tax rate now displays with a warning

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4c548cb08f3f3013778da71d47745f48b6adffd8
Author: David Cook <dcook at prosentient.com.au>
Date:   Tue Jun 2 09:53:06 2020 +1000

    Bug 25634: Warn if koha-shell returns non-zero in koha-foreach

    By putting koha-shell in an if statement, "set -e" will no longer
    cause the entire koha-foreach program to exit, if koha-shell
    returns a non-zero status.

    If a non-zero status is returned, we warn on it, and the caller
    of koha-foreach can interpret that command visually.

    To Test:
    1) Write a shell script that says "Hello" and then exits with a 1
    status
    2) Run koha-foreach against that shell script with multiple instances
    available to koha-foreach
    3) Before the patch, koha-foreach will die after the first "Hello"
    4) After the patch, koha-foreach will continue, through all the
    instances, and report which instances returned non-zero statuses
    by which command.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 88cd45b0903ae7cfd8939045e60ffc7b0361e16c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jun 8 14:14:22 2020 +0200

    Bug 25693: Set correct permissions on logdir after an upgrade

    Since bug 25172 we are failing loudly if the permissions are not correct
    and that the logger cannot init successfully.

    We must set the correct permission on upgrading.
    koha-create deals with new installs

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4714b08f7270b86c62d9e32ce8f14d3afb08f37e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jun 4 14:43:58 2020 -0400

    Bug 25677: Checkbox options for EDI accounts cannot be enabled

    Checking any of the checkboxes in the EDI Account editor does nothing.
    They always remain set to "off".

    Test Plan:
    1) Browse to edi_accounts.pl
    2) Create a new EDI account, check all the checkboxes
    3) Edit the account, note none of the checkboxes are checked
    4) Apply this patch
    5) Repeat steps 1-2
    6) Note the checkboxes remain checked

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 79f7879303724aa1ae69db8c3f2ea5aa34148dc5
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Thu May 21 23:42:01 2020 +0000

    Bug 25557: Correct basket.pl column config

    This patch corrects the column configuration tool for basket.pl
    TO TEST:
    1. Go to Acquisitions and look at basket.pl
    2. Open another tab and go to column configuration and try to hide some columns like Quantity.
    3. See that the wrong columns are being hidden.
    4. Apply patch
    5. Trying hiding each column in the table and make sure the correct one is being hidden.
    6. Rejoice!

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4d003ad9cd5a0967f3235d687340a8b75d36acd3
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Tue Jun 2 15:32:10 2020 +0400

    Bug 25651: Fix modification of authorised value

    When modifying an existing authorised value, the category is not
    correctly passed to the template and so it is not passed to the
    POST request, which results in the authorised value switching to
    category '', which effectively make it disappear from the interface.
    This patch fixes that.

    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f32825ae26aa443a1fde2c8884852e4298d96916
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Jun 11 15:42:22 2020 -0300

    Bug 25707: (QA follow-up) Clearer message about what's going on

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e239e13bc9663dc3d4a43f125761165875b08876
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Jun 9 12:49:54 2020 -0400

    Bug 25707: (bug 11529 follow-up) Do not update marc mappings, print old mappings to upgrade log

    This patch removes the update of marc frameworks from the updatedatabase script and warns the
    "MARC to Keyword" (fieldmappings ) to the upgrade log so they can be replaced manually

    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 admin/authorised_values.pl                         |  2 +-
 admin/columns_settings.yml                         |  8 ++++++--
 basket/downloadcart.pl                             |  4 +++-
 debian/koha-common.postinst                        | 10 ++++++++++
 debian/scripts/koha-foreach                        |  7 ++++++-
 installer/data/mysql/updatedatabase.pl             | 10 ++++++----
 .../prog/en/includes/authorities_js.inc            | 10 ++++++----
 .../prog/en/modules/acqui/neworderempty.tt         | 22 +++++++++++++++-------
 .../prog/en/modules/admin/edi_accounts.tt          | 20 ++++++++++----------
 koha-tmpl/opac-tmpl/bootstrap/js/script.js         |  6 ------
 opac/opac-downloadcart.pl                          |  4 +++-
 11 files changed, 66 insertions(+), 37 deletions(-)

hooks/post-receive
-- 
main Koha release repository