[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.11-24-g8767c55242

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  8767c5524223ca2e423501a75fb8893faed92ad2 (commit)
       via  7c7bb52d6d08b326c23900e15edc39d8335d6247 (commit)
       via  e2e43182ca2b100b61532e5c6499abae78331ba2 (commit)
      from  df8e0a1205fd23243d8207710c4a001e4ed59c79 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8767c5524223ca2e423501a75fb8893faed92ad2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed May 13 15:18:29 2020 +0200

    Bug 24413: Add tests
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit bbe6b07f4340afca18763724194fbc577b77959d)
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    (cherry picked from commit ec82606a3ad0371cac8427a01cb058a9df36dbc2)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit 7c7bb52d6d08b326c23900e15edc39d8335d6247
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Feb 21 12:37:44 2020 +0100

    Bug 24413: Do not remove the restrictions from AddReturn
    
    As we are now removing them from MarkIssueReturned they should not be
    removed from AddReturn as well.
    Also I think this will fix a regression, if $doreturn is not set (in
    case the item is withdrawn and BlockReturnOfWithdrawnItems or the item
    is lost and BlockReturnOfLostItems, and other specific cases).
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 10af741387a75d29c6b7782c6ce3d2c07cad9517)
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    (cherry picked from commit b50c446f46c2ce987498baeed19c0af07a61fd42)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit e2e43182ca2b100b61532e5c6499abae78331ba2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Feb 17 16:27:57 2020 +0100

    Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items
    
    It's quite hard to know where this need to be fixed.
    it can be either MarkIssueReturned or LostItem, depending on the
    different cases we want to handle.
    
    This patch picked MarkIssueReturned, but maybe the similar code in
    AddReturn needs to be removed then.
    
    == Test plan ==
    1. Set MarkLostItemsAsReturned to 'from items tab of the catalog module'
    2. Set AutoRemoveOverduesRestrictions to 'Do'
    3. Set up an overdues restriction in the notice triggers
    4. Check out an item and let the overdues process restrict the account
    5. Navigate to the moredetail.pl page (items tab) for the overdue item
    6. Mark the item lost
    7. Return to the account in question - notice the item has been returned, but the restriction remains
    8. Clean state: remove restriction + remove item lost status
    9. Apply patch
    10. Redo the test but this time in addition to the item being returned,
        the restriction will be lifted.
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 70ae2eaf9cdc7708f85b1724e5bc89623355b585)
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    (cherry picked from commit 28664aea0ae023ffd9fb57ff130138662e591b1d)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                              | 28 +++++++++++++------
 t/db_dependent/Circulation/MarkIssueReturned.t | 38 +++++++++++++++++++++++++-
 2 files changed, 56 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
main Koha release repository