[koha-commits] main Koha release repository branch master updated. v19.11.00-2010-gc6edd2d7f3
Git repo owner
gitmaster at git.koha-community.org
Mon May 4 10:10:45 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via c6edd2d7f375f624a922bd59c1b275a9bdba6f97 (commit)
via d2c01b24586e3828c87c2bb383d864cebf32a7c4 (commit)
via b3e30677315ee304a74ae31c6851030e22b31b27 (commit)
via 580e6fabff5ec0f564e200a6b2fe42955661b5b7 (commit)
via 39138e860ce8e3eb54d2788ba32728baf03122c0 (commit)
via e2ace8dfe33c04048a3ef52a5a735cc9aedd54d1 (commit)
via 7c325fd6319057e8d8746bf829419f99d0ac9dba (commit)
via 8adf22c72511c9252cc90cc4d295f868abc1e718 (commit)
via 240b52170be0551830d0d1c77967f271d5ae553e (commit)
via c34eb3c95032b9ae54c04a55a5935bdc9691804c (commit)
via b76fb4a6c5b6eec9d9ed7a6656bca28e013b6ca9 (commit)
via 3db5242ff9d92789ec346d6c278eb54c3bdd7d7d (commit)
via e94c5ea20b60401c99cab1ee9c5d0a9b321b9acb (commit)
via 1ed4cc6540e48da584763ed24d5571608d14cf61 (commit)
via 537ba245eed721d645387b840d6dbffaf98d57df (commit)
via 8b6be7cced077e587c00a43080efc548b48fefac (commit)
via 3d953d7988df792ca83a13872a39f49480c7e39f (commit)
via 219f000069377f8a6b2790e42870083236b66bd0 (commit)
via dc0cb0378cdd8260123bc3d0bbc58fd388b5e650 (commit)
via 46040fcf862f0c7b6f8bdf9f2b1ecd9f15adf54e (commit)
via 78ce445ae49404c7e7344999945abfc576ad8cac (commit)
via 02499a45caf241cc55674e89da56e727026391e6 (commit)
via 83d78e764e0821037de235b67d269220d7d29f69 (commit)
via 77fde261c3e6d199d78c12c631326cd23bea4e6c (commit)
via 0ebb62755e56fb4e057ad35db6408e04d237559f (commit)
via 0f3e7691a491d71b4804a527ce4d3a0bd3ed44a5 (commit)
via b9cfa36d475e0f897398228a1cfe8b0a71b4d227 (commit)
via 8e4d0fe9df385be1509d6e636665f55a098af2b2 (commit)
via 68425749246ef48f198f30f2d3416ae2ae7360e6 (commit)
from d9013a1333ec911f7f88eef6b362f7f4df604839 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c6edd2d7f375f624a922bd59c1b275a9bdba6f97
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 29 14:57:57 2020 +0200
Bug 25309: Limit size of streetnumber field to 10
It's its size in DB (varchar(10))
Test plan:
Create or editing a patron and confirm that you fill in more than 10
characters in the streetnumber field
Save
=> The patron has been correctly created/updated
Signed-off-by: David Roberts <david at koha-ptfs.co.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d2c01b24586e3828c87c2bb383d864cebf32a7c4
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri May 1 22:04:15 2020 +0000
Bug 25311: (QA follow-up) Add misssing filter
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b3e30677315ee304a74ae31c6851030e22b31b27
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 29 14:48:38 2020 +0200
Bug 25311: Better error handling when updating a patron
Same as the precedent patch for patron's modification
Test plan is identical but with an existing patron
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 580e6fabff5ec0f564e200a6b2fe42955661b5b7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 29 14:38:41 2020 +0200
Bug 25311: Better error handling when creating a patron
This is still not ideal but brings a bit of enhancement.
One possible problem is that the patron creation will fail if the
streetnumber field is too long (borrowers.streetnumber is varchar(10).
Test plan:
0. Don't apply this patch
1. Create a new patron with a streetnumber longer than 10 characters
2. Save
=> The patron has not been created and the app explodes
The error is about extended_attributes and not meaningful
Can't call method "extended_attributes" on an undefined value at /kohadevbox/koha/members/memberentry.pl line 560
3. Apply the patch
4. Repeat 1. and 2
=> You get a warning on the interface and you still see the creation
form
5. Check the logs
=> The error is meaningful
"Data too long for column 'streetnumber'"
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 39138e860ce8e3eb54d2788ba32728baf03122c0
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon May 4 08:35:59 2020 +0100
Bug 17268: DBRev 19.12.00.084
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e2ace8dfe33c04048a3ef52a5a735cc9aedd54d1
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon May 4 08:33:02 2020 +0100
Bug 17268: Schema Update
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7c325fd6319057e8d8746bf829419f99d0ac9dba
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri May 1 21:35:38 2020 +0000
Bug 17268: (follow-up) Don't show the macro ID in front of description
I believe it's nicer to allow users to organize the macros as
they want using the descrpitions they prefer.
Submitting as a suggestion.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8adf22c72511c9252cc90cc4d295f868abc1e718
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri May 1 23:33:00 2020 +0200
Bug 17268: (QA follow-up) Make "Convert old browser macros" translatable
The code was missing the necessary markup to make the string translatable.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 240b52170be0551830d0d1c77967f271d5ae553e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Apr 22 21:13:34 2020 +0000
Bug 17268: Update patchs per RFC
https://wiki.koha-community.org/wiki/Advanced_editor_macros_endpoint_RFC
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c34eb3c95032b9ae54c04a55a5935bdc9691804c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Mar 27 10:38:04 2020 +0000
Bug 17268: (follow-up) Fix translatability
This patch moves the error messages to translatable strings
Also includes capitalization fixes and POD adjustment
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b76fb4a6c5b6eec9d9ed7a6656bca28e013b6ca9
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Mar 11 09:39:25 2020 -0400
Bug 17268: Set boolean for shared column in schema
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3db5242ff9d92789ec346d6c278eb54c3bdd7d7d
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jan 2 15:02:04 2020 +0000
Bug 17268: Schema update
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e94c5ea20b60401c99cab1ee9c5d0a9b321b9acb
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Mar 11 09:31:39 2020 -0400
Bug 17268: (follow-up) Fix licenses
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1ed4cc6540e48da584763ed24d5571608d14cf61
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Mar 3 13:14:03 2020 +0000
Bug 17268: Use API to store/retrieve values
To test:
1 - Enable AdvancedCatalogingEditor
2 - Add some macros (they don't need to be valid, just have content)
3 - Apply patches
4 - updatedatabase
5 - Set user to have 'create_shared_macros' and 'delete_shared_macros'
6 - Load the advanced editor (Cataloging->Advanced editor)
7 - Click on 'Macros'
8 - Previous macros should not show, but you should have a 'Convert' button
9 - Convert old macros and confirm they show
10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating
11 - Have at least on valid macro and run it, e.g.:
new 100=Testing this out
12 - Run the macro, confirm it runs
13 - Try a macro with gibberish, confirm there is an error when running
14 - Ensure you have a few macros marked public
15 - In a private browser window sign in as a patron with neither shared macro permission
16 - Confirm the public macros load, but cannot be edited
17 - Grant create_shared_macros permission to this patron
18 - Reload editor, they should now be able to edit shared macros
19 - Confirm they cannot delete shared macros
20 - Grant delete_shared_macros permission
21 - Reload editor
22 - Confirm they can now delete shared macros
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 537ba245eed721d645387b840d6dbffaf98d57df
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Dec 4 11:39:41 2019 +0000
Bug 17268: Advanced cataloging editor macros - add endpoint
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8b6be7cced077e587c00a43080efc548b48fefac
Author: Nick <nick at bywatersolutions.com>
Date: Wed Oct 2 13:28:39 2019 +0000
Bug 17268: Add macros table and permissions
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Heather Hernandez <Heather_Hernandez at nps.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3d953d7988df792ca83a13872a39f49480c7e39f
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Tue Apr 28 19:37:52 2020 -0300
Bug 24808: enable translation on results.js
String sorrounded by "__()"
To test:
1) create translation files for a language
(cd misc/translator; ./translate create xx-YY)
2) Check string
egrep -l "No cover image available" misc/translator/po/xx-YY-*
present in 2 files, opac-bootstrap and staf-prog
3) Apply patch
4) Create files again
(cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY)
5) Check again
egrep -l "No cover image available" misc/translator/po/xx-YY-*
present in 3 files, new in messages-js
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 219f000069377f8a6b2790e42870083236b66bd0
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon May 4 07:46:00 2020 +0100
Bug 17355: DBRev 19.12.00.083
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dc0cb0378cdd8260123bc3d0bbc58fd388b5e650
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri May 1 17:47:07 2020 +0200
Bug 17355: (QA follow-up) Add description to updatedatabase entry
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 46040fcf862f0c7b6f8bdf9f2b1ecd9f15adf54e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 28 11:53:57 2020 +0200
Bug 17355: Add the ability to remove authorised value categories
This new patch set is adding a new DB field is_system to distinguish
internal categories.
The list of internal categories is in the patch "DB changes - set
is_system for categories" and can be discussed/extended.
Test plan:
0.
- Apply patch
- updatedabase
1.
- Create a new AV category
- Create an authorised value
- List the AVs for this category
- Remove all the AVs for this category
=> You see 2 buttons "Add a new authorised value" and "Delete category
'XXX'"
- Click the delete button
=> You get a popup
- Accept
=> The category is deleted
2.
- List the AV for Asort1 (internal category)
/cgi-bin/koha/admin/authorised_values.pl?searchfield=Asort1
- Delete the AVs for this category (if there is any)
=> You do not see the "Delete category" button
3.
- Create a new AV category 'foo'
- Create an authorised value
- Hit /admin/authorised_values.pl?op=delete_category&categor_name=foo
=> You get an error message (expected because the category cannot be
deleted if it has AV linked)
=> message text:
=> An error occurred when deleting this authorized value category. Check the logs.
4.
- Hit /admin/authorised_values.pl?op=delete_category&categor_name=Asort1
=> You get an error message (expected because the category Asort1 cannot
be deleted, it's an internal category.
=> message text:
=> An error occurred when deleting this authorized value category. Check the logs.
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 78ce445ae49404c7e7344999945abfc576ad8cac
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 28 11:32:23 2020 +0200
Bug 17355: DB changes - set is_system for categories
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 02499a45caf241cc55674e89da56e727026391e6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 28 11:23:02 2020 +0200
Bug 17355: Override delete methods
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 83d78e764e0821037de235b67d269220d7d29f69
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 28 11:05:46 2020 +0200
Bug 17355: DBIC changes - boolean flag
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 77fde261c3e6d199d78c12c631326cd23bea4e6c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 28 11:03:25 2020 +0200
Bug 17355: DBIC changes
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0ebb62755e56fb4e057ad35db6408e04d237559f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 28 11:01:19 2020 +0200
Bug 17355: DB changes
This patch adds a new authorised_value_category.is_system boolean/tinyint(1)
DB field.
Name 'is_system' is coming from existing tables account_credit_types and
account_debit_types and should not be discussed here (if you disagree
fill a new bug report and deal with naming issue separately)
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0f3e7691a491d71b4804a527ce4d3a0bd3ed44a5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon May 4 07:40:21 2020 +0100
Bug 23433: (RM follow-up) One last consistency improvement
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b9cfa36d475e0f897398228a1cfe8b0a71b4d227
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Mar 6 15:06:02 2020 +0000
Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs
Use of patron-title.inc on the checkin page is inconsistent, resulting
in patron names being displayed differently under different
circumstances. This patch makes it more consistent.
To test, apply the patch and check in items with the following statuses:
- On hold for a patron at your library
- On hold for a patron not at your library
- On hold and already marked 'Waiting'
- On hold while HoldsAutoFill preference is enabled
- An item which has been marked with a LOST status in the
'ClaimReturnedLostValue' system preference.
- An item which was checked out to a manually-restricted patron and
checked in with a back-dated checkin date. See test plan on Bug
24776.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8e4d0fe9df385be1509d6e636665f55a098af2b2
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Dec 11 11:53:51 2019 +0000
Bug 15751: Add ModDateLastSeen to ProcessOfflineReturn
Test plan:
1) Before the patch when one checks in something using the KOCT the last seen
date is not updated.
2) After the patch when one checks in something using the KOCT the last seen
date is updated.
Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 68425749246ef48f198f30f2d3416ae2ae7360e6
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri May 1 17:27:52 2020 +0100
Bug 23794: (RM follow-up) Make DB update consistent
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 2 +
Koha.pm | 2 +-
Koha/{Desk.pm => AdvancedEditorMacro.pm} | 23 +-
Koha/{Desks.pm => AdvancedEditorMacros.pm} | 15 +-
Koha/AuthorisedValueCategories.pm | 20 +
Koha/AuthorisedValueCategory.pm | 15 +
Koha/REST/V1/AdvancedEditorMacro.pm | 395 ++++++++++++++++
.../{Discharge.pm => AdvancedEditorMacro.pm} | 72 +--
Koha/Schema/Result/AuthorisedValueCategory.pm | 16 +-
Koha/Schema/Result/Borrower.pm | 19 +-
admin/authorised_values.pl | 16 +-
api/v1/swagger/definitions.json | 3 +
.../swagger/definitions/advancededitormacro.json | 26 +
api/v1/swagger/parameters.json | 3 +
api/v1/swagger/parameters/advancededitormacro.json | 9 +
api/v1/swagger/paths.json | 12 +
api/v1/swagger/paths/advancededitormacros.json | 521 +++++++++++++++++++++
api/v1/swagger/x-primitives.json | 5 +
installer/data/mysql/kohastructure.sql | 16 +
installer/data/mysql/mandatory/auth_val_cat.sql | 86 ++--
installer/data/mysql/updatedatabase.pl | 62 ++-
installer/data/mysql/userpermissions.sql | 2 +
.../prog/en/includes/cateditor-ui.inc | 264 +++++++++--
.../en/includes/member-main-address-style-de.inc | 2 +-
.../en/includes/member-main-address-style-fr.inc | 2 +-
.../en/includes/member-main-address-style-us.inc | 2 +-
.../intranet-tmpl/prog/en/includes/permissions.inc | 10 +
.../prog/en/modules/admin/authorised_values.tt | 29 +-
.../prog/en/modules/cataloguing/editor.tt | 6 +
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 23 +-
.../prog/en/modules/members/memberentrygen.tt | 11 +
koha-tmpl/intranet-tmpl/prog/js/pages/results.js | 4 +-
members/memberentry.pl | 130 ++---
t/db_dependent/AuthorisedValues.t | 27 +-
t/db_dependent/api/v1/advanced_editor_macros.t | 474 +++++++++++++++++++
35 files changed, 2091 insertions(+), 233 deletions(-)
copy Koha/{Desk.pm => AdvancedEditorMacro.pm} (67%)
copy Koha/{Desks.pm => AdvancedEditorMacros.pm} (78%)
create mode 100644 Koha/REST/V1/AdvancedEditorMacro.pm
copy Koha/Schema/Result/{Discharge.pm => AdvancedEditorMacro.pm} (50%)
create mode 100644 api/v1/swagger/definitions/advancededitormacro.json
create mode 100644 api/v1/swagger/parameters/advancededitormacro.json
create mode 100644 api/v1/swagger/paths/advancededitormacros.json
create mode 100644 t/db_dependent/api/v1/advanced_editor_macros.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list