[koha-commits] main Koha release repository branch master updated. v19.11.00-2025-ge64d3c8d67
Git repo owner
gitmaster at git.koha-community.org
Mon May 4 10:22:59 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e64d3c8d675040aa8213c1b4d6ee93267b741986 (commit)
via 9776d591ece45b36365f69315e2c958f264bc76f (commit)
via 1f00c2a9a911b180d20638bafa26463d5e7a6619 (commit)
via 0650c9abdf1605030e86596c1000a91aaac8c5f5 (commit)
via 0e34f36d47fb2a5e7834b5f6b73e453d487d67b7 (commit)
via 3f752ce2b85bf600cca2e59b1bcd69a5854016aa (commit)
via 0610dbd6fce4ffcc1dff0c69424d70703afa722e (commit)
via a8d5b11629f74174c7e6169bfdc5ac969d9ed990 (commit)
via 83c65d975f8712c9d50ecf65033cdc1012698986 (commit)
via ebded0c3326e87aacba57c082d3ddf8fe37b510f (commit)
via 263a889be4f3ec002b779abe0917da664e9b6ade (commit)
via 569f3915d7212f580b7a5bf6c7767c6374c279dd (commit)
via 4317229ae9096453ece8464d09375488ff322e21 (commit)
via 3e4409155339139366d7cb586ee775a89d7f4c0b (commit)
via 1667a5af935115a812bc95db26d31521ccb5ee44 (commit)
from c6edd2d7f375f624a922bd59c1b275a9bdba6f97 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e64d3c8d675040aa8213c1b4d6ee93267b741986
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Fri Oct 20 23:22:13 2017 +0000
Bug 18308: Increase minPasswordLength default to 8
To test:
- Run the web installer for any language
- Verify that minPasswordLength is set to 8 now
Sponsored-By: Catalyst IT
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9776d591ece45b36365f69315e2c958f264bc76f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri May 1 12:43:40 2020 +0000
Bug 25340: Pass biblio object to OPAC comments template
This patch modifies the OPAC comments system so that the biblio object
is passed to the template. This allows the biblio-title include to
properly access the title and subtitle information.
Unrelated change: Remove some custom CSS from the page which was
obsolete.
To test, apply the patch and make sure the "reviewson" preference is
enabled.
- Log in to the OPAC and open a bibliographic record's detail page.
- Under the "Comments" tab, click the "Post your comments" link to
trigger the pop-up window.
- In the pop-up window, verify that the item's title is correct in the
page title and the heading. Author should display correctly, if
present.
- Test submitting a comment and editing a comment. Everything should
work correctly.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1f00c2a9a911b180d20638bafa26463d5e7a6619
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Sun May 3 19:19:21 2020 -0300
Bug 24636: (follow-up) - move 'by' into include file
To ease correct translation.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0650c9abdf1605030e86596c1000a91aaac8c5f5
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Tue Apr 28 21:21:09 2020 -0300
Bug 24636: translate planning sections
This patch adds a new inc file to process
and translate plannig sections
To test:
1) Apply patch
2) Create new language files
(cd misc/translator; ./translate create xx-YY)
3) Verify new file is taken into account in
translation files
egrep -n budget_planning misc/translator/xx-YY*.po
check new strings in staff-prog file
4) Go to Administration > Budgets > Founds > Planning
select different options, check page title and
'Planning for...' phrase
5) Translate strings, install new language, enable it,
verify the text change with options like point 4)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0e34f36d47fb2a5e7834b5f6b73e453d487d67b7
Author: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Date: Thu Apr 30 19:35:51 2020 +0000
Bug 25335: group by authorised_value in addbiblio.pl
To Test:
1- Edit your default framework, connect any subfield outside of the 952 to an authorised value (for example, connect the 942$n to the Yes_No auth value)
2 - Find a record in that framework
3 - Edit the record and find your subfield
4 - The subfield shows a dropdown with no contents
5 - check plack log, see "DBD::mysql::st execute failed: 'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY "
6 - apply patch, restart all
7 - reload edit record page, see your auth value dropdown has contents
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3f752ce2b85bf600cca2e59b1bcd69a5854016aa
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Apr 21 12:06:09 2020 +0000
Bug 25133: (follow-up) Remove Names as they do no affect display
In testing I couldn't make any changes to the names have an effect
and everythign worked as expected without these lines
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0610dbd6fce4ffcc1dff0c69424d70703afa722e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 20 10:59:55 2020 +0200
Bug 25133: Handle 12hr format for dt_from_string
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a8d5b11629f74174c7e6169bfdc5ac969d9ed990
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 17 12:11:25 2020 +0200
Bug 25133: Fix time part of due date for 12hr
With Timeformat system preference set to 12 hours format:
Prior to 19.05.08, when due date was specified at checkout,
the time in the box would show in 24hr format (e.g. 15:59)
while the due date in the patron's checkouts would show
in 12hr format (e.g. 3:59 PM).
After 19.05.08, the format in the specify a due date box
shows in 24hr format and the due date in 12hr format
(in patron checkouts) as before.
But when checking out multiple items using the specify due
date option for the session, the time changes from PM to
AM.
To test:
- Check out an item with specified due date 15:50 PM
- Check out a second item in same transaction
- Verify date changed to AM
- Apply patch
- Repeat
- Verify this time the date is kept as set
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 83c65d975f8712c9d50ecf65033cdc1012698986
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 29 11:53:45 2020 +0200
Bug 25305: Translation process - Open all files specifying the utf8 encoding
To test:
1) Create translation files for a new language
( cd misc/translator; ./translate create xx-YY)
A new language means one that isn't already in Koha, xx-YY=>something you
invent.
2) Verify double encoding
egrep "Aix-Marseille|Jean Prunier|periodika|Bokm" misc/translator/po/xx-YY-*
check strange strings
3) Apply the patch
4) Create po files again
( cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY)
5) Verify no more double encoding
egrep "Aix-Marseille|Jean Prunier|periodika|Bokm" misc/translator/po/xx-YY-*
check normal string
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ebded0c3326e87aacba57c082d3ddf8fe37b510f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Apr 27 13:20:23 2020 +0000
Bug 22515: Improve logic determining how to show OPAC suggestions
This patch makes changes to the OPAC suggestions view so that the logic
around logged in users and the OPACViewOthersSuggestions preference is
more specific.
To reproduce the bug you should have pending purchase susggestions in
your system from more than one patron.
1. Set the OPACViewOthersSuggestions preference to "Show."
2. Log in to the OPAC as a user who has not submitted any suggestions.
3. Follow the link to the purchase suggestions page from the menu under
the search bar.
4. The page will say that there are no purchase suggestions.
5. Add "?suggested_by_anyone=1" to the end of the page URL.
6. You should see suggestions from other users.
To test, apply the patch and repeat steps 2-3 above. The suggestions
page should show other patrons' suggestions.
Test with different combinations of factors:
- Logged in user, OPACViewOthersSuggestions off
- No logged in user, OPACViewOthersSuggestions on
- No logged in user, OPACViewOthersSuggestions off
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 263a889be4f3ec002b779abe0917da664e9b6ade
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Apr 22 12:11:53 2020 +0000
Bug 25247: Only convert data ot objects when displaying on screen
To test:
1 - Modify a patron
2 - Circulate some items to the patron
3 - Click 'Modification log'
4 - Verify you see your actions
5 - Under 'Output' select 'To a file'
6 - Save the output to a file
7 - View the file
8 - Not you have references ot objects in stead of patron/item data
9 - Apply patch
10 - Repeat
11 - Note viewing on screen has not changed
12 - Note exporting to file inlcudes borrower/item numbers and not references
13 - Sign off
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 569f3915d7212f580b7a5bf6c7767c6374c279dd
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Apr 29 17:57:44 2020 +0000
Bug 21565: (follow-up) Make confirmation buttons more detailed
This patch updates the confirmation buttons to be more specific about
what each one does. My concern was that it wasn't clear that "No" meant
"No receipt" and not "Cancel logging out."
The patch also updates the modal confirmation code so that the modal
body is removed if no message is passed for it.
To test, apply the patch and repeat the previous test plan. When you
click "Finish" you should have the options "Print receipt and end
session" and "End session."
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 4317229ae9096453ece8464d09375488ff322e21
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Fri Apr 24 18:39:02 2020 +0000
Bug 21565: Add modal to SCO confirm
This patch uses the confirmModal framework to add a modal confirm to
SCO Finish.
TO TEST:
1. Enable SCO and go to /cgi-bin/koha/sco/sco-main.pl. Make sure
SelfCheckReceiptPrompt is set to 'show'
2. Login and click 'Finish' to see the old print alert box.
3. Apply patch and repeat steps 1 and 2.
4. Make sure the modal works for confirming and denying a receipt.
Checkout some items and make sure everything still functions the
same.
5. Make sure when printing a receipt that the print dialog automatally
shows
6. Set SelfCheckReceiptPrompt to 'Don't show' and confirm behavior is
acceptable.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3e4409155339139366d7cb586ee775a89d7f4c0b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Apr 10 06:58:43 2020 -0400
Bug 25107: Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType
At some point some calls to maybe_add got an extra $server var in their
parameter lists. This doubled parameter does nothing and should be
removed.
Test Plan: No change in behavior should be noted
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1667a5af935115a812bc95db26d31521ccb5ee44
Author: David Roberts <david at koha-ptfs.co.uk>
Date: Mon Apr 6 23:42:19 2020 +0000
Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a
This patch makes the subfield i display before subfield a in the 246 and
730 fields
To test:
1) Create a bibliographic record with data in several subfields in tags
246 and 730.
2) See that subfield i displays at the end of the field in the 246
field, and probably not at all in the 730 field. Check in both the OPAC
and staff client
3) Apply the patch.
4) Check your bib record again in both clients. Subfield i should now
display before subfield a.
Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/SIP/Sip/MsgType.pm | 30 +++++++++++-----------
C4/TTParser.pm | 3 ++-
Koha/DateUtils.pm | 9 +++++++
cataloguing/addbiblio.pl | 2 +-
circ/circulation.pl | 2 +-
installer/data/mysql/sysprefs.sql | 2 +-
.../prog/en/includes/budget_planning.inc | 7 +++++
.../intranet-tmpl/prog/en/includes/calendar.inc | 4 +++
.../intranet-tmpl/prog/en/modules/admin/aqplan.tt | 5 ++--
.../prog/en/modules/circ/circulation.tt | 2 +-
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 15 ++++++++---
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 6 ++---
.../opac-tmpl/bootstrap/en/modules/opac-review.tt | 11 +++-----
.../bootstrap/en/modules/opac-suggestions.tt | 18 ++++++++++---
.../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 17 +++++++-----
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 15 ++++++++---
koha-tmpl/opac-tmpl/bootstrap/js/global.js | 6 ++++-
misc/translator/xgettext.pl | 6 ++---
opac/opac-review.pl | 3 +--
t/DateUtils.t | 13 +++++++++-
tools/viewlog.pl | 4 +--
21 files changed, 123 insertions(+), 57 deletions(-)
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/budget_planning.inc
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list