[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-41-g0c64138dd1

Mon May 4 23:24:23 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  0c64138dd1787dd35c06cad1512dd1a2de470bfb (commit)
       via  cac73b47ef221b32a6254fd25f22c86bcdd20c20 (commit)
       via  ef9f3adbddbffdf0f734e68e11a0c0424d6ec975 (commit)
       via  85e4d6585bd7a9c41730b0073bc3045311e5660e (commit)
       via  0693b3758507dae5460cdd6f1fd9affa5f635933 (commit)
       via  56c629d969b0de56f1202799d7ab11705fc39d90 (commit)
      from  e370007f0e04945a82a1fa1af42bfc84ab8855b4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0c64138dd1787dd35c06cad1512dd1a2de470bfb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Apr 8 10:52:23 2020 -0400

    Bug 22778: Add unit test

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit cac73b47ef221b32a6254fd25f22c86bcdd20c20
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Apr 25 15:50:35 2019 -0400

    Bug 22778: Suggestions with no "suggester" can cause errors

    If one tries to modify a suggestion that has no suggester you will get the following error:

    Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506

    Koha assumes that every suggestion has a borrowernumber in suggestedby

    Test Plan:
    1) Create a suggestion with an unpopulated suggestedby
    2) Attempt to modify that suggestion
    3) Note the error
    4) Apply this patch
    5) Restart all teh things
    6) Attempt to modify that suggestion
    7) No error!

    Signed-off-by: David Roberts <david at koha-ptfs.co.uk>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ef9f3adbddbffdf0f734e68e11a0c0424d6ec975
Author: Theodoros Theodoropoulos <theod at lib.auth.gr>
Date:   Wed Apr 8 08:21:12 2020 +0100

    Bug 23514: Split Call Numbers for all layout types

    This patch ensures call numbers are properly split for layout types
    other than 'BAR'.

    Test plan:

    1. Go to Label Creator and choose/create a Label Layout with "Choose
    layout type: Biblio"
    2. make sure you have at least "itemcallnumber" in Bibliographic data to
    print/Data fields
    3. check "Split call numbers" box and save the layout (ie testlayout)
    4. create a label batch, using items that have a call number (ie
    DC611.B848 H84 1997). LCC is used here, but you may try with Dewey as
    well.
    5. export selected batch using any template and the layout you created
    in previous step to a PDF
    6. Call numbers are splitted (as expected) in the resulting PDF file
    7. edit the layout you created in the previous step (ie testlayout) and
    change the  "Choose layout type:" to either Biblio/Barcode (BIBBAR) or
    Barcode/Biblio (BARBIB)
    8. export the same batch using the same template and layout as before
    9. Call numbers are NOT splitted at all

    After patch is applied, call numbers splitting functions are applied
    even in Biblio/Barcode (BIBBAR) or Barcode/Biblio (BARBIB) layout types.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 85e4d6585bd7a9c41730b0073bc3045311e5660e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 8 11:45:51 2020 +0200

    Bug 25081: Fix wrong comment

    Not directly related to previous patch, coming from 23435.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0693b3758507dae5460cdd6f1fd9affa5f635933
Author: Janusz Kaczmarek <januszop at gmail.com>
Date:   Tue Apr 7 22:23:20 2020 +0200

    Bug 25081: Fix creation of new item for a received issue

    The Bug 23435 introduced the idea of multiple copies added while
    receiving a new issue.  Unfortunately, under some circumstances, it
    causes no items being added at all.  It occurs stochastically, only
    under some conditions.  But it is quite likely to happen while receiving
    a supplemental issue.

    The reason fot hist is that, in serials-edit.pl, line ca 292 and infra,
    @num_copies is treated in the same way as @tags, while it should be
    treated similarly to @bibnums.  It will be obvious after examining the
    content of parameters tag, subfield, field_value, ..., number_of_copies.
    In other words, for every edited issue number_of_copies is a scalar.

    Nota bene:
    a) beter to initialize $countdistinct with zero;
    b) note that in master, now, before applying the patch,
    $itemhash{$item}->{'num_copies'} is treated once as a scalar
    and in the next line--as an array:

    $itemhash{$item}->{'num_copies'} //= 1;

    for (my $copy = 0; $copy < $itemhash{$item}->{'num_copies'}[$index];){

    TEST PLAN
    =========
    1. Have a subscription with the option "Create an item
    record when receiving this serial" active and try to receive a
    supplemental issue.  Control that a new item under the biblio record
    (usually) will not be created.
    2. Apply the patch.
    3. Repeat p. 1 -- a new item should be created.

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 56c629d969b0de56f1202799d7ab11705fc39d90
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Mar 27 12:01:05 2020 -0400

    Bug 22937: Add hint to groups editor

    Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Labels/Label.pm                                 |  2 +-
 C4/Suggestions.pm                                  |  3 +-
 .../prog/en/modules/admin/library_groups.tt        |  2 ++
 serials/serials-edit.pl                            |  8 ++---
 t/db_dependent/Suggestions.t                       | 35 +++++++++++++++++++++-
 5 files changed, 43 insertions(+), 7 deletions(-)

hooks/post-receive
-- 
main Koha release repository