[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-52-g0b7d3b4331

Tue May 5 00:05:06 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  0b7d3b4331c69238ae04fdb895baeae9ce0742cf (commit)
       via  71eb787fbd34294ff6df995fa74d930dec4f4057 (commit)
       via  82bee9fe6a28e70393d382b03db884d1eb142ddf (commit)
       via  9845c93cc7d1b072ec2c79d7f16a21f00935f3ef (commit)
       via  93d95ac1b3feaf5482b6a1a25c9d4198837e675c (commit)
       via  48d42a68794c3bf85c087adf2185d979929a13bc (commit)
       via  68588e017595de632b0bd4dd03f8e05c43fa240e (commit)
       via  b216f20dd684c80663567b17f9005e79e113abb2 (commit)
       via  61b348118ada5a1520a2ad44ae7697a30be9f885 (commit)
       via  c6c6c57400a9941a027ce8f919c652567ed37710 (commit)
       via  de56296d36ef8102f1d90e90e1617bd87c9879d8 (commit)
      from  0c64138dd1787dd35c06cad1512dd1a2de470bfb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0b7d3b4331c69238ae04fdb895baeae9ce0742cf
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Thu Mar 26 22:46:26 2020 +0000

    Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature

    TEST PLAN:
    1. Make a new news item and use the TinyMCE editor, click on the <> icon to go to the Source code editor
    2. Add some HTML like <i class="fa fa-facebook-official" aria-hidden="true">TEST</i> and save it.
    3. Go back in and notice that TinyMCE has changed it to: <p><em class="fa fa-facebook-official">TEST</em></p>
    4. It should not auto clean up and also it should not autowrap with <p> tag.
    5. Apply patch patch, and repeat step 2. Save again.
    6. It should not have automatiicly changed any HTML or added any <p> wrapper.

    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 71eb787fbd34294ff6df995fa74d930dec4f4057
Author: Marcel de Rooy <mdry at live.nl>
Date:   Thu Mar 19 14:39:14 2020 +0100

    Bug 24903: Add tests for _handle_seqno

    Trivial tests.

    Test plan:
    Run t/Serials/ModSerialStatus.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 82bee9fe6a28e70393d382b03db884d1eb142ddf
Author: Marcel de Rooy <mdry at live.nl>
Date:   Thu Mar 19 14:20:38 2020 +0100

    Bug 24903: Special characters like parentheses in numbering pattern cause duplication in recievedlist

    Test plan:
    Use serial with a numbering pattern with parentheses like "2018 (No. 1)".
    Mark serial issue as arrived, check receivedlist on summary.
    Edit issue again, check if not duplicated on receivedlist.
    Mark issue as missing or not available, check missinglist.
    Mark missing issue as not missing, check list again.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 9845c93cc7d1b072ec2c79d7f16a21f00935f3ef
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 7 13:25:09 2020 +0200

    Bug 25038: Fix tabs on the OPAC reading history view

    OPAC reading history table has three tabs for different checkout types: All, Checkouts, On-site checkouts.

    However, all of your checkouts are visible every tab regardless of checkout type.

    Test plan:
    1. Enable OnSiteCheckouts system preference
    2. Perform two checkouts: one normal checkout, one on-site checkout
    3. Go to OPAC /cgi-bin/koha/opac-readingrecord.pl
    4. Observe your checkouts all are visible in first tab
    5. Select second tab and notice that the table is now filtered
    6. Same with third tab

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 93d95ac1b3feaf5482b6a1a25c9d4198837e675c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Apr 10 06:43:51 2020 -0400

    Bug 24966: Add unit tests

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 48d42a68794c3bf85c087adf2185d979929a13bc
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Apr 10 09:50:13 2020 +0000

    Bug 24966: (QA follow-up) Fix return value of hold_patron_bcode

    It is used in list context, but we need a scalar value.
    Can be fixed by adding scalar's, or returning empty string as here.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 68588e017595de632b0bd4dd03f8e05c43fa240e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Apr 3 11:16:39 2020 +0100

    Bug 25040: monkeypatch Schema::Loader for recent MariaDB

    Recent versions of MariaDB changed the output of 'DESCRIBE' for
    timestamp columns with defaults from `CURRENT_TIMESTAMP` to
    `current_timestamp()`.  As such the code inside
    DBIx::Class::Schema::Loader which catches such cases and outputs
    `\"current_timestamp"` as a sensible cross platform default is missed
    and this leads of inconsistent class files and bugs with out default
    lookup code in Koha::Objects.

    This patch serves as a backport of the code I have submitted upstream
    such that out developers can continue to use update_dbix_class_files.pl
    to build their schema classes from the database and regardless of their
    db server version get a consistently correct output.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit b216f20dd684c80663567b17f9005e79e113abb2
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 3 12:14:27 2020 +0000

    Bug 25050: Adjust marc_records_to_documents to search entire mapping array

    There was an assumption in the ES code that match-heading mappings will appear in
    a specified portion of the mappings array.

    Certain mappings setups will not meet this assumption.
    We need to move our searching up one level

    The key seems to be having a mapping for a complete field, say 150, in both the
    match-heading and another field as well as having mappings for ungrouped fields like
    150a 150ab etc.

    The unit test coverage should be sufficient for testing

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 61b348118ada5a1520a2ad44ae7697a30be9f885
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 3 12:12:49 2020 +0000

    Bug 25050: Unit tests

    This patch simplay alters the data we use for the tests, doing so causes them to fail

    To test:
    1 - Apply only this patch
    2 - prove -v t/Koha/SearchEngine/Elasticsearch.t
    3 - It fails!
    4 - Apply next patch
    5 - It passes!

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit c6c6c57400a9941a027ce8f919c652567ed37710
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Mon Mar 16 22:09:51 2020 +0000

    Bug 24266: (alternate patch) Only use defined borrowernumbers in reconcile_balances.pl cron

    I believe the error is triggered when borrowernumbers are left empty in
    the accountlines table. Not sure why this would happen, but it appears
    to be what causes the problem.

    Do not apply the first patch if testing this patch.

    To test:
    1) sudo koha-mysql INSTANCENAME
    2) Create a test borrower, add any payment etc to create an accountline,
        then delete this borrower
    3) ensure the AccountAutoReconcile syspref is disabled
    4) Go to another borrower's accounting tab
    5) Create a manual credit or debit. Confirm this shows in the 'Make a
    payment' tab as an amount that COULD be applied, but isn't automatically
    applied
    6) in your terminal, run the reconcile_balances.pl script
    7) Confirm the error does not show in the logs and the balance for
    the borrower is correctly reconciled.

    Sponsored-by: Horowhenua District Council
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit de56296d36ef8102f1d90e90e1617bd87c9879d8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Apr 9 08:24:44 2020 -0400

    Bug 25095: Remove warn left in FeePayment.pm

    It appears that a debugging statement was accidentally left in FeePayment.pm by bug 5605.

    Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/SIP/ILS/Item.pm                                 |  4 +-
 C4/SIP/ILS/Transaction/FeePayment.pm               |  2 -
 C4/Serials.pm                                      | 29 ++++++++---
 Koha/Schema/Loader/mysql.pm                        | 59 ++++++++++++++++++++++
 Koha/SearchEngine/Elasticsearch.pm                 |  2 +-
 .../prog/en/modules/tools/koha-news.tt             |  4 ++
 .../bootstrap/en/modules/opac-readingrecord.tt     | 10 ++--
 misc/cronjobs/reconcile_balances.pl                |  3 +-
 misc/devel/update_dbix_class_files.pl              |  8 ++-
 t/Koha/SearchEngine/Elasticsearch.t                | 41 ++++++++++++---
 t/Serials/ModSerialStatus.t                        | 38 ++++++++++++++
 t/db_dependent/SIP/Message.t                       | 32 +++++++++++-
 12 files changed, 205 insertions(+), 27 deletions(-)
 create mode 100644 Koha/Schema/Loader/mysql.pm
 create mode 100755 t/Serials/ModSerialStatus.t

hooks/post-receive
-- 
main Koha release repository