[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-107-g9018cefc25
Git repo owner
gitmaster at git.koha-community.org
Fri May 8 23:22:50 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via 9018cefc25d330355778f56159459a9f4abcf30a (commit)
via 303ade2dce48f6dacd8ed576fdc49ce51eb5341d (commit)
via bedf692a3c348612f7e97dd2d0e428cab257185d (commit)
via 66c0ab283a364f34ca470938b847366d3117153a (commit)
via a656ccf5376287c9a572e2db4771dae12a4c1afa (commit)
via 77a59b5b3ab8a8870ca9bf9842d1ad30104a05d3 (commit)
via 2c9e0ac020c99fbcecfe53e6f5588ce2ece4a1fa (commit)
from bfa97dc73ca24f41dcabef058e7e50c42f29e0ef (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9018cefc25d330355778f56159459a9f4abcf30a
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Tue Apr 21 21:33:03 2020 +0000
Bug 25233: Staff XSLT material type label "Book" should be "Text"
This patch makes the staff client XSLT stylesheets consistent with the
ones for the OPAC, it also makes consitent the use of 'Text' when the leader6 = 't'
TO TEST:
1. Have a record with leader06 = 'a' and leader07 = 'c' 'd' or 'm'.
2. Check the staff client results and details page. See that the
material type label says "Book"
3. Check the OPAC client results and details page. See that the
materila type label says "Text"
4. Apply patch.
5. See that both staff client and OPAC results/details all now say
"Text"
6. Set the leader6 = 't' and make sure that is says 'Text' on both the
staff client and OPAC
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 303ade2dce48f6dacd8ed576fdc49ce51eb5341d
Author: Joy Nelson <joy at bywatersolutions.com>
Date: Fri May 8 20:52:03 2020 +0000
Bug 25276: Compiled CSS
commit bedf692a3c348612f7e97dd2d0e428cab257185d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Apr 24 14:24:07 2020 +0000
Bug 25276: Correct hover style of list share button in the OPAC
This patch adds missing "btn" classes to the OPAC share button so that
its style is consistent with similar controls.
The patch also makes some general changes to the OPAC CSS to make sure
link color and hover color are applied with enough specificity. This
corrects the hover color of the share button but should not change any
other existing style.
To test you should have the OpacAllowSharingPrivateLists preference
enabled.
- Rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
- Log in to the OPAC as a user with one or more private lists.
- Go to Lists -> Your lists.
- In the list of lists there should be a "Share" link for each list.
Hovering your mouse pointer over the link should change the style in
the same way the "Edit" link does.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 66c0ab283a364f34ca470938b847366d3117153a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Apr 20 11:38:41 2020 +0000
Bug 25211: Add missing share icon to OPAC lists page
This patch adds a Font Awesome icon to the "Share" links on the list of
lists in the OPAC.
To test, apply the patch and log in to the OPAC as a user who has one
or more private lists.
- Go to Lists -> Your lists
- In the table of your lists, each list should have a "Share" link
with an icon.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a656ccf5376287c9a572e2db4771dae12a4c1afa
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Tue Apr 21 20:11:17 2020 +0000
Bug 24957: OpenLibrarySearch shouldnt display if nothing is returned
TO TEST:
1. Turn on OpenLibrarySearch
2. Do an OPAC search that returns results that have results with Open Library results and some that do not.
3. Notice results that return nothing simpliy say "Open Library:" with nothing afterwards.
4. Some results return a png from OpenLibrary or "Not found"
5. Apply patch and look at records again.
6. The results that return nothing for OpenLibrary API should now to hidden.
Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 77a59b5b3ab8a8870ca9bf9842d1ad30104a05d3
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Apr 12 03:19:03 2020 +0000
Bug 21927: Acq - Add blank values in pull downs of mandatory item subfields
This is the same fix as on bug 14662, which fixed the behaviour in
cataloguing, but for the item form in acquisitions.
The code assumes that if a subfield is marked as mandatory, there
should be no empty entry in the pull downs.
This assumption is not correct, as it leads to the first entry of the
pull down being preselected if there is no default set. As the field
can never be 'unset', there will never be a 'required' warning.
Furthermore, it might be counterproductive to use mandatory fields,
as it might be easily forgotten to change the preselected value and
those mistakes will be hard to find.
Correct behaviour would be to preselect the empty value when there is
no default. This means on saving the item an error message is triggered
and the cataloger is forced to set the value.
To test:
- This is best tested with an ACQ framework, but default can be used
when no ACQ framework was created.
- In your MARC bibliographic framework:
- In 952 make itemtype, classification source and some other pull downs
like location or collection mandatory and set them to visibel if needed
- Create a new basket with 'items created while ordering'
- Add a new order, an existing record with 942$c set will work best
- Add items for your order line
- Verify that the first value of each pull down is preselected,
there is no way to trigger the 'required' error
- Apply patch
- Add a new order line
- Verify that classification source is preselected according to the
DefaultClassificationSource system preference (try unsetting it later)
- Verify all mandatory fields can be set to empty
- Verify that you can't save before correctly setting them
- Change your frameworks and set a default for itemtype (Ex: BK) and
another mandatory and non-mandatory field of your choice
- Add a new order line and item and verify the defaults are selected
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2c9e0ac020c99fbcecfe53e6f5588ce2ece4a1fa
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Apr 24 11:49:21 2020 +0000
Bug 25274: Don't initialize DataTable if table isn't present
This patch modifies the OPAC basket JavaScript so that a check is added
for the existence of the "itemst" table. This avoids an error if the
"More details" view is selected and hte "itemst" table isn't present.
To reproduce the error, add some items to the OPAC cart and open the
cart window. Open the JavaScript console in your browser and click the
"More details" link. You'll see an error.
To test, apply the patch and perform the same test as above. The error
should not be present. Test that table sorting in the "brief" view words
correctly.
Signed-off-by: David Roberts <david at koha-ptfs.co.uk>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Items.pm | 8 ++---
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 4 +--
.../prog/en/xslt/MARC21slim2intranetResults.xsl | 4 +--
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss | 1 +
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 26 ++++++++------
.../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 41 +++++++++++-----------
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js | 2 ++
9 files changed, 49 insertions(+), 41 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list