[koha-commits] main Koha release repository branch master updated. v20.05.00-1452-g9e5ea4f5ab
Git repo owner
gitmaster at git.koha-community.org
Thu Oct 22 10:56:50 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 9e5ea4f5ab81cb500f112a5858130f82a6b4fd65 (commit)
via 0a60c96930ae4f702cd7bb1807188394e29aea44 (commit)
via 8a5cda8b7ad9af8fcbaa9d5a850946000066a281 (commit)
via c6dddaec1b9e735feb9ad666d49485d44a5d63b5 (commit)
via 759ff4519961d0c256eb05a4797fb21c3b2c22d9 (commit)
via 0eae966d257fa2ecc6a6506e2515691e092a701c (commit)
via 890fd6ff068f58da4c72194ebc14be2cf479040b (commit)
via 0cb4300675405d37230ee427137daff2d6bdb4d9 (commit)
via fd35df346f73a00b643e675853ba2c8ef321cf66 (commit)
from b9b02000eb2602374ca0bfeade53c519b463d148 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9e5ea4f5ab81cb500f112a5858130f82a6b4fd65
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 20 14:40:50 2020 -0300
Bug 26751: Fix fatal exception if only one repo defined
This patch fixes this nasty problem with how XML is parsed: if more than
one entry is found, repo => [] is generated. If only one, repo => {}.
To test:
1. Have more than one entries in the plugins_repo entry:
<plugin_repos>
<repo>
<name>ByWater Solutions</name>
<org_name>bywatersolutions</org_name>
<service>github</service>
</repo>
<repo>
<name>Theke Solutions</name>
<org_name>thekesolutions</org_name>
<service>github</service>
</repo>
<repo>
<name>PTFS Europe</name>
<org_name>ptfs-europe</org_name>
<service>github</service>
</repo>
</plugin_repos>
2. Search for plugins
=> SUCCESS: Searching works!
3. Leave only one entry
4. Restart all to refresh things
5. Try searching for plugins
=> FAIL: Fatal error
6. Apply this patch
7. Repeat 5
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0a60c96930ae4f702cd7bb1807188394e29aea44
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Oct 19 10:57:25 2020 +0000
Bug 26735: Overdrive login modal broken in the OPAC
This patch makes corrections to the markup for the Overdrive login modal
in the OPAC. It hadn't been updated during the upgrade to Bootstrap 4.
To test, apply the patch and enable the system
preferences required for Overdrive integration.
- Log in to the OPAC.
- On the "Your summary" page open the "OverDrive Account" tab.
- Click the "Log in to your OverDrive account" link.
- The modal should appear and look correct.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8a5cda8b7ad9af8fcbaa9d5a850946000066a281
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Oct 16 15:04:31 2020 +0100
Bug 26581: Only reindex records once per checkin
This patch simply passes skip_record_index calls to Koha:Item:store
for all the changes done in AddReturn.
Testing is really verifiying that items are still correctly indexed at the end
For both search engines
To test:
1 - Find or create a record with multipel items
2 - Populate both:
UpdateItemLocationOnCheckin
UpdateNotForLoanStatusOnCheckin
3 - Confirm that checking in an item correctly updates the item status in search results
4 - Test with items issued, and items not issued
5 - Test when generating a transfer (checkin at different branch)
6 - Test when item was marked lost
7 - Test when filling transfer
Signed-off-by: Séverine Queune <severine.queune at bulac.fr>
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c6dddaec1b9e735feb9ad666d49485d44a5d63b5
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Sep 30 16:51:28 2020 +0000
Bug 26581: Unit tests
These tests cover the changes to ensure the AddReturn calls index_records once
per call and that other calls pass the skip_record_index parameter correctly
Signed-off-by: Séverine Queune <severine.queune at bulac.fr>
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 759ff4519961d0c256eb05a4797fb21c3b2c22d9
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Oct 7 16:37:06 2020 +0100
Bug 25549: Add error reporting to plugins-home
This patch adds handling for the newly introduced 'errors' option in
GetPlugins and reports erroroneos plugins to the user.
To test:
1 - Enable plugins in the koha-conf
2 - Install the kitchen sink plugin
3 - Your staff client should be orange now :-)
4 - The plugin should display as installed in the table at
tools/plugins.
5 - edit the plugin module
/var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm
6 - Add a line to break compilation, like:
this won't compile
7 - Restart all
8 - Your Koha is not broken, but is no longer orange (The plugin is not
loading).
9 - The plugin should display as unable to load in the table at
tools/plugins.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0eae966d257fa2ecc6a6506e2515691e092a701c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed May 20 11:12:12 2020 +0000
Bug 25549: Remove plugin methods for broken plugins
To test:
1 - Enable plugins in the koha-conf
2 - Install the kitchen sink plugin
3 - Your staff client should be orange now :-)
4 - edit the plugin module
/var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm
5 - Add a line to break compilation, like:
this won't compile
6 - Restart all
7 - Your koha is now broken
8 - kshell
9 - perl misc/devel/install_plugins.pl
10 - Restart all
11 - Koha remains broken
12 - Apply patch
13 - kshell
14 - perl misc/devel/install_plugins.pl
15 - Koha now works!
16 - Koha is not orange because the plugin methods are removed
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 890fd6ff068f58da4c72194ebc14be2cf479040b
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Sep 16 11:31:54 2020 +0000
Bug 23828: Elasticsearch - Preserve record order when combining subfield in mappings
Currently if you combine subfields in the marc mappings the subfields are indexed in the order
listed in the mapping.
i.e. 650(avxyz) in mapping
and in record:
650 $aHeading $zGeosubdiv $vFormsubdiv
is indexed as:
Heading Formsubdiv Geosubdiv
We should preserve the order and index as:
Heading Geosubdiv Formsubdiv
We can use built in function in Marc::Field to achieve this
To test:
1 - It is easy to find examples of this using authorities
2 - Find or create a record with subfields order azv
e.g. 150$aActresses$zUnited states$vBiography
3 - Add or have a second authority
e.g. 150$aActresses$vPortraits
4 - Set an authorities mapping for 'Heading' to 150(abgvxyz)
find at:
Administration->Search engine configuration (Elasticsearch)->Authorities tab
5 - Index the records in Elasticsearch
perl misc/search_tools/rebuild_elaticsearch.pl -a -ai 1691 -ai 1692
6 - View the first record in the ES index
curl es:9200/koha_kohadev_authorities/data/1692?pretty
7 - Note 'Heading' field is ordered as in the mapping
8 - Search authorities for 'contains' "act"
9 - Note the records sort incorrectly
10 - Apply patches
11 - perl misc/search_tools/rebuild_elaticsearch.pl -a -ai 1692
12 - curl es:9200/koha_kohadev_authorities/data/1692?pretty
13 - Note the order is now preserved
14 - Search authorities for 'contains' "act"
15 - Note the records sort correctly
Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
JD amended patch: Fix
FAIL spelling
combind ==> combined
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0cb4300675405d37230ee427137daff2d6bdb4d9
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Sep 16 11:31:48 2020 +0000
Bug 23828: Unit tests
Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov>
Bug 23828: (follow-up) fix unit test merge
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Bug 23828: (QA follow-up) Fix number of tests
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fd35df346f73a00b643e675853ba2c8ef321cf66
Author: David Cook <dcook at prosentient.com.au>
Date: Mon Sep 21 02:02:27 2020 +0000
Bug 26496: Add op field to Budget Planning
Without this patch, it's impossible to save a budget plan.
With this patch, it is possible to save a budget plan.
Test:
1. Apply patch
2. Modify a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form&budget_period_id=1)
3. Unlock the budget if necessary by unticking "Lock budget" and click "Save"
4. Go to a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1)
5. Click "Planning" and "Plan by libraries"
6. Click "Auto-fill row" on the first line
7. Click "Save"
8. Note that results are saved and shown on the newly loaded page
To verify this patch is necessary, do the test plan without applying the patch.
Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 40 ++++++++-----
C4/Items.pm | 18 +++---
Koha/Plugins.pm | 39 +++++++------
Koha/SearchEngine/Elasticsearch.pm | 11 +---
.../intranet-tmpl/prog/en/modules/admin/aqplan.tt | 1 +
.../prog/en/modules/plugins/plugins-home.tt | 15 +++++
.../bootstrap/en/includes/overdrive-login.inc | 38 +++++++------
misc/devel/install_plugins.pl | 10 +++-
plugins/plugins-home.pl | 17 ++++--
t/db_dependent/Koha/SearchEngine/Elasticsearch.t | 39 +++++++++----
t/db_dependent/Koha/SearchEngine/Indexer.t | 66 ++++++++++++++++++++--
11 files changed, 209 insertions(+), 85 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list