[koha-commits] main Koha release repository branch master updated. v20.05.00-1507-gdfbc2c9a80

Git repo owner gitmaster at git.koha-community.org
Mon Oct 26 00:47:56 CET 2020


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  dfbc2c9a80bb9af4069d73dab60e8007fa95856c (commit)
       via  6da94551f122373e9ec418d3c80035c599c18fb5 (commit)
       via  c85b3ee07f551644891c86a74d6d2f87bfc9bdeb (commit)
       via  ed789b0b57c7cde39d3bde3b3eaf46d81bf96bf6 (commit)
       via  cf12049ca1b71a5c5ef12092499fb39aea8f36e9 (commit)
       via  17f307285f5d877806ac95fe64ce154be03948b6 (commit)
       via  17723b5423fcf644026130d8cc75e58986c55efb (commit)
       via  46b371a057e619264ad1c8d39abbcce7745ae734 (commit)
       via  b3a51fbc552ad89d7ee4604ac502cd2e7a7a8667 (commit)
       via  16e5a9d8dcf7ab332a455ff74e23115fde27a10f (commit)
       via  5deb11623e52a531bd1c3a4cff80678800d973d0 (commit)
       via  240fdfdb63631ba6b2d84500ecbf93bf309d916e (commit)
       via  54dcce14139bf5c60e98603a667629141296580e (commit)
       via  d10d24e42aaaf4b2e23b52b94aa14ab8745b396f (commit)
       via  2dab6ab31626970e3c9be841b610575060f8f344 (commit)
       via  599a6cb92e26e37857b344484d6c8b233555f0dc (commit)
       via  ebe08fb745b04899404bed5ceb00c891a518e89c (commit)
       via  70c64fad46a91f910a00d59149000b982705fd24 (commit)
       via  7b8bcd9dc3b19534c52a7cdbb91bbac5a5cf5db3 (commit)
       via  3c8bef50a223e70fe3023222f5f940a2b1771b5d (commit)
       via  1193dddd8beb4a10a78e385b221c0f908d92dcf6 (commit)
       via  2800b53bdd6df1e87f72673bc79ed4896f4e4e35 (commit)
       via  1ee81885b809a95fa12bf39dd0ce1bd839218aef (commit)
       via  0ce62b29bf5ebe30125eb4c631de11391134f109 (commit)
       via  22be7246e534db158afbf38e1171d05148397088 (commit)
       via  e692b40523839bda45a20e4cf1cac7cdfbf53a13 (commit)
       via  9f47b4ffd72211a216df67ef912b5eddb2b954db (commit)
       via  032166767869e36e8e0cec1cf4d54ea284a74105 (commit)
       via  8c99099e8c453be2e18d42ed1c0464fe9ff4824c (commit)
       via  7a2cb71c79ae630bcfe6f4bcfe63bfbfeaf4f550 (commit)
       via  60af6edbb15df1a6c667eb0cf547268b408eeb18 (commit)
       via  2dd19840449beadd1f1752bd8cc18f0163f7f8a4 (commit)
       via  be4f0c7639a679b1ec808e6e9cf9af0fc9576e79 (commit)
       via  a96de8283ba41ebff0d8e1a7c491fc5bcff5dc18 (commit)
       via  3a5d5367f10fa1101e99748aadf0c076ebd9dea7 (commit)
       via  e3183de77b4bd3ffb164c19b7933aef31039e723 (commit)
       via  a71596fb395d449a62f5a6417780ed23948755c4 (commit)
       via  28d20b92be91ae509a7f71586ada2535d3c2007d (commit)
       via  b3be51d4ef2145b7db7b48c9ee32f86ddd34a964 (commit)
       via  e5753d3cff9d763be420733ba4dbcd0ecf6baa23 (commit)
       via  b9d6b92ac108fd4753fb76346f5d236d8c59f874 (commit)
       via  974c93f908179ff16a162d8010ddbd9710fbff46 (commit)
       via  3edbe7d7dc9358e55b4ecc9da5b292a32cadcce9 (commit)
       via  615d97d345429417843a2dd32e838075b3e27495 (commit)
       via  3bd23a3287345167de50d994d737351174c04936 (commit)
       via  7c74c6636f779bbbaceee74f8704df9ec625815d (commit)
       via  4e865d9e72c8828f28aa133940a561981db740d0 (commit)
       via  a96f5deef04bb74fbd826449b4d82f651a67512c (commit)
       via  564ade93cce9231b01db1c4ebfc8f4e5b31e1acd (commit)
       via  70570debf3128f035d5eaf3d175c61c0ee1bbba3 (commit)
       via  23292b53a8bc672f66ae95b1cfb7db5994d1eea5 (commit)
       via  6adb1891d2bf602b0434eb87508568e73faa763e (commit)
       via  7e66d6d190af4bd27739bdfe88049899f927c123 (commit)
       via  f6d614d4596728a3a2808eac2539754023e42262 (commit)
       via  395bb760394e6947303de7e342882148944e9026 (commit)
      from  9e5ea4f5ab81cb500f112a5858130f82a6b4fd65 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dfbc2c9a80bb9af4069d73dab60e8007fa95856c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Oct 26 00:07:32 2020 +0100

    Bug 7143: Update about page for new devs
    
    John Fawcett
    Mark Hofstetter
    Tal Rogoff
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 6da94551f122373e9ec418d3c80035c599c18fb5
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Oct 24 00:21:55 2020 +0000

    Bug 26726: (QA follow-up) Add line break and 'the' for readability
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit c85b3ee07f551644891c86a74d6d2f87bfc9bdeb
Author: Tal Rogoff <tal.rogoff at cass.govt.nz>
Date:   Fri Oct 23 23:02:29 2020 +0000

    Bug 26726: changed the text of the "here" link on the transport cost matrix administration page
    
    test plan:
    1.Set the UseTransportCostMatrix system to disabled
    2.Go to Administration>Transport cost matrix
    3.Blue box at top of the page contains link labelled "here"
    4.Apply patch
    5.Refresh page
    6.Link should now be labelled "UseTransportCostMatrix"
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit ed789b0b57c7cde39d3bde3b3eaf46d81bf96bf6
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Fri Oct 23 23:13:20 2020 +0000

    Bug 26809: Removes full stops from admin-home.tt
    
    To be consistent with the formatting of the Tools module this patch removes
    full stops from administration descriptions.
    
    To test:
    1) Go to Administration module and note inconsistent use of full stops
    2) Apply the patch
    3) Go to Administration module and note absence of full stops on
    descriptions
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit cf12049ca1b71a5c5ef12092499fb39aea8f36e9
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Oct 24 02:07:51 2020 +0000

    Bug 26450: (QA follow-up) Replace tabs with spaces
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 17f307285f5d877806ac95fe64ce154be03948b6
Author: Andreas Roussos <a.roussos at dataly.gr>
Date:   Mon Sep 14 09:59:34 2020 +0200

    Bug 26450: fix typo in plugin template
    
    The UNIMARC field 105 plugin template contains some dropdown menu
    options with unnecessary capitalisation: "w - Religious text".
    
    This patch fixes that.
    
    Test plan: apply the patch, and confirm that the dropdown menu
    options appear in all lowercase.
    
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 17723b5423fcf644026130d8cc75e58986c55efb
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Oct 24 00:42:31 2020 +0000

    Bug 26725: (QA follow-up) Add line break and 'the' for readability
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 46b371a057e619264ad1c8d39abbcce7745ae734
Author: Tal Rogoff <tal.rogoff at cass.govt.nz>
Date:   Fri Oct 23 22:45:58 2020 +0000

    Bug 26725: link text changed to just system preference name. "system preference" put in sentence case.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b3a51fbc552ad89d7ee4604ac502cd2e7a7a8667
Author: Tal Rogoff <tal.rogoff at cass.govt.nz>
Date:   Fri Oct 23 22:10:59 2020 +0000

    Bug 26725: changed the text of the "here" link on the patron attributes administration page
    
    test plan:
    1. set ExtendedPatronAttributes system preferences to "Don't enable"
    2. go to Administration > Patron attribute types
    3. the link text of "here" is displayed in the blue box at the top of
    the page
    4. apply the patch
    5. refresh the page
    6. notice the link text has changed to "ExtendedPatronAttributes System
    Preference"
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 16e5a9d8dcf7ab332a455ff74e23115fde27a10f
Author: Phil Ringnalda <phil at chetcolibrary.org>
Date:   Fri Oct 2 15:35:04 2020 -0700

    Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record
    
    If you search for "this & that" and delete one of the results, after
    it is deleted the search in the reloaded page is for "this " rather
    than for "this & that". The template uses the url filter, which is
    for filtering an entire URI where :, &, #, etc. should be left alone,
    rather than the uri filter which is for filtering a URI component
    where they should be encoded.
    
    To test:
    1) Go to Authorities > New authority > New from Z39.50/SRU
    2) Search for the Author (corporate) this & that collective
    3) Actions > Import, Save
    4) From the detail for that authority, Edit > Edit as new (duplicate)
    5) Edit the 110 field, add 2 at the end and Save
    6) Search authorities for this & that
    7) For one of the ones you created, Actions > Delete, confirm
    8) The page that reloads should have a search for this & that, not
    just for this
    
    Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 5deb11623e52a531bd1c3a4cff80678800d973d0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Oct 26 00:15:59 2020 +0100

    Bug 26782: Compiled CSS
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 240fdfdb63631ba6b2d84500ecbf93bf309d916e
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Oct 22 18:08:08 2020 +0000

    Bug 26782: Add new class for indicating default sort without sortability
    
    This patch adds to the globally-included CSS a class which can be added
    to tables when they are configured using DataTables options that set a
    default sort but don't allow the user to reorder columns.
    
    The new class shows a grey rather than blue sorting indicator and sets
    the cursort to the default pointer rather than the link "hand."
    
    To test, apply the patch and rebuild the staff client CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    Go to Administration -> Circulation and fine rules
    
    In the table of circulation rules, confirm that the first two columns,
    "Patron category" and "Item type" have a grey sorting icon in the
    header cell indicating ascencing sort. Hovering the cursor over these
    cells should show a default arrow cursor rather than the link cursor.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 54dcce14139bf5c60e98603a667629141296580e
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Oct 21 17:15:30 2020 +0000

    Bug 26766: Correct selection of title during OPAC note confirmation
    
    This patch modifies the JavaScript in opac-user.tt which executes when
    the user submits a checkout note. The script tries to grab the
    checkout's title from an earlier cell in the table row so that it can
    display it in the confirmation message.
    
    Before start ratings were enabled on this page, the title of each
    checked-out item was the only HTML inside this table cell, so it was
    necessary only to grab the HTML contents of the <td>. Now that star
    ratings might be displayed as well we must make the selection more
    specific.
    
    To test, apply the patch and enable both the  OpacStarRatings and
    AllowCheckoutNotes preferences.
    
     - Log in to the OPAC as a user with checkouts.
     - On the "Your summary" page, fill out and submit the "Note" field for
       one of your checkouts.
     - In the confirmation message, confirm that the correct title
       information is displayed as a link to the bibliographic detail page.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d10d24e42aaaf4b2e23b52b94aa14ab8745b396f
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Oct 21 11:57:26 2020 +0000

    Bug 26762: Modify template logic in opac-reserves.tt to avoid error
    
    This patch makes a change to the OPAC hold template to prevent certain
    cases where the output is invalid.
    
    To reproduce, perform a search in the OPAC which will return some titles
    which can be placed on hold and some which cannot.
    
     - Select all results (some holdable, some not)
     - Click the "Place hold" link
     - On the "Confirm holds" page the layout will be broken after the
       first instance of the message "There are no items that can be placed
       on hold."
    
    To test, apply the patch and repeat the process above. After the patch
    has been applied the "confirm holds" page should look correct.
    Validating the HTML source should return no errors.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 2dab6ab31626970e3c9be841b610575060f8f344
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Oct 20 16:04:11 2020 +0000

    Bug 26756: Fix quotes showing behind some system preference descriptions
    
    This patch adds matching quotes to two OPAC preference descriptions
    which were missing them.
    
    To test, apply the patch and go to Administration -> System preferences.
    
    - Open the "OPAC" tab.
    - Check the descriptions of these preferences:
      - AllowPatronToSetCheckoutsVisibilityForGuarantor
      - AllowPatronToSetFinesVisibilityForGuarantor
    
    There should be no trailing quotation mark.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 599a6cb92e26e37857b344484d6c8b233555f0dc
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Oct 20 11:22:07 2020 +0000

    Bug 26619: Cart - The "Print" button is only translated when you are in "More details" mode
    
    This patch adds the "Print" string to datatables.js so that it can be
    picked up for translation.
    
    To test, apply the patch and add some items to the cart in the OPAC.
    
    - Open the cart. You should see a button labeled "Print."
    - The print button should work correctly.
    
    TESTING TRANSLATABILITY
    
    - Update a translation, e.g. fr-FR:
    
      > cd misc/translator
      > perl translate update fr-FR
    
    - Open the corresponding .po file for JavaScript strings,
      misc/translator/po/fr-FR-messages-js.po
    - Locate strings pulled from
      koha-tmpl/opac-tmpl/bootstrap/js/datatables.js for translation:
    
      msgid "Print"
      msgstr ""
    
    - Edit the "msgstr" string however you want (it's just for testing).
    - Install the updated translation:
    
       > perl translate install fr-FR
    
    - Switch to your newly translated language in the OPAC and
      repeat the test plan above. The translated strings should appear.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit ebe08fb745b04899404bed5ceb00c891a518e89c
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Oct 19 18:32:18 2020 +0000

    Bug 25353: Correct eslint errors in additems.js
    
    This patch makes minor changes to additem.js to correct errors
    highlighted by eslint:
    
    - Consistent indentation
    - Notation of global and exported variables and functions
    - Consistent use of the "var" declaration for all new variables
    - Remove variables from function calls which aren't used
    
    To test, apply the patch and use your preferred eslint-enabled tool to
    check for errors. There should be none.
    
    If you don't have eslint integrated in your development environment you
    could use the online ESLint demo at https://eslint.org/demo.
    
    The demo isn't configured to assume a browser environment with jQuery
    present, so you'll have to modify the top line after pasting the
    contents of additem.js:
    
    /* global $ alert window __ */
    
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 70c64fad46a91f910a00d59149000b982705fd24
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Oct 17 15:08:59 2020 +0000

    Bug 26526: Relabel checkout note column in OPAC
    
    When checkout notes are active, there is currently a new
    column labelled 'Note' in the checkouts table in OPAC.
    When a note is added, this is sent to the library. For
    the user it's not clear from the label, that these notes
    are not personal, but for reporting to the library.
    The new label "Report a problem" aims to make this clearer.
    
    To test:
    - Turn on AllowCheckoutNotes system preference
    - Check out some items to your account
    - Go to the OPAC
    - Look at the list of checkouts
    - Apply patch
    - Reload the page and check the checkouts table again
    - Verify the heading has changed from "Notes" to "Report a problem"
    - Hover over the heading with your cursor to see some more info
    
    Bonus: Patch adds an id "checkout-notes" to the header cell, that
    will make it easier for libraries to change text or style if needed.
    
    Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 7b8bcd9dc3b19534c52a7cdbb91bbac5a5cf5db3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Oct 25 23:12:15 2020 +0000

    Bug 18050: DBRev 20.06.00.055
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 3c8bef50a223e70fe3023222f5f940a2b1771b5d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Oct 5 06:17:34 2020 +0000

    Bug 18050: (QA follow-up) Adjust conditions and make use of message text
    
    - When we run into invalid data, we use Augustin's suggested solution
      and copy the data into a separate table, setting the budget_period_id to
      NULL.
    - We amend the output using the new $message.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 1193dddd8beb4a10a78e385b221c0f908d92dcf6
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Fri Oct 9 15:14:26 2020 -0300

    Bug 18050: (follow-up) Force adding FK constraint
    
    When there are inconsistent budget_period_id in aqbudgets this patch
    creates the table _bug_18050_aqbudgets with the original data, then sets
    the column to null and warns the user that there is inconsistent data.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 2800b53bdd6df1e87f72673bc79ed4896f4e4e35
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Sep 13 23:31:52 2020 +0000

    Bug 18050: Add relation alias to schema
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 1ee81885b809a95fa12bf39dd0ce1bd839218aef
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Sep 13 23:30:22 2020 +0000

    Bug 18050: DBIC schema changes
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0ce62b29bf5ebe30125eb4c631de11391134f109
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Sep 13 22:42:27 2020 +0000

    Bug 18050: Add FK constraint on aqbudgets.budget_period_id
    
    This adds a FK constraint on aqbudgets.budget_period_id so that
    a fund cannot be added with an invalid aqbudget.budget_period_id.
    
    We should not have funds that belong to no budget. In case we have, the
    update will be skipped and a note displayed.
    
    Part1:
    - Before applying the patch
    - Make sure you have a budget with some funds linked to it
    - You will have to change one of the funds to link to an invalid
      budget with SQL:
      UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id);
    - Apply patch
    - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget.
    - Repair your fund with SQL
      UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id);
      (... needs to be your existing budget_period_id)
    - Run updatedatabase again - verify it runs successfully now.
    - If you try to change the budget_period_id to a non-existing now with SQL, you will
      get a database error. The new FK doesn't permit it.
    Part 2:
    - Start fresh with the web installer, verify there are no errors on
      creating the database tables
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 22be7246e534db158afbf38e1171d05148397088
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Oct 12 11:48:12 2020 +0200

    Bug 24972: Remove de-DE installer data
    
    With installer data in YAML format and it's translations,
    there are no need for localized installer files.
    
    This patch removes de-DE installer files.
    
    1) Apply the patch
    2) Translate to de-DE
       cd misc/translator
       ./translate update de-DE
       ./translate install de-DE
    3) Do a clean install using de-DE,
       check no problems during install
    4) Verify MARC21 frameworks, they must
       be translated
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e692b40523839bda45a20e4cf1cac7cdfbf53a13
Author: David Cook <dcook at prosentient.com.au>
Date:   Wed Oct 14 22:53:24 2020 +0000

    Bug 26673: Remove #!/usr/bin/env perl from .pm modules too
    
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 9f47b4ffd72211a216df67ef912b5eddb2b954db
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 14 11:24:33 2020 +0200

    Bug 26673: Remove shebangs from Perl modules
    
    It's not needed.
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 032166767869e36e8e0cec1cf4d54ea284a74105
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Oct 20 11:58:49 2020 +0000

    Bug 26749: Correct dropdown markup in OPAC cart
    
    This patch corrects the markup of the "Download" dropdown menu in the
    OPAc cart. It was not updated during the upgrade to Bootstrap 4.
    
    To test, apply the patch and perform a catalog search in the OPAC.
    
    - Add some titles to the cart.
    - Open the cart and test the "Download" menu button.
    - The menu should display correctly, and the menu items should work to
      download the correct files.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 8c99099e8c453be2e18d42ed1c0464fe9ff4824c
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Oct 16 18:08:44 2020 +0000

    Bug 26719: Replace MSG_NO_RECORD_SELECTED with translatable string
    
    This patch cleans up some loose ends left by Bug 25351, replacing
    instances where the undefined variable MSG_NO_RECORD_SELECTED is used.
    
    To test, apply the patch and perform a catalog search in the OPAC.
    
    - On the search results page, without checking any checkboxes, use the
      "Select titles to..." menu to try to add to cart and add to a list. In
      each case you should get a "No item was selected" message.
    - View a list which contains one or more titles. Click the "Remove
      from list" link. You should get a "No item was selected" link.
    
    Other instances have been corrected even though they will only be
    triggered if something has broken. For instance, toolbar items in the
    cart window which are disabled shouldn't register the click that might
    trigger the error. And selecting an item for an item-level hold
    shouldn't ever give a warning because at least one radio button should
    always be selected.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 7a2cb71c79ae630bcfe6f4bcfe63bfbfeaf4f550
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Oct 21 03:34:17 2020 +0000

    Bug 26678: Remove incorrect include file from table of transfers
    
    This patch removes a mistakenly-added include file from the transfer
    template which was resulting in a menu being shown in the wrong place.
    
    To test, apply the patch and go to Circulation -> Transfer.
    
    - Submit an item for transfer.
    - In the table of transferred items you should see the title of the
      item linked to the bibliographic details page.
    
    Signed-off-by: David Nind <david at davidnind.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 60af6edbb15df1a6c667eb0cf547268b408eeb18
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Oct 24 00:33:32 2020 +0000

    Bug 26810: Restore OpacCustomSearch news display
    
    To test:
    1 - Define a new opac news entry for OpacCustomSearch
    2 - Browse opac, notice the standard search bar is displayed
    3 - Apply patch
    4 - Note new search bar displays on refresh
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 2dd19840449beadd1f1752bd8cc18f0163f7f8a4
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Oct 22 12:36:13 2020 +0000

    Bug 26784: Silence warns about comparing undefined values for MARC modification templates
    
    This patch simply checks if conditionals are defined before comparing
    
    We don't need to check actions because you cannot save an action without an action :-)
    
    To test:
    1 - Define several actions for a MARC modification template
    2 - Ensure you have actions with no conditionals
    3 - Tail the intranet logs
    4 - Browse to Tools->MARC modification templates
    5 - Click 'Edit actions' for the template you setup above
    6 - Note warns like:
        [2020/10/22 12:30:18] [WARN] Use of uninitialized value in string eq at /kohadevbox/koha/tools/marc_modification_templates.pl line 127.
    7 - Apply patch
    8 - Restart all the things
    9 - Edit actions again and note no more warns
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit be4f0c7639a679b1ec808e6e9cf9af0fc9576e79
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Oct 22 10:59:17 2020 +0000

    Bug 26781: Check for subfield defined rather than truth
    
    To recreate:
     1 - Have a record with 100$0 defined
     2 - Define a Marc Modification template:
        Delete field 100$0
     3 - Perform Batch record modification, enter the record above in the list of records
     4 - Preview the MARC
     5 - Note the entire 100 field has been deleted, don't modify the record
     6 - Apply patch
     7 - Restart all the things
     8 - Test the modification again
     9 - This time the preview confirms only the subfield 0 deleted
    10 - Modify the record
    11 - Confirm the record is correctly updated
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    JD amended patch: Fix typo ony vs only
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a96de8283ba41ebff0d8e1a7c491fc5bcff5dc18
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Oct 20 10:23:25 2020 +0000

    Bug 26747: Show 'Always available' if title always available in overdrive
    
    To test:
    1 - Have a developer account for overdrive, or library credentials
        https://developer.overdrive.com/
    2 - Enter info into 'Overdrive' sysprefs and enable overdrive
    3 - Search for 'house' in the opac
    4 - Click the overdrive link
    5 - Note some titles in the collection show 999999 copies available
    6 - Apply patch
    7 - Note they now say 'Always available'
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 3a5d5367f10fa1101e99748aadf0c076ebd9dea7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Oct 25 23:12:15 2020 +0000

    Bug 25596: DBRev 20.06.00.054
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e3183de77b4bd3ffb164c19b7933aef31039e723
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Sep 9 14:34:34 2020 +0100

    Bug 25596: Identify overpayment refunds for translation
    
    This patch ensures we can uniquely identify automatic overpayment refund
    credits from the accountlines by introducing a new account credit type
    and adding appropriate translations for the new code.
    
    Test plan
    1/ You'll need an overpayment refund to start...
    1a/ Issue yourself and item and set the date due early enough
    to create an overdue fine for at least 2 days worth of overdue fines
    1b/ Run the fines.pl script to add the fines
    1c/ As a patron, pay off the accruing fine
    1d/ Return the item ensuring you backdate it at least a day
    1e/ Check that there is an 'Overpayment refund' credit on the patrons
    account.
    2/ Check that the overpayment string is translatable (i.e. it appears in
    the accounts include file)
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a71596fb395d449a62f5a6417780ed23948755c4
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Oct 7 11:01:02 2020 -0400

    Bug 26627: Print and confirming a hold can cause an infinite loop
    
    Test plan:
    1) Place a hold for pickup at library A
    2) Confirm the hold and print slip
    3) Checkin the item again
    4) Confirm the hold and print slip
    5) The modal returns, do it again
    6) Apply this patch
    7) Reload the page
    8) Repeat steps 1-3
    9) No loop!
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 28d20b92be91ae509a7f71586ada2535d3c2007d
Author: Mark Hofstetter <mark at hofstetter.at>
Date:   Mon Oct 19 17:28:19 2020 +0000

    Bug 26601: Add utf8 encoding to text output of overdue_notices.pl
    
    This patch sets the UTF8 encoding for output of overdue_notices.pl when
    outputting to txt.
    
    To test:
    0/ Check out an item with due date yesterday (use specify due date)
    1/ Create ODUE text with utf8 encoded characters, chinese characters, umlauts etc
       <url>/cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ODUE
    2/ Run
       perl overdue_notices.pl -text ./
    3/ Verify encoding in the generated text file is incorrect
    4/ Apply patch and repeat 2/
    3/ Confirm text now inludes properly encoded characters
    
    Sponsored-by: Styrian State Library
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    With German umlauts on my system the editor still showed the
    characters correctly (probably guessing the right encoding).
    Using Chinese made the problem visible.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b3be51d4ef2145b7db7b48c9ee32f86ddd34a964
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Oct 20 16:55:37 2020 +0000

    Bug 26686: Fix sorting of "updated on" and "time created" on notices tab
    
    In the patron's account in the staff interface there is a tab
    'Notices' that shows all notices sent out to a patron. The
    updated on column would not sort at all, but there was also some
    markup missing for the time created column.
    
    To test:
    - Make sure you have a patron account with some notices, ideally
      with different times and dates
    - Verify that the updated on column doesn't sort at all
    - Apply patch
    - Verify both date columns now sort correctly for different
      DateFormat settings
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e5753d3cff9d763be420733ba4dbcd0ecf6baa23
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Oct 16 09:56:07 2020 +0200

    Bug 26666: (QA follow-up) Add 'USE raw' in template
    
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b9d6b92ac108fd4753fb76346f5d236d8c59f874
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Fri Oct 16 02:00:16 2020 +0200

    Bug 26666: Fix line breaks in addresses displayed with AddressFormat French or German
    
    When Addressformat is set to French or German the addresses on the Details
    tab will display <br /> in plain text. This is because a TT variable is used
    for adding line breaks that is either set to <br /> or "". Then this variable is
    escaped with the html filter... so we see the HTML tag uninterpreted.
    Switching to $raw for this specific case.
    
    To test:
    - Go to any patron account,
    - Fill in the various address fields
    - Switch the AddressFormat system preference to different settings
    - Verify the false display for French and German on the Details tab and
      in the brief info on the left side in the patron account
    - Apply patch
    - Repeat testing
    - All AddressFormats should now display correctly
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 974c93f908179ff16a162d8010ddbd9710fbff46
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Oct 18 22:53:53 2020 +0000

    Bug 6819: Hide individual cancel order links when order line has been received
    
    This is to prevent mistakes - a received order should not be
    cancelled, but 'undo receive' needs to be done first for things
    to turn out correctly.
    
    To test:
    - Create a basket with at least 2 orders
    - Close basket
    - Receive one of your orders at least
    - Go back to the basket
    - Reopen basket
    - The cancel links should only show on the "not received" orders
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 3edbe7d7dc9358e55b4ecc9da5b292a32cadcce9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 15 10:47:55 2020 +0200

    Bug 26445: Fix "back to result" link of the search result browser
    
    Not sure what was the expected behaviour, I am suggesting the following
    one:
    If you are browsing and you click "back to result", you will be
    redirected to the page where the record appear on the search result
    list.
    
    Say you search for "something" that returns 10 page (20 results per
    page)
    Click on first result first page
    Click back to result
    => You see the first page with the first result at the top
    
    Click on second page, 3rd result
    Click back to result
    => You see the second page with the biblio you clicked at the 3rd
    position
    
    Click on second page, 3rd result
    Click next/previous
    Click back to result
    => You see the page where you last result were.
    
    I think the existing expected behaviour was to have the result you
    clicked at the first position of the result page, but I am not sure it
    really makes sense.
    
    Hope this makes sense however!
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 615d97d345429417843a2dd32e838075b3e27495
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jul 31 10:21:27 2020 +0200

    Bug 21811: Add JS confirmation when receiving - at least 1 item to receive
    
    When receiving, the "receive items" form should not be submitted if no
    items are going to be received
    
    Test plan:
    Create an order, close the basket, receive some items
    On the "receive items" form, do not select item (if items are created
    when placing the order) and submit the form
    => You must get a JS alert that prevent the form to be submitted
    Select at least one item, submit again
    => Now it's submitted
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 3bd23a3287345167de50d994d737351174c04936
Author: John Fawcett <john at voipsupport.it>
Date:   Mon Oct 12 11:18:30 2020 +0200

    Bug 26613: Fix it-IT unimarc_framework.sql installer file
    
    This is really an installation issue, though at the
    time of installation it did not result in any error.
    
    During cataloguing in the items menu the "Type of item or material"
    is not constrained by the itemtypes authorised_values (as it is for 942c records).
    
    I have added the itemtypes to the installer sql in unimarc_framework.sql
    as well as adding the description of this field for OPAC, which had been left empty.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 7c74c6636f779bbbaceee74f8704df9ec625815d
Author: John Fawcett <john at voipsupport.it>
Date:   Mon Oct 12 13:06:40 2020 +0200

    Bug 26612: Error during web install for it-IT translation
    
    Patch changes some of the values in the sql statement that inserts 307a
    unimarc row into the marc_subfield_structure which created an SQL error
    on installation.
    
    The fields changed are:
    - isurl now 0 instead of NULL,
    - hidden now -5 instead of NULL,
    - seealso empty string instead of NULL,
    - link empty string instead of NULL.
    
    These field values are now similar to the ones inserted for 306a or 308a.
    The value that caused the SQL error was using NULL for hidden (due to
    the NOT NULL constraint in the table definition).
    
    I have tested the install with this change and found no issues.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4e865d9e72c8828f28aa133940a561981db740d0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Oct 25 23:12:14 2020 +0000

    Bug 26569: DBRev 20.06.00.053
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a96f5deef04bb74fbd826449b4d82f651a67512c
Author: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Date:   Wed Sep 30 13:14:12 2020 +0000

    Bug 26569: Use gender neutral pronouns in system prefernece explanations
    
    To test:
    1 - perform query "select variable,explanation from systempreferences where explanation like '% his %';"
    2 - find 6 sysprefs with gendered pronouns used in explanations
    3 - apply patch, reset_all
    4 - repeat query
    5 - no more gendered pronouns!
    
    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 564ade93cce9231b01db1c4ebfc8f4e5b31e1acd
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Sep 3 16:23:04 2020 +0000

    Bug 8437: Exclude export.pl from plack
    
    When attempting to download large files from Koha plack can timeout
    
    Excluding the script from plack is a simple fix until we have a more permanent fix for this
    issue.
    
    To test:
    1 - Try to export your entire DB from Tools->Export
    2 - If big enough, it fails
    3 - Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf
    4 - Restart all the things
    5 - Repeat export, it succeeds
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 70570debf3128f035d5eaf3d175c61c0ee1bbba3
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Oct 20 13:40:04 2020 +0000

    Bug 26752: Convert OPAC list download modal to dropdown
    
    This patch modifies the OPAC list page so that download options are
    shown in a dropdown menu instead of a modal dialog. This solves a bug
    introduced by the Bootstrap 4 upgrade and makes it consistent with the
    cart interface.
    
    To test, apply the patch and view the contents of a list in the OPAC
    which has multiple items on it.
    
     - In the toolbar at the top of the list contents table the "Download"
       button should now be a dropdown menu.
     - Selecting any of the download options should trigger a download
       prompt.
     - Test with and without some CSV profiles which have been
       configured for use in the OPAC
    
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 23292b53a8bc672f66ae95b1cfb7db5994d1eea5
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Oct 24 23:53:21 2020 +0000

    Bug 23432: (QA follow-up) Add a unit test
    
    prove -v t/db_dependent/StockRotationItems.t
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 6adb1891d2bf602b0434eb87508568e73faa763e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Sep 23 12:28:22 2020 +0100

    Bug 23432: Replace 'die' with 'warn'
    
    This patch simply replaced the die statement with a warn such that the
    cron script may continue to rotate other items even if this item cannot
    be properly rotated due to corrupt data.
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 7e66d6d190af4bd27739bdfe88049899f927c123
Author: Didier Gautheron <didier.gautheron at biblibre.com>
Date:   Tue Aug 18 07:40:50 2020 +0200

    Bug 26232: Empty smart rule fine grace period
    
    Staff can create smart rules with empty (undefined) fine grace period.
    In Overdues.pm undefined firstremind means 0, do the same in Circulation.pm.
    
    To test:
    1. Apply these patches
    2. Run:
       kshell
       prove t/db_dependent/Circulation.t
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f6d614d4596728a3a2808eac2539754023e42262
Author: Didier Gautheron <didier.gautheron at biblibre.com>
Date:   Tue Aug 18 07:39:53 2020 +0200

    Bug 26232: Test for empty smart rule fine grace period
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 395bb760394e6947303de7e342882148944e9026
Author: Björn Nylén <bjorn.nylen at ub.lu.se>
Date:   Tue Oct 20 14:11:16 2020 +0200

    Bug 26750: Deleted items not indexed
    
    After deleting an item it is still searchable in the index. Similar to bug 26507 where record is reindexed before the database is changed.
    
    To test:
    1. Delete an item
    2. Search the barcode in the main search box. You'll find the original record but wiht hte deleted item missing.
    3. Apply patch.
    4. Repeat steps 1-2 (with another item). No record should be found.
    
    Note to test you have to have the indexer running, not the cron job, and it
    needs to be running fast so that the index is updated before the delete
    takes place
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Barcodes/ValueBuilder.pm                        |    3 -
 C4/Circulation.pm                                  |    2 +-
 C4/SIP/Logger.pm                                   |    1 -
 C4/SIP/SIPServer.pm                                |    1 -
 C4/ShelfBrowser.pm                                 |    2 -
 C4/TTParser.pm                                     |    2 -
 Koha.pm                                            |    2 +-
 Koha/Account.pm                                    |    3 +
 Koha/Account/Line.pm                               |    3 +-
 Koha/Item.pm                                       |    4 +-
 Koha/Schema/Result/Aqbudget.pm                     |   33 +-
 Koha/Schema/Result/Aqbudgetperiod.pm               |   21 +-
 Koha/SimpleMARC.pm                                 |    2 +-
 Koha/StockRotationItem.pm                          |    2 +-
 Koha/Z3950Responder.pm                             |    2 -
 Koha/Z3950Responder/GenericSession.pm              |    2 -
 Koha/Z3950Responder/RPN.pm                         |    3 +-
 Koha/Z3950Responder/Session.pm                     |    2 -
 Koha/Z3950Responder/ZebraSession.pm                |    2 -
 debian/templates/apache-shared-intranet-plack.conf |    1 +
 docs/contributors.yaml                             |   15 +-
 .../data/mysql/de-DE/mandatory/auth_values.sql     |    3 -
 .../data/mysql/de-DE/mandatory/auth_values.txt     |    1 -
 .../data/mysql/de-DE/mandatory/class_sources.sql   |   40 -
 .../data/mysql/de-DE/mandatory/class_sources.txt   |    1 -
 .../mysql/de-DE/mandatory/sample_frequencies.sql   |   16 -
 .../mysql/de-DE/mandatory/sample_frequencies.txt   |    1 -
 .../data/mysql/de-DE/mandatory/sample_notices.sql  |  411 --
 .../data/mysql/de-DE/mandatory/sample_notices.txt  |    1 -
 .../de-DE/mandatory/sample_numberpatterns.sql      |   25 -
 .../de-DE/mandatory/sample_numberpatterns.txt      |    1 -
 .../marc21/mandatory/authorities_normal_marc21.sql | 2389 ----------
 .../marc21/mandatory/authorities_normal_marc21.txt |    9 -
 .../marc21/mandatory/marc21_framework_DEFAULT.sql  | 4681 --------------------
 .../marc21/mandatory/marc21_framework_DEFAULT.txt  |    1 -
 .../optional/marc21_default_matching_rules.sql     |   38 -
 .../optional/marc21_default_matching_rules.txt     |    3 -
 .../optional/marc21_sample_fastadd_framework.sql   |   88 -
 .../optional/marc21_sample_fastadd_framework.txt   |    1 -
 .../optional/marc21_simple_bib_frameworks.sql      |  494 ---
 .../optional/marc21_simple_bib_frameworks.txt      |    9 -
 installer/data/mysql/de-DE/optional/auth_val.sql   |   90 -
 installer/data/mysql/de-DE/optional/auth_val.txt   |    3 -
 .../data/mysql/de-DE/optional/csv_profiles.sql     |   12 -
 .../data/mysql/de-DE/optional/csv_profiles.txt     |    3 -
 .../optional/marc21_holdings_coded_values.sql      |  146 -
 .../optional/marc21_holdings_coded_values.txt      |    2 -
 installer/data/mysql/de-DE/optional/parameters.sql |    6 -
 installer/data/mysql/de-DE/optional/parameters.txt |    1 -
 .../data/mysql/de-DE/optional/patron_atributes.sql |    2 -
 .../data/mysql/de-DE/optional/patron_atributes.txt |    2 -
 .../mysql/de-DE/optional/patron_categories.sql     |   23 -
 .../mysql/de-DE/optional/patron_categories.txt     |   26 -
 .../mysql/de-DE/optional/sample_creator_data.sql   |   34 -
 .../mysql/de-DE/optional/sample_creator_data.txt   |    1 -
 .../data/mysql/de-DE/optional/sample_itemtypes.sql |    9 -
 .../data/mysql/de-DE/optional/sample_itemtypes.txt |    1 -
 .../data/mysql/de-DE/optional/sample_libraries.sql |   15 -
 .../data/mysql/de-DE/optional/sample_libraries.txt |    1 -
 .../de-DE/optional/sample_libraries_holidays.sql   |    5 -
 .../de-DE/optional/sample_libraries_holidays.txt   |    4 -
 .../data/mysql/de-DE/optional/sample_news.sql      |    2 -
 .../data/mysql/de-DE/optional/sample_news.txt      |    1 -
 .../data/mysql/de-DE/optional/sample_patrons.sql   |   52 -
 .../data/mysql/de-DE/optional/sample_patrons.txt   |    1 -
 .../mysql/de-DE/optional/sample_z3950_servers.sql  |   11 -
 .../mysql/de-DE/optional/sample_z3950_servers.txt  |    5 -
 .../unimarc/necessari/unimarc_framework.sql        |    8 +-
 installer/data/mysql/kohastructure.sql             |    3 +-
 .../data/mysql/mandatory/account_credit_types.sql  |    1 +
 .../data/mysql/mandatory/account_offset_types.sql  |    1 +
 installer/data/mysql/mandatory/sysprefs.sql        |   12 +-
 installer/data/mysql/updatedatabase.pl             |   77 +
 koha-tmpl/intranet-tmpl/js/browser.js              |    6 +-
 koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss  |   10 +
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |    2 +-
 .../intranet-tmpl/prog/en/includes/accounts.inc    |    1 +
 .../prog/en/includes/authorities_js.inc            |    2 +-
 .../en/includes/member-display-address-style.inc   |    9 +-
 .../intranet-tmpl/prog/en/modules/acqui/basket.tt  |   44 +-
 .../prog/en/modules/acqui/orderreceive.tt          |    5 +
 .../prog/en/modules/admin/admin-home.tt            |   48 +-
 .../prog/en/modules/admin/patron-attr-types.tt     |    2 +-
 .../prog/en/modules/admin/preferences/opac.pref    |    4 +-
 .../prog/en/modules/admin/smart-rules.tt           |    6 +-
 .../prog/en/modules/admin/transport-cost-matrix.tt |    2 +-
 .../cataloguing/value_builder/unimarc_field_105.tt |   16 +-
 .../prog/en/modules/circ/branchtransfers.tt        |    3 +-
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |    1 +
 .../prog/en/modules/members/notices.tt             |   20 +-
 koha-tmpl/intranet-tmpl/prog/js/additem.js         |   52 +-
 .../bootstrap/en/includes/account-table.inc        |    1 +
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |    8 +-
 .../opac-tmpl/bootstrap/en/modules/opac-basket.tt  |   22 +-
 .../bootstrap/en/modules/opac-overdrive-search.tt  |    6 +-
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    4 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |    6 +-
 .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt |   41 +-
 .../opac-tmpl/bootstrap/en/modules/opac-user.tt    |    4 +-
 koha-tmpl/opac-tmpl/bootstrap/js/datatables.js     |    3 +-
 misc/cronjobs/overdue_notices.pl                   |    2 +-
 opac/opac-shelves.pl                               |    6 +
 t/SimpleMARC.t                                     |   14 +-
 t/db_dependent/Circulation.t                       |   34 +-
 t/db_dependent/Koha/Account/Line.t                 |    2 +-
 t/db_dependent/StockRotationItems.t                |    5 +-
 tools/marc_modification_templates.pl               |   18 +-
 xt/sample_notices.t                                |    1 -
 108 files changed, 418 insertions(+), 8873 deletions(-)
 delete mode 100644 installer/data/mysql/de-DE/mandatory/auth_values.sql
 delete mode 100644 installer/data/mysql/de-DE/mandatory/auth_values.txt
 delete mode 100644 installer/data/mysql/de-DE/mandatory/class_sources.sql
 delete mode 100644 installer/data/mysql/de-DE/mandatory/class_sources.txt
 delete mode 100644 installer/data/mysql/de-DE/mandatory/sample_frequencies.sql
 delete mode 100644 installer/data/mysql/de-DE/mandatory/sample_frequencies.txt
 delete mode 100644 installer/data/mysql/de-DE/mandatory/sample_notices.sql
 delete mode 100644 installer/data/mysql/de-DE/mandatory/sample_notices.txt
 delete mode 100644 installer/data/mysql/de-DE/mandatory/sample_numberpatterns.sql
 delete mode 100644 installer/data/mysql/de-DE/mandatory/sample_numberpatterns.txt
 delete mode 100644 installer/data/mysql/de-DE/marcflavour/marc21/mandatory/authorities_normal_marc21.sql
 delete mode 100644 installer/data/mysql/de-DE/marcflavour/marc21/mandatory/authorities_normal_marc21.txt
 delete mode 100644 installer/data/mysql/de-DE/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql
 delete mode 100644 installer/data/mysql/de-DE/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.txt
 delete mode 100644 installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_default_matching_rules.sql
 delete mode 100644 installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_default_matching_rules.txt
 delete mode 100644 installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_sample_fastadd_framework.sql
 delete mode 100644 installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_sample_fastadd_framework.txt
 delete mode 100644 installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql
 delete mode 100644 installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/auth_val.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/auth_val.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/csv_profiles.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/csv_profiles.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/marc21_holdings_coded_values.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/marc21_holdings_coded_values.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/parameters.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/parameters.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/patron_atributes.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/patron_atributes.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/patron_categories.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/patron_categories.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_creator_data.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_creator_data.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_itemtypes.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_itemtypes.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_libraries.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_libraries.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_libraries_holidays.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_libraries_holidays.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_news.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_news.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_patrons.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_patrons.txt
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_z3950_servers.sql
 delete mode 100644 installer/data/mysql/de-DE/optional/sample_z3950_servers.txt


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list