[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.14-15-gae19b9456a

Fri Sep 18 23:23:50 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  ae19b9456a6b974682cad82bb9aa5ea810ec1e86 (commit)
       via  89feb3e59be59ddb6a0b209820f6f10f27700228 (commit)
       via  496224ab8d20ea30c1d18e12f1355dad3113dc00 (commit)
       via  bd490b7f0d2dc5b6379a64432c2c0d6ce7142aab (commit)
      from  fea16655cf9352074dbc7c7fd0346a830aaf6dd7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ae19b9456a6b974682cad82bb9aa5ea810ec1e86
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Sep 18 10:28:33 2019 -0400

    Bug 23086: Search for collection is broken

    It appears that we are quoting the ccode values deep in the search code.
    Under ICU chains this breaks searching by limits

    To recreate
     1 - Setup Koha using Zebra and icuchains
     2 - Add ccode to AdvancedSearchTypes
     3 - In koha-conf.xml set zebra debug level to include request
      <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels>
     4 - Set some items into different ccodes
     5 - On opac perform a search for:
        ccode:NFIC
     6 - It works
     7 - tail -n 50 /var/log/koha/kohadev/zebra-output.log
     8 - Note search request like:
        Search biblios OK 26 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC
     9 - On opac go to advanced search, select Collection, and limit to smae code a s above
    10 - No results
    11 - Check the zebra-output.log:
        Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 'NFIC'
    12 - Apply patch
    13 - Restart all
    14 - Repeat search by collection limit
    15 - Success!
    16 - Check the zebra-output.log:
        Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC
    17 - Add a new ccode value: N)N
    18 - Set some items to that ccode
    19 - Confirm searching by that ccode works

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit bc1b76be4a35403239fbce6f349ee343435cc8a0)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 4733a2a4215c9351a398945ea2546542e4027d43)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit fa08592991a875b81f5cc3c6bec555b0e5f866b8)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit 89feb3e59be59ddb6a0b209820f6f10f27700228
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Jul 15 15:33:18 2020 +0000

    Bug 23086: Unit test

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 40b6e1b8a1a6e74cb4e9a1c422ffa4faa0bdefc0)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 1a6e51934df7f21f9b64f52606edb84180b5be2d)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit df53ab009445f9ed96b2ef99dc5f0d046d16a96c)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit 496224ab8d20ea30c1d18e12f1355dad3113dc00
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jul 27 15:15:44 2020 +0200

    Bug 25729: Prevent Charges/Fees.t to fail on slow server

    We must use t::lib::Dates::compare to compare dates

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit fcd659b2d4cf62df48113567c59392e8dff9696f)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit ddfec0a706c2233ea60bbdb990b5368ceebc982f)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit e1df84e9ecae7d48e91f2e08333b664de39ce912)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit bd490b7f0d2dc5b6379a64432c2c0d6ce7142aab
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Jun 29 15:55:17 2020 +0100

    Bug 25244: Add specific aria-label to search results

    This patch adds an arai-lebel to the select checkboxes on the search
    results page of the OPAC.

    Test plan
    1/ Perform a search that will yield some results
    2/ Inspect the 'checkbox' on the left side of the results table
    3/ Note that there is no arai-label
    4/ Apply patch
    5/ Refresh the search results page
    6/ Inspect the 'checkbox' on the left side of the results table
    7/ Note that the aria-label now appears and contains relavant
    information
    8/ Signoff

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Bug 25244: (follow-up) QA corrections

    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit d1a7112a9054305ead325daedd6bb106a31b346f)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit ea51c1a865c20e29ab6c10bc017cbe40a1b314a3)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 922df35371b4644aa5b729c2fff687ce1ec12a38)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-----------------------------------------------------------------------

Summary of changes:
 C4/Search.pm                                             |  3 +--
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 11 ++++++++---
 t/db_dependent/Koha/Charges/Fees.t                       |  3 ++-
 t/db_dependent/Search.t                                  |  8 +++++++-
 4 files changed, 18 insertions(+), 7 deletions(-)

hooks/post-receive
-- 
main Koha release repository