[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.14-21-g28552e5db0

Sat Sep 19 02:17:21 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  28552e5db0233a10dfccefcd48de268b858426cb (commit)
       via  c36527b83392cf72acae8a86d70e36cc049bad98 (commit)
       via  04da28e407c2536abea8e38c274b1d97d4714330 (commit)
       via  692a5f5f292cc39a28681a6e66e293e5fd0b9254 (commit)
       via  b918c0bb0da9a49c1bbb73523a913265132ee5f9 (commit)
       via  f83a71b356c84b2af23b0fcf4e505b17d055b8a7 (commit)
      from  ae19b9456a6b974682cad82bb9aa5ea810ec1e86 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 28552e5db0233a10dfccefcd48de268b858426cb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jul 20 15:16:29 2020 +0200

    Bug 24379: Fix failing tests (19.05: fix warnings)

    19.05: The warning fix wasn't in 19.05 so not it was introduced in it's
       2nd version.

    kohadev-koha at kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Patrons/Import.t
    t/db_dependent/Koha/Patrons/Import.t .. 2/159
     #   Failed test 'No warning raised by import_patrons'
     #   at t/db_dependent/Koha/Patrons/Import.t line 171.
     # found warning: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2.
     # found warning: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2.
     # didn't expect to find a warning
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2.
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2.
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3> line 2.
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3> line 2.
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_4> line 2.
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_4> line 2.
    t/db_dependent/Koha/Patrons/Import.t .. 152/159 # Looks like you failed 1 test of 159.
    t/db_dependent/Koha/Patrons/Import.t .. Dubious, test returned 1 (wstat 256, 0x100)
    Failed 1/159 subtests

    Test Summary Report
    -------------------
    t/db_dependent/Koha/Patrons/Import.t (Wstat: 256 Tests: 159 Failed: 1)
      Failed test:  39
      Non-zero exit status: 1
    Files=1, Tests=159,  3 wallclock secs ( 0.04 usr  0.01 sys +  2.11 cusr  0.24 csys =  2.40 CPU)
    Result: FAIL

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 545e03c173c789241eb21773a939b4ab7dcc6da4)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit c0e665aeccbc028f4289e7b1c144f844c05b5198)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 493a0f2d540361ed4fef2157a9b852a1a57e126e)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit c36527b83392cf72acae8a86d70e36cc049bad98
Author: Victor Grousset/tuxayo <victor at tuxayo.net>
Date:   Sat Sep 19 01:28:54 2020 +0200

    Bug 24379: DBIC

    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit 04da28e407c2536abea8e38c274b1d97d4714330
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Wed Aug 5 12:07:40 2020 +1200

    Bug 24379: DBRev 19.05.14.002

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit a2139daaa53acfa90d855a5e0df76b47fb964139)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit 692a5f5f292cc39a28681a6e66e293e5fd0b9254
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Jan 8 20:59:38 2020 +0000

    Bug 24379: Make login_attempts not nullable

    While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE

    When trying to reset a patrons password we check that the account is not administratively locked:
    login_attempts != -1

    This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0

    Let's default to 0 like we intend

    To test:
    1 - Create a new patron
    2 - Note their login_attempts is NULL
        SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1
    3 - Enable  OpacResetPassword
    4 - Attempt to reset password before logging in, you cannot
    5 - Apply patch, updatedatabase, restart_all, update schema
    6 - Create another patron
    7 - Their login attempts should be 0
    8 - Attempt to reset password, it works!

    Bug 24379: Fix the test

    First we create a patron using TestBuilder to get a hashref of valid
    info. Then we delete it and create a new patron using Koha::Patron->new
    Once stored, we should call discard_changes to make the calculated
    values available in the currenct object.

    Bug 24379: Don't drop default of 0 for login attempts

    When moving the column we drop the default, this means that DBs upgraded form earlier versions
    get the wrong values set

    To test:
    1 - Checkout 16.11.x
    2 - Reset all
    3 - Checkout master
    4 - updatedatabase
    5 - SHOW CREATE TABLE borrowers;
    6 - Note the column login_attempts defaults to NULL
    7 - Apply patch(es)
    8 - Repeat
    9 - Now it defaults ot 0 (and has NOT NULL if applied all)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 7bb31cffae27dc398a7b4a4decf3623ec65478ac)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 6d675b61ad2dfd8fa6cfd0f58a9ebb8d534bd358)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit f4899bafe35ad8e0c2e9af55068e6ee7f4a7e36e)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit b918c0bb0da9a49c1bbb73523a913265132ee5f9
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Fri Jul 31 03:39:32 2020 +1200

    Bug 25709: DBRev 19.05.14.001

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 54f653d2707a19b58aa0b6065e98f1280769afcd)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit f83a71b356c84b2af23b0fcf4e505b17d055b8a7
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Jul 6 17:56:35 2020 +0000

    Bug 25709: Rename systempreference to NotesToHide

    In an effort to use more inclusive language we have added a new coding guideline:
    https://wiki.koha-community.org/wiki/Coding_Guidelines#TERM3:_Inclusive_Language

    This patchset renames a syspref to be clearer and follow the guideline

    To test:
    1 - Apply patch and updatedatabase
    2 - git grep NotesBlacklist
    3 - Note all remaining occurrences are translations, db updates, and release notes
    4 - Add a field (e.g. '520' ) to the NotesToHide systempreference
    5 - View a record with a 520 field on the opac
    6 - Confirm the field does not show in the 'Title notes' tab

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 5e45076c00b2f72537ba9c81c4535253f1aaadfb)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit f00ce94d94b079a9e8e326ea3bad99e5567d93f2)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit aeb39a61bdef62a0cef6413b9cebcd60b83196f9)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                        |  6 +++---
 Koha.pm                                             |  2 +-
 Koha/Patrons/Import.pm                              | 14 ++++++++++++++
 Koha/Schema/Result/Borrower.pm                      |  8 ++++----
 Koha/Schema/Result/Deletedborrower.pm               |  8 ++++----
 installer/data/mysql/kohastructure.sql              |  4 ++--
 installer/data/mysql/sysprefs.sql                   |  2 +-
 installer/data/mysql/updatedatabase.pl              | 21 +++++++++++++++++++--
 .../en/modules/admin/preferences/cataloguing.pref   |  2 +-
 t/Biblio/GetMarcNotes.t                             |  4 ++--
 t/db_dependent/Koha/Patron.t                        | 21 ++++++++++++++++++++-
 11 files changed, 71 insertions(+), 21 deletions(-)

hooks/post-receive
-- 
main Koha release repository