[Koha-devel] .gitignore

[Henri-Damien LAURENT]

MJ Ray a écrit :
> "Ryan Higgins" <ryan.higgins at liblime.com> wrote:
>   
>> I'd like to suggest that the .gitignore recently pushed to the public repo
>> be removed,
>> and that Koha not enforce any conventions via .gitignore .
>>     
>
> I think this is a decision for QA (is it still Chris covering that? I
> found it mentioned on-list last October but not on the website) but
> Ryan should be able to remove it once in a local branch without much
> problem.
>
> Best wishes,
>   
Hi,
I took the QA position, even though had little time to do thorough tests
of all the patches that are sent daily... And there has been quite a lot
of important ones those days.

About .gitignore, I really donot see what would be wrong this little
commit.
It doesnot impact development and would allow people not to bother about
'faked' diffs when committing things.
I agree it is not a "customer" useful commit.
Adding it to git would just have you commit yours on your local branch
and fetch/rebase instead of pulling. But is this not what we all do ?

Question may be  : does it HAVE to be there ? No.
Question may be  : should it be there ? Maybe, for people who donot know
git enough to be aware of .gitignore
Since it is nicer not to have the list of all the patches or modified
files when you commit things.


You say Koha should not enforce conventions. I had rather have clear
conventions stated so that all the people which comes could know the way
to contribute, coding and naming conventions, like any other big project
rather than none. For instance, we MUST use ODLIS words for templates.
The problem of conventions  has sometimes been debated on this list with
no definite position. But I still think enforcing conventions is
important, all the more than we are providing 2 MARC standards and may
be willing to open Koha to other standards. For instance, it could
prevent us to use in our code $record->title() for a MARC record, since
this is not MARC-flavour agnostic and would allow us to work along and
satisfy our customers.


-- 
Henri-Damien LAURENT


_______________________________________________
Koha-devel mailing list
Koha-devel at nongnu.org
http://lists.nongnu.org/mailman/listinfo/koha-devel