[Koha-devel] TinyMCE Changes Discussion + Initial Patch (part of discussion re: distribution size)

Stan Brinkerhoff koha at vtwireless.com
Tue Dec 30 07:32:49 CET 2008


All,

I am not sure the proper way to do this, and I hope someone can assist me
formalizing and sending this patch to the patches list, or to a maintainer
directly --

TinyMCE is only (as far as I can tell) being used for the help editor.  This
is a 3mb package that is copied to every language specific directory (making
the distribution large!).  I moved it from:

/koha-tmpl/intranet-tmpl/prog/en/js/tinymce

to:

/koha-tmpl/intranet-tmpl/prog/3rdparty_js/

--- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/edithelp.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/help/edithelp.tmpl
@@ -1,6 +1,6 @@
 <!-- TMPL_INCLUDE NAME="doc-head-open.inc" -->
 <title>Online Help</title>
-<script language="javascript" type="text/javascript" src="<!-- TMPL_VAR
name="themelang" -->/js/tinymce/jscripts/tiny_mce/tiny_mce.js"></script>
+<script language="javascript" type="text/javascript"
src="/intranet-tmpl/prog/3rdparty_js/tiny_mce/tiny_mce.js"></script>

Instead of just moving tinymce, I removed version 2.x, and downloaded
3.latest into the new directory.  I also removed some files from the tinymce
distribution (it includes an uncompressed and a compressed verison, i
removed the unused compressed version, and the examples).

These patches end up being 800k in size.  I also have a question as to how
the Makefile needs to handle this change that I hope someone can assist me
with.  The patest (against git) are:
http://brinkerhoff.org/tinymce_patches.tgz

0002-Moving-TINYMCE-to-non-language-specific-directory.patch -- removes
TinyMCE 2.x, and updates the edithelp template above to reference the new
location.
0003-Adding-tiny_mce-3.1.patch -- adds TinyMCE 3.1 to
/intranet-tmpl/prog/3rdparty_js/

Stan Brinkerhoff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-devel/attachments/20081230/d1ab0389/attachment-0003.htm>


More information about the Koha-devel mailing list