[Koha-devel] [Koha-patches] [PATCH] [SIGNED-OFF] Bug 6614: Remove newlines from order notes when exporting to CSV

[Ian Walls]

Any alternate implementation to allowing more characters into the Text::CSV
exports is of course preferable.  My patch was a quick fix for the issue,
but I'll happily see it replaced with a more robust solution.  Thanks to
both Robin and Colin for exploring better options.


-Ian

2011/7/27 Robin Sheat <robin at catalyst.net.nz>

> Op woensdag 27 juli 2011 22:25:22 schreef Colin Campbell:
> > Yes but the problem is that the Text::CSV object is not created as
> > binary. So that the problem is not only with end of lines but with
> > non-ascii characters. see Text::CSV's documentation
>
> Perhaps then we should be outputting as binary? I do a lot with Text::CSV
> for
> reading, but not really for writing. For reading, it's generally the case
> that
> you work in binary mode unless you have a good reason not to.
>
> --
> Robin Sheat
> Catalyst IT Ltd.
> ✆ +64 4 803 2204
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>



-- 
Ian Walls
Lead Development Specialist
ByWater Solutions
Phone # (888) 900-8944
http://bywatersolutions.com
ian.walls at bywatersolutions.com
Twitter: @sekjal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-devel/attachments/20110727/5df729db/attachment.htm>