[Koha-devel] Release Manager 3.6

[Chris Cormack]

On 13 May 2011 03:10, Nicole Engard <nengard at gmail.com> wrote:
> On Thu, May 12, 2011 at 11:07 AM, Paul Poulain
> <paul.poulain at biblibre.com> wrote:
>> It's because we can't ask the customer or the project manager (a
>> librarian) to git format-patch -s !
>
> As a librarian that's just you not giving them enough credit. I agree
> you don't ask the customer (unless the customer wants to do it) but
> you can ask and train your project manager.  We have customers test
> our patches and then they're passed on to one of us for a sign off.
> It's simple, it takes 1 minute more time and it means our patches make
> it to QA.
>
> I feel like this is all being made much harder than it really is.
> Patches must be signed off, we have a policy in place for that, we
> cannot assume that patches have been signed off based on who submits
> them because then we start making exceptions all over the place.
>
Another option is to set the bug to Signed Off
And note in the notes, who signed it off "Billy Bob Library signed
this off on the 12/5/2011, tested also by Janey Joe Library. Developed
internally by sue and james, and signed off internally by kathy"

Also the signed off part of a patch is not anything super special you
don't have to do it with -s

If Lyon has signed off a patch (tested it, approved it works and
breaks nothing else).
You can add

Signed-off-by: Lyon University

To the patch just before the ---, and it will show as signed off. git
is cool like that

Chris