[Koha-devel] Update database changes proposal [IMPORTANT]

[Paul Poulain]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 24/11/2011 13:22, Robin Sheat a écrit :
> Op 25-11-11 00:49, Ian Walls schreef:
>> I do like the idea of hashes... but looking at it, we'd
>> essentially be mimicking the data structure we already have with
>> Git commits.  Plus, readability goes down.
> 
> Is readability an issue here? I was thinking a process like:
> 
> 1) on each page (and this'll improve heaps when we get persistence
> :) the list of patch files is build, concated, CRCed.
There are 2 strong opinions here:
* upgrade is a process you know you're doing, so no need to check on
every page
* upgrade is safer if you check often if you're uptodate: the computer
must fix human mistakes.

Maybe a middle solution would be to have do a check on the login page
only (or on mainpage.pl ?). As it's mandatory to log-in on the staff
interface, that seems fair.

> Perhaps a quick hash/CRC of the filenames of the patches that have
> been applied? Should be quick to generated and test, and will tell
> us immediately if we need to run again.

In a few months, we will have 40 different files. And hashing/CRCing
40 files is not negligible. We want to improve perfs, so I think it's
a wrong idea. On the login page though, I think it's something we can
afford.

(for those who are not reading Bug 6328 (fines in days) and
updatedatabase, I'll also add comments here, and both threads are related)


- -- 
Paul POULAIN
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc
Tel : (33) 4 91 81 35 08
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOzmCvAAoJEK81SonuhyGoizkH/RLfsfNzC/KaWCHk37YUXI8q
Hq86OuwibnT1pdgnn3XY9QkDEiwJRXIh8kjZDQNJJhdJhqwIZvL27vnwon/ZBMJT
No8RM8efuTYKTDvCbNDRSlMtqLXgRhjzfDPJygPZEcYipgRqfq/z1nDvB1dHmnTT
eWNQpQpLu2KX/s0Oduj3PPzln8Ri/nWsWQDgFSTn0/62IQ+ibmSo98TjyjYWZ2Kb
NotSe+MGLLfIHGaf7WpZt6GitYzJA26sWiGFYJI4wd55bm/dapwB5r1ML30WRTm7
6xTCmjRyX/0wZt2gpI9TMmoL7ZKF17TryAWSgNK5/L/Ub86QKfbcNG525CZAR3w=
=/Cjt
-----END PGP SIGNATURE-----