[Koha-devel] Fwd: Koha 3.4.7. // additem.pl

[Alen Vodopijevec]

Hi all!

I suspect that changes in cataloguing/additem.pl caused problem with
visibility of other fields on the form that have "hidden" value other
then "0" (Marc bib framework). Please see detailed description sent on
Koha users list below.

Change that caused it:
http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=cataloguing/additem.pl;h=4442ed328acdd24c79782eb057517f9fe78926ea;hp=6229f0c52715a6c007ca51301f057708a40372ed;hb=4770555855930e45eeaedd1e25a9a39af0861604;hpb=41928b088075a5da9bffb19edf906e94aa84466f



---------- Forwarded message ----------

Hi!

We have a strange behaviour on test upgrade 3.4.4 -> 3.4.7. with
adding an item (additem.pl)

Select options for all fields that have value >0 (2 or 4 for example)
for "hidden" variable in subfield constraints in MARC bibliographic
framework are not shown on Additem form. I'm not sure if this is a
feature or bug.

The only thing that I can see is an addition at around line 203 of additem.pl:

           if ($subfieldlib->{'hidden'}) {
               $subfield_data{marc_value} = qq(<input type="hidden"
$attributes /> $authorised_lib{$value});
           }
           else {
               $subfield_data{marc_value} =CGI::scrolling_list(
# FIXME: factor out scrolling_list
                   -name     => "field_value",
                   -values   => \@authorised_values,
                   -default  => $value,
                   -labels   => \%authorised_lib,
                   -override => 1,
                   -size     => 1,
                   -multiple => 0,
                   -tabindex => 1,
                   -id       =>
"tag_".$tag."_subfield_".$subfieldtag."_".$index_subfield,
                   -class    => "input_marceditor",
               );
           }

If I remove the first IF statement or if I set "hidden" to "0" in MARC
bibliographic framework settings for that particular subfield, select
options are shown.

We have a same issue with 3.6.2 testing Koha. Any suggestions are welcome :).

regards,
alen

--
Alen Vodopijevec (alen at irb.hr)
Library, Rudjer Boskovic Institute
tel.: +385 1 456 0954 (x1293) gsm: +385 98 584 045
http://lib.irb.hr
http://katalog.irb.hr